You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/12/22 15:49:18 UTC

[kudu-CR] KUDU-1812. tool main should set redaction flag default before parsing flags

Hello Dan Burkert, Adar Dembo,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/5563

to review the following change.

Change subject: KUDU-1812. tool_main should set redaction flag default before parsing flags
......................................................................

KUDU-1812. tool_main should set redaction flag default before parsing flags

tool_main sets the default for redaction to be disabled, since we are
typically not logging the results, and thus want to see everything
unredacted. However, in some cases we may want users to send us a WAL
dump, and they may be unhappy sending unredacted data. The WAL dump is
still useful for debugging consensus issues, etc.

This patch allows the user to specify "--log_redact_user_data" in the
tool command line in order to selectively enable redaction.

Change-Id: If780448ca7e163d039ac79b78756280c74754016
---
M src/kudu/tools/tool_main.cc
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/63/5563/1
-- 
To view, visit http://gerrit.cloudera.org:8080/5563
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If780448ca7e163d039ac79b78756280c74754016
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>

[kudu-CR] KUDU-1812. tool main should set redaction flag default before parsing flags

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has abandoned this change.

Change subject: KUDU-1812. tool_main should set redaction flag default before parsing flags
......................................................................


Abandoned

rolled into https://gerrit.cloudera.org/#/c/5566/

-- 
To view, visit http://gerrit.cloudera.org:8080/5563
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: If780448ca7e163d039ac79b78756280c74754016
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins