You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by "RANJITHROSAN17 (via GitHub)" <gi...@apache.org> on 2023/09/07 16:51:10 UTC

[GitHub] [arrow] RANJITHROSAN17 opened a new pull request, #37616: Update tRecordBatch.m

RANJITHROSAN17 opened a new pull request, #37616:
URL: https://github.com/apache/arrow/pull/37616

### Rationale for this change

This pull request addresses the enhancement request outlined in GitHub issue #37592. The request is to add a `NumRows` property to the `arrow.tabular.RecordBatch` class in MATLAB's Arrow library. This enhancement aims to provide users with the ability to query the number of rows in a RecordBatch, which is a valuable functionality for data manipulation and analysis.

### What changes are included in this PR?

In this PR, we have made the following changes to the code:
- Added a `NumRows` property to the `arrow.tabular.RecordBatch` class.
- Implemented a getter method for the `NumRows` property to retrieve the number of rows from the `arrowRecordBatch` property.

### Are these changes tested?

Yes, the changes have been tested to ensure that the `NumRows` property correctly retrieves the number of rows from the underlying `arrowRecordBatch` object. Test cases have been added to validate the functionality.

### Are there any user-facing changes?

Yes, this enhancement introduces a user-facing change by adding the `NumRows` property to the `arrow.tabular.RecordBatch` class. Users can now access the number of rows in a `tRecordBatch` object using `tRecordBatch.NumRows`.

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #37616: Update tRecordBatch.m

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.

github-actions[bot] commented on PR #37616:
URL: https://github.com/apache/arrow/pull/37616#issuecomment-1710486829

   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
   
   Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
   
   Then could you also rename the pull request title in the following format?
   
       GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
   
   or
   
       MINOR: [${COMPONENT}] ${SUMMARY}
   
   In the case of PARQUET issues on JIRA the title also supports:
   
       PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kevingurney commented on pull request #37616: Update tRecordBatch.m

Posted by "kevingurney (via GitHub)" <gi...@apache.org>.

kevingurney commented on PR #37616:
URL: https://github.com/apache/arrow/pull/37616#issuecomment-1714371015

   Hi @RANJITHROSAN17 - do you have any questions relating to this pull request? Is there anything we can do to help?
   
   Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kevingurney commented on pull request #37616: Update tRecordBatch.m

Posted by "kevingurney (via GitHub)" <gi...@apache.org>.

kevingurney commented on PR #37616:
URL: https://github.com/apache/arrow/pull/37616#issuecomment-1723717455

   @RANJITHROSAN17, just checking in again. Are you still interested in working on this issue? Do you need any help working this forward?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Update tRecordBatch.m [arrow]

Posted by "kevingurney (via GitHub)" <gi...@apache.org>.

kevingurney closed pull request #37616: Update tRecordBatch.m
URL: https://github.com/apache/arrow/pull/37616


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] kevingurney commented on pull request #37616: Update tRecordBatch.m

Posted by "kevingurney (via GitHub)" <gi...@apache.org>.

kevingurney commented on PR #37616:
URL: https://github.com/apache/arrow/pull/37616#issuecomment-1710597260

Hi @RANJITHROSAN17, thank you for contributing to the MATLAB interface to Arrow!

A few notes:

1. It looks like the code for your pull request is incomplete. In order to add a `NumRows` property, you will most likely need to add a new `getNumRows` method to the `RecordBatch` C++ Proxy class and then call this Proxy method from a `get.NumRows` method on the MATLAB `arrow.tabular.RecordBatch` class. You can see the way we are planning to implement `NumRows` for `arrow.tabular.Table` for reference ([C++ Proxy `getNumRows` member function](https://github.com/apache/arrow/compare/main...mathworks:arrow:GH-37571?expand=1#diff-c5741330988b204b0475a09c4d41b1b6a5263000c28a66be3f6efd17935ea25fR87) and [MATLAB get.NumRows method](https://github.com/apache/arrow/compare/main...mathworks:arrow:GH-37571?expand=1#diff-e41a88d788ec32e16a75dba6570728e08411a0fb99fb86705ff39a58223858fdR46)]
2. If you haven't already, please refer to the [New Contributor's Guide](https://arrow.apache.org/docs/dev/developers/guide/index.html#guide-introduction) for helpful tips on getting started contributing to the Apache Arrow project.
3. Pull request titles should follow the format: `GH-<github-issue-id>: [<component>] <description>` in order for automatic linking of a pull request to a GitHub issue to occur. For example, the title for this pull request should be: `GH-37592: [MATLAB] Add NumRows property to arrow.tabular.RecordBatch`.
4. In general, it is a good idea for you to take ownership of an issue before you start working on it to inform others. You can take a GitHub issue by commenting `take` on the issue. For example, see: https://github.com/apache/arrow/issues/37448#issuecomment-1698071825.

Please don't hesitate to ask questions if you run into issues.

Thanks!

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Update tRecordBatch.m [arrow]

Posted by "kevingurney (via GitHub)" <gi...@apache.org>.

kevingurney commented on PR #37616:
URL: https://github.com/apache/arrow/pull/37616#issuecomment-1753471250

   It looks like this pull request has gone stale.
   
   Since having a `NumRows` property on `arrow.RecordBatch` is relatively important for an initial release of the MATLAB interface, I plan on following up with a pull request to add this.
   
   Closing this pull request.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org