You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/12/30 06:46:05 UTC
[GitHub] [incubator-eventmesh] weihubeats opened a new pull request, #2745: [ISSUE #2730] Method check a map with containsKey(), before using get() [WebhookUtil]
weihubeats opened a new pull request, #2745:
URL: https://github.com/apache/incubator-eventmesh/pull/2745
Fixes https://github.com/apache/incubator-eventmesh/issues/2730
### Motivation
*Explain the content here.*
*Explain why you want to make the changes and what problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #2745: [ISSUE #2730] Method check a map with containsKey(), before using get() [WebhookUtil]
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #2745:
URL: https://github.com/apache/incubator-eventmesh/pull/2745#issuecomment-1367764564
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/2745?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2745](https://codecov.io/gh/apache/incubator-eventmesh/pull/2745?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fc42a01) into [master](https://codecov.io/gh/apache/incubator-eventmesh/commit/739089925edadb868fd05679bf90db6f9bdf879d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7390899) will **increase** coverage by `0.00%`.
> The diff coverage is `62.50%`.
```diff
@@ Coverage Diff @@
## master #2745 +/- ##
=========================================
Coverage 11.92% 11.92%
Complexity 905 905
=========================================
Files 476 476
Lines 27068 27069 +1
Branches 2753 2754 +1
=========================================
+ Hits 3227 3228 +1
Misses 23554 23554
Partials 287 287
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/2745?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...org/apache/eventmesh/runtime/util/WebhookUtil.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2745/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL3V0aWwvV2ViaG9va1V0aWwuamF2YQ==) | `63.88% <62.50%> (+1.03%)` | :arrow_up: |
| [.../core/protocol/http/push/AsyncHTTPPushRequest.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/2745/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvaHR0cC9wdXNoL0FzeW5jSFRUUFB1c2hSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 merged pull request #2745: [ISSUE #2730] Method check a map with containsKey(), before using get() [WebhookUtil]
Posted by GitBox <gi...@apache.org>.
xwm1992 merged PR #2745:
URL: https://github.com/apache/incubator-eventmesh/pull/2745
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org