You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "JiriOndrusek (via GitHub)" <gi...@apache.org> on 2023/05/02 06:53:09 UTC
[GitHub] [camel-quarkus] JiriOndrusek opened a new pull request, #4867: Attempt #1 to make snmp tests work
JiriOndrusek opened a new pull request, #4867:
URL: https://github.com/apache/camel-quarkus/pull/4867
fixes https://github.com/apache/camel-quarkus/issues/4850
Attempt to remove possible `ConcurrentModificationException` on `Vector`
<!-- Uncomment and fill this section if your PR is not trivial
[ ] An issue should be filed for the change unless this is a trivial change (fixing a typo or similar). One issue should ideally be fixed by not more than one commit and the other way round, each commit should fix just one issue, without pulling in other changes.
[ ] Each commit in the pull request should have a meaningful and properly spelled subject line and body. Copying the title of the associated issue is typically enough. Please include the issue number in the commit message prefixed by #.
[ ] The pull request description should explain what the pull request does, how, and why. If the info is available in the associated issue or some other external document, a link is enough.
[ ] Phrases like Fix #<issueNumber> or Fixes #<issueNumber> will auto-close the named issue upon merging the pull request. Using them is typically a good idea.
[ ] Please run mvn process-resources -Pformat (and amend the changes if necessary) before sending the pull request.
[ ] Contributor guide is your good friend: https://camel.apache.org/camel-quarkus/latest/contributor-guide.html
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #4867: Snmp: reworked tests to avoid flaky failures
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #4867:
URL: https://github.com/apache/camel-quarkus/pull/4867#issuecomment-1532957516
@JiriOndrusek looks good, thanks! Could we please eliminate the compile warnings something like I sent in https://github.com/JiriOndrusek/camel-quarkus/pull/1 ?
I am investigating the failure in the SOAP grouped test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #4867: Snmp: reworked tests to avoid flaky failures
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on PR #4867:
URL: https://github.com/apache/camel-quarkus/pull/4867#issuecomment-1534290658
@ppalaga @jamesnetherton
It is more complicated to backport this change to 2.13.x correctly then expected
Let me explain:
If I backport ([PR](https://github.com/apache/camel-quarkus/pull/4870)) the changes to 2.13.x (which inherits `org.apache.servicemix.bundles.snmp4j` -> tests are flaky. I'm able to see problems approximately in 1 of 4 runs using docker with limited memory. This is not happening on `main` branch, whih uses `org.snmp4j.snmp4j`.
I tried to replace `org.apache.servicemix.bundles.snmp4j` with `org.snmp4j.snmp4j` in BOM. Unfortunatelly there is a change of signature between ` public void addSecurityModel(SecurityModel model) {` and `public SecurityModels addSecurityModel(SecurityModel model) {` (method is called from this camel [line](https://github.com/apache/camel/blob/camel-3.18.x/components/camel-snmp/src/main/java/org/apache/camel/component/snmp/SnmpProducer.java#L75))
The only solution I see is to rewrite the [method](https://github.com/apache/camel/blob/camel-3.18.x/components/camel-snmp/src/main/java/org/apache/camel/component/snmp/SnmpProducer.java#L68-L100) `doStart` in extension's Recorder with the exact same code, but using `org.snmp4j.snmp4j` and verify, that the flakiness is solved.
WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #4867: Snmp: reworked tests to avoid flaky failures
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #4867:
URL: https://github.com/apache/camel-quarkus/pull/4867#issuecomment-1534206093
Thanks @JiriOndrusek!
Could you please check what needs to be done in 2.13.x?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #4867: Snmp: reworked tests to avoid flaky failures
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #4867:
URL: https://github.com/apache/camel-quarkus/pull/4867#issuecomment-1533007919
The SOAP failure is being solved by reverting the breaking change in the test container tag 1.1. @llowinge works on a fig in 1.2 branch - see https://github.com/l2x6/calculator-ws/issues/10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #4867: Attempt #1 to make snmp tests work
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on PR #4867:
URL: https://github.com/apache/camel-quarkus/pull/4867#issuecomment-1531528940
I ran the build a second time and passed like the first time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] llowinge commented on pull request #4867: Snmp: reworked tests to avoid flaky failures
Posted by "llowinge (via GitHub)" <gi...@apache.org>.
llowinge commented on PR #4867:
URL: https://github.com/apache/camel-quarkus/pull/4867#issuecomment-1532999021
@ppalaga Let me try to do fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga merged pull request #4867: Snmp: reworked tests to avoid flaky failures
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga merged PR #4867:
URL: https://github.com/apache/camel-quarkus/pull/4867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #4867: Snmp: reworked tests to avoid flaky failures
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #4867:
URL: https://github.com/apache/camel-quarkus/pull/4867#issuecomment-1532983905
The soap failure is
```
2023-05-03 11:29:10,385 INFO [🐳 .io/.1]] (pool-2-thread-1) Pulling docker image: quay.io/l2x6/calculator-ws:1.1. Please be patient; this may take some time but only needs to be done once.
2023-05-03 11:29:10,580 INFO [🐳 .io/.1]] (docker-java-stream--805919771) Starting to pull image
2023-05-03 11:29:10,606 INFO [🐳 .io/.1]] (docker-java-stream--805919771) Pulling image layers: 0 pending, 0 downloaded, 0 extracted, (0 bytes/0 bytes)
2023-05-03 11:29:11,098 INFO [🐳 .io/.1]] (docker-java-stream--805919771) Pulling image layers: 4 pending, 1 downloaded, 0 extracted, (64 MB/? MB)
2023-05-03 11:29:11,220 INFO [🐳 .io/.1]] (docker-java-stream--805919771) Pulling image layers: 3 pending, 2 downloaded, 0 extracted, (79 MB/? MB)
2023-05-03 11:29:11,408 INFO [🐳 .io/.1]] (docker-java-stream--805919771) Pulling image layers: 2 pending, 3 downloaded, 0 extracted, (92 MB/? MB)
2023-05-03 11:29:13,028 INFO [🐳 .io/.1]] (docker-java-stream--805919771) Pulling image layers: 1 pending, 4 downloaded, 0 extracted, (323 MB/? MB)
2023-05-03 11:29:13,756 INFO [🐳 .io/.1]] (docker-java-stream--805919771) Pulling image layers: 1 pending, 4 downloaded, 1 extracted, (370 MB/? MB)
2023-05-03 11:29:14,529 INFO [🐳 .io/.1]] (docker-java-stream--805919771) Pulling image layers: 0 pending, 5 downloaded, 1 extracted, (431 MB/447 MB)
2023-05-03 11:29:15,737 INFO [🐳 .io/.1]] (docker-java-stream--805919771) Pulling image layers: 0 pending, 5 downloaded, 2 extracted, (432 MB/447 MB)
2023-05-03 11:29:19,535 INFO [🐳 .io/.1]] (docker-java-stream--805919771) Pulling image layers: 0 pending, 5 downloaded, 3 extracted, (446 MB/447 MB)
2023-05-03 11:29:19,588 INFO [🐳 .io/.1]] (docker-java-stream--805919771) Pulling image layers: 0 pending, 5 downloaded, 4 extracted, (446 MB/447 MB)
2023-05-03 11:29:23,146 INFO [🐳 .io/.1]] (docker-java-stream--805919771) Pulling image layers: 0 pending, 5 downloaded, 5 extracted, (447 MB/447 MB)
2023-05-03 11:29:23,154 INFO [🐳 .io/.1]] (docker-java-stream--805919771) Pull complete. 5 layers, pulled in 12s (downloaded 447 MB at 37 MB/s)
2023-05-03 11:29:23,200 INFO [🐳 .io/.1]] (pool-2-thread-1) Creating container for image: quay.io/l2x6/calculator-ws:1.1
2023-05-03 11:29:23,294 INFO [🐳 .io/.1]] (pool-2-thread-1) Container quay.io/l2x6/calculator-ws:1.1 is starting: c8fa87f0c432fda916e340b49b4503d6b50e606de1f00f3f0c5c773d5bc43b7f
2023-05-03 11:29:23,726 INFO [org.tes.con.wai.str.HttpWaitStrategy] (pool-2-thread-1) /heuristic_kapitsa: Waiting for 60 seconds for URL: http://localhost:32768/calculator-ws/CalculatorService?wsdl (where port 32768 maps to container port 8080)
2023-05-03 11:29:24,470 INFO [org.apa.cam.qua.com.cxf.soa.cli.it.CxfClientTestResource] (docker-java-stream--834586101) STDOUT:
2023-05-03 11:29:24,475 INFO [org.apa.cam.qua.com.cxf.soa.cli.it.CxfClientTestResource] (docker-java-stream--834586101) STDOUT: * Error *
2023-05-03 11:29:24,476 INFO [org.apa.cam.qua.com.cxf.soa.cli.it.CxfClientTestResource] (docker-java-stream--834586101) STDOUT: WFLYDM0106: File permissions problems found while attempting to update /opt/jboss/wildfly/domain/configuration/application-users.properties file.
2023-05-03 11:29:24,477 INFO [org.apa.cam.qua.com.cxf.soa.cli.it.CxfClientTestResource] (docker-java-stream--834586101) STDOUT:
2023-05-03 11:29:24,477 INFO [org.apa.cam.qua.com.cxf.soa.cli.it.CxfClientTestResource] (docker-java-stream--834586101) STDERR: Exception in thread "main" org.jboss.as.domain.management.security.adduser.AddUserFailedException: WFLYDM0106: File permissions problems found while attempting to update /opt/jboss/wildfly/domain/configuration/application-users.properties file.
2023-05-03 11:29:24,477 INFO [org.apa.cam.qua.com.cxf.soa.cli.it.CxfClientTestResource] (docker-java-stream--834586101) STDERR: at org.jboss.as.domain-management@18.1.1.Final//org.jboss.as.domain.management.security.adduser.ErrorState.execute(ErrorState.java:72)
2023-05-03 11:29:24,477 INFO [org.apa.cam.qua.com.cxf.soa.cli.it.CxfClientTestResource] (docker-java-stream--834586101) STDERR: at org.jboss.as.domain-management@18.1.1.Final//org.jboss.as.domain.management.security.adduser.AddUser.run(AddUser.java:133)
2023-05-03 11:29:24,477 INFO [org.apa.cam.qua.com.cxf.soa.cli.it.CxfClientTestResource] (docker-java-stream--834586101) STDERR: at org.jboss.as.domain-management@18.1.1.Final//org.jboss.as.domain.management.security.adduser.AddUser.main(AddUser.java:233)
2023-05-03 11:29:24,477 INFO [org.apa.cam.qua.com.cxf.soa.cli.it.CxfClientTestResource] (docker-java-stream--834586101) STDERR: at org.jboss.modules.Module.run(Module.java:353)
2023-05-03 11:29:24,477 INFO [org.apa.cam.qua.com.cxf.soa.cli.it.CxfClientTestResource] (docker-java-stream--834586101) STDERR: at org.jboss.modules.Module.run(Module.java:321)
2023-05-03 11:29:24,477 INFO [org.apa.cam.qua.com.cxf.soa.cli.it.CxfClientTestResource] (docker-java-stream--834586101) STDERR: at org.jboss.modules.Main.main(Main.java:604)
2023-05-03 11:29:24,800 INFO [org.apa.cam.qua.com.cxf.soa.cli.it.CxfClientTestResource] (docker-java-stream--834586101) STDOUT: =========================================================================
2023-05-03 11:29:24,805 INFO [org.apa.cam.qua.com.cxf.soa.cli.it.CxfClientTestResource] (docker-java-stream--834586101) STDOUT:
```
It is caused by the recent change https://github.com/l2x6/calculator-ws/pull/9 in the test container by @llowinge I'll have to revert it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #4867: Snmp: reworked tests to avoid flaky failures
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on PR #4867:
URL: https://github.com/apache/camel-quarkus/pull/4867#issuecomment-1533019172
>
I'll eliminate the warnings as you suggested. Unfortunately the change does not help with the problems in 2.13.x.
I've seen another issue (only warning but seems important - `java.io.IOException: The actual length of the SEQUENCE object org.snmp4j.PDUv1 is 24, but 41 was expected`.
Problem is probably caused by the fact, that 2.13.x uses camel 3.18.6, which uses snmp4j ( <groupId>org.apache.servicemix.bundles</groupId>
<artifactId>org.apache.servicemix.bundles.snmp4j</artifactId> of version 2.6.3_1)
`main` uses org.snmp4j.snmp4j.2.8.15.
I've never seen such issue on main.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #4867: Snmp: reworked tests to avoid flaky failures
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #4867:
URL: https://github.com/apache/camel-quarkus/pull/4867#issuecomment-1533024411
> `java.io.IOException: The actual length of the SEQUENCE object org.snmp4j.PDUv1 is 24, but 41 was expected`.
>
> Problem is probably caused by the fact, that 2.13.x uses camel 3.18.6, which uses snmp4j (
>
> ```
> <groupId>org.apache.servicemix.bundles</groupId>
> <artifactId>org.apache.servicemix.bundles.snmp4j</artifactId> of version 2.6.3_1)
> ```
>
> ```
> `main` uses org.snmp4j.snmp4j.2.8.15.
> ```
Perhaps we should try to upgrade to 2.8.15 in 2.13.x via managing it in our BOM?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #4867: Snmp: reworked tests to avoid flaky failures
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on PR #4867:
URL: https://github.com/apache/camel-quarkus/pull/4867#issuecomment-1533027811
Upgrading to 2.8.15 in our bo, is probably the only viable option. I tried it, but I'm getting `Failed to create Producer for endpoint: snmp://udp:127.0.0.1/43411. Reason: java.lang.NoSuchMethodError: 'void org.snmp4j.security.SecurityModels.addSecurityModel` during execution of the test. I'll continue tomorrow morning with the issue. (I don't think that there should be any such problem)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #4867: Snmp: reworked tests to avoid flaky failures
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #4867:
URL: https://github.com/apache/camel-quarkus/pull/4867#issuecomment-1533020248
The reverted 1.1 image is now available on quay.io and the soap test is passing again for me locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] JiriOndrusek commented on pull request #4867: Snmp: reworked tests to avoid flaky failures
Posted by "JiriOndrusek (via GitHub)" <gi...@apache.org>.
JiriOndrusek commented on PR #4867:
URL: https://github.com/apache/camel-quarkus/pull/4867#issuecomment-1534154567
This PR is prepared to be merged. The failing CI is not related to this PR (cxf-soap). The previous comment is targeting backport to `2.13.x` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org