You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by GitBox <gi...@apache.org> on 2022/02/22 14:26:35 UTC
[GitHub] [trafficserver] brbzull0 opened a new pull request #8695: traffic_ctl - Add rpc invoke option.
brbzull0 opened a new pull request #8695:
URL: https://github.com/apache/trafficserver/pull/8695
Add Input option to invoke a rpc function by specifying the method name and the parameters directly
from the command line.
With this change we now can call any rpc method without the need to support it in traffic_ctl:
```
$ traffic_ctl rpc invoke get_service_descriptor
--> {"id": "50d9431e-85f9-4999-abc7-4f26ac3cc1e1", "jsonrpc": "2.0", "method": "get_service_descriptor"}
<-- {response}
```
This also removed `CustomizableRequest` which is no longer needed(it was unused but left it as base for this case).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode commented on pull request #8695: traffic_ctl - Add rpc invoke option.
Posted by GitBox <gi...@apache.org>.
SolidWallOfCode commented on pull request #8695:
URL: https://github.com/apache/trafficserver/pull/8695#issuecomment-1054839680
Seems it would be nice to have a `--json` option where I can pass in the JSON literally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt commented on pull request #8695: traffic_ctl - Add rpc invoke option.
Posted by GitBox <gi...@apache.org>.
bneradt commented on pull request #8695:
URL: https://github.com/apache/trafficserver/pull/8695#issuecomment-1047961425
[approve ci fedora]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] brbzull0 commented on pull request #8695: traffic_ctl - Add rpc invoke option.
Posted by GitBox <gi...@apache.org>.
brbzull0 commented on pull request #8695:
URL: https://github.com/apache/trafficserver/pull/8695#issuecomment-1047892242
[approve ci fedora]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] SolidWallOfCode commented on a change in pull request #8695: traffic_ctl - Add rpc invoke option.
Posted by GitBox <gi...@apache.org>.
SolidWallOfCode commented on a change in pull request #8695:
URL: https://github.com/apache/trafficserver/pull/8695#discussion_r816349230
##########
File path: include/shared/rpc/RPCRequests.h
##########
@@ -42,7 +42,7 @@ struct JSONRPCRequest {
virtual std::string
Review comment:
Dang, shouldn't that be `std::string const&`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] brbzull0 commented on pull request #8695: traffic_ctl - Add rpc invoke option.
Posted by GitBox <gi...@apache.org>.
brbzull0 commented on pull request #8695:
URL: https://github.com/apache/trafficserver/pull/8695#issuecomment-1048076127
This https://github.com/apache/trafficserver/pull/8694 will fix the autest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] bneradt removed a comment on pull request #8695: traffic_ctl - Add rpc invoke option.
Posted by GitBox <gi...@apache.org>.
bneradt removed a comment on pull request #8695:
URL: https://github.com/apache/trafficserver/pull/8695#issuecomment-1047961425
[approve ci fedora]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] brbzull0 commented on pull request #8695: traffic_ctl - Add rpc invoke option.
Posted by GitBox <gi...@apache.org>.
brbzull0 commented on pull request #8695:
URL: https://github.com/apache/trafficserver/pull/8695#issuecomment-1055340036
> Seems it would be nice to have a `--json` option where I can pass in the JSON literally.
@SolidWallOfCode You can, the `--params` will handle that, internally it will use the YAML parser, so you can pass `json` or `yaml`:
```
traffic_ctl rpc invoke read_files_method --params '{ "filenames": [ "file1", "file2" ] }'
```
or
```
traffic_ctl rpc invoke read_files_method --params 'filenames: ["file1", "file2"]'
```
thanks for the review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] brbzull0 commented on pull request #8695: traffic_ctl - Add rpc invoke option.
Posted by GitBox <gi...@apache.org>.
brbzull0 commented on pull request #8695:
URL: https://github.com/apache/trafficserver/pull/8695#issuecomment-1048078189
[approve ci autest]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] brbzull0 merged pull request #8695: traffic_ctl - Add rpc invoke option.
Posted by GitBox <gi...@apache.org>.
brbzull0 merged pull request #8695:
URL: https://github.com/apache/trafficserver/pull/8695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org