You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Mark Struberg (JIRA)" <ji...@codehaus.org> on 2011/05/24 10:29:22 UTC
[jira] Created: (WAGON-329) FtpWagon currently tries to invoka an
invalid MKD command with nested directories
FtpWagon currently tries to invoka an invalid MKD command with nested directories
---------------------------------------------------------------------------------
Key: WAGON-329
URL: http://jira.codehaus.org/browse/WAGON-329
Project: Maven Wagon
Issue Type: Bug
Components: wagon-ftp
Affects Versions: 1.0-alpha-7
Reporter: Mark Struberg
Currently a wagon request to remotely create a deep subdirectory (unix equivalent would be mkdir -p /dir1/dir2/dir3) will result in a MKD invocation with the full deep subdirectory path.
According to the FTP specification this is *not* valid (RFC-959 http://www.faqs.org/rfcs/rfc959.html APPENDIX II - DIRECTORY COMMANDS).
There might be some FTP servers out there which curreclty create the directory, but 2 ftpd I tried just returned an error.
Instead we should split up the directory paths and walk over them recursively.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (WAGON-329) FtpWagon currently tries to invoka an
invalid MKD command with nested directories
Posted by "Mark Struberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/WAGON-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=268506#action_268506 ]
Mark Struberg commented on WAGON-329:
-------------------------------------
most of the patch got committed in WAGON-331. Now working on the recursive MKD
> FtpWagon currently tries to invoka an invalid MKD command with nested directories
> ---------------------------------------------------------------------------------
>
> Key: WAGON-329
> URL: http://jira.codehaus.org/browse/WAGON-329
> Project: Maven Wagon
> Issue Type: Bug
> Components: wagon-ftp
> Affects Versions: 1.0-alpha-7
> Reporter: Mark Struberg
> Assignee: Mark Struberg
> Attachments: WAGON-329.patch
>
>
> Currently a wagon request to remotely create a deep subdirectory (unix equivalent would be mkdir -p /dir1/dir2/dir3) will result in a MKD invocation with the full deep subdirectory path.
> According to the FTP specification this is *not* valid (RFC-959 http://www.faqs.org/rfcs/rfc959.html APPENDIX II - DIRECTORY COMMANDS).
> There might be some FTP servers out there which curreclty create the directory, but 2 ftpd I tried just returned an error.
> Instead we should split up the directory paths and walk over them recursively.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (WAGON-329) FtpWagon currently tries to invoka an
invalid MKD command with nested directories
Posted by "Mark Struberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/WAGON-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Struberg closed WAGON-329.
-------------------------------
Resolution: Fixed
implemented a recursive ftp mkd (manual recursion) in FtpWagon
> FtpWagon currently tries to invoka an invalid MKD command with nested directories
> ---------------------------------------------------------------------------------
>
> Key: WAGON-329
> URL: http://jira.codehaus.org/browse/WAGON-329
> Project: Maven Wagon
> Issue Type: Bug
> Components: wagon-ftp
> Affects Versions: 1.0-alpha-7
> Reporter: Mark Struberg
> Assignee: Mark Struberg
> Attachments: WAGON-329.patch
>
>
> Currently a wagon request to remotely create a deep subdirectory (unix equivalent would be mkdir -p /dir1/dir2/dir3) will result in a MKD invocation with the full deep subdirectory path.
> According to the FTP specification this is *not* valid (RFC-959 http://www.faqs.org/rfcs/rfc959.html APPENDIX II - DIRECTORY COMMANDS).
> There might be some FTP servers out there which curreclty create the directory, but 2 ftpd I tried just returned an error.
> Instead we should split up the directory paths and walk over them recursively.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (WAGON-329) FtpWagon currently tries to invoka an
invalid MKD command with nested directories
Posted by "Mark Struberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/WAGON-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Struberg updated WAGON-329:
--------------------------------
Attachment: WAGON-329.patch
This is a patch which drops the avalon based old ftp server, upgrades to java5 and a new junit-4 version which we need for finally enabling the TCK. Lots of things are still broken, but the MKD issue is clearly reproducable. This also drops a few stone old dependencies like a <1.0 plexus-utils, avalon, etc
Please review this patch, especially the way I start the FTP server. I just felt that using old plexus for setting up test components is just too complicated and fired up the (Apache MINA based) FTP server manually. If we need this in other places too, then we should of course move this to a real component.
It may be a good idea to create a new maintenance branch from the current trunk and bump the version on wagon to 1.1 or even 2.0 for moving to the latest and greatest stuff. WDYT?
> FtpWagon currently tries to invoka an invalid MKD command with nested directories
> ---------------------------------------------------------------------------------
>
> Key: WAGON-329
> URL: http://jira.codehaus.org/browse/WAGON-329
> Project: Maven Wagon
> Issue Type: Bug
> Components: wagon-ftp
> Affects Versions: 1.0-alpha-7
> Reporter: Mark Struberg
> Attachments: WAGON-329.patch
>
>
> Currently a wagon request to remotely create a deep subdirectory (unix equivalent would be mkdir -p /dir1/dir2/dir3) will result in a MKD invocation with the full deep subdirectory path.
> According to the FTP specification this is *not* valid (RFC-959 http://www.faqs.org/rfcs/rfc959.html APPENDIX II - DIRECTORY COMMANDS).
> There might be some FTP servers out there which curreclty create the directory, but 2 ftpd I tried just returned an error.
> Instead we should split up the directory paths and walk over them recursively.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (WAGON-329) FtpWagon currently tries to invoka an invalid
MKD command with nested directories
Posted by "Olivier Lamy (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/WAGON-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Olivier Lamy updated WAGON-329:
-------------------------------
Fix Version/s: 1.0
> FtpWagon currently tries to invoka an invalid MKD command with nested directories
> ---------------------------------------------------------------------------------
>
> Key: WAGON-329
> URL: https://jira.codehaus.org/browse/WAGON-329
> Project: Maven Wagon
> Issue Type: Bug
> Components: wagon-ftp
> Affects Versions: 1.0-alpha-7
> Reporter: Mark Struberg
> Assignee: Mark Struberg
> Fix For: 1.0
>
> Attachments: WAGON-329.patch
>
>
> Currently a wagon request to remotely create a deep subdirectory (unix equivalent would be mkdir -p /dir1/dir2/dir3) will result in a MKD invocation with the full deep subdirectory path.
> According to the FTP specification this is *not* valid (RFC-959 http://www.faqs.org/rfcs/rfc959.html APPENDIX II - DIRECTORY COMMANDS).
> There might be some FTP servers out there which curreclty create the directory, but 2 ftpd I tried just returned an error.
> Instead we should split up the directory paths and walk over them recursively.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Work started: (WAGON-329) FtpWagon currently tries to invoka
an invalid MKD command with nested directories
Posted by "Mark Struberg (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/WAGON-329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on WAGON-329 started by Mark Struberg.
> FtpWagon currently tries to invoka an invalid MKD command with nested directories
> ---------------------------------------------------------------------------------
>
> Key: WAGON-329
> URL: http://jira.codehaus.org/browse/WAGON-329
> Project: Maven Wagon
> Issue Type: Bug
> Components: wagon-ftp
> Affects Versions: 1.0-alpha-7
> Reporter: Mark Struberg
> Assignee: Mark Struberg
> Attachments: WAGON-329.patch
>
>
> Currently a wagon request to remotely create a deep subdirectory (unix equivalent would be mkdir -p /dir1/dir2/dir3) will result in a MKD invocation with the full deep subdirectory path.
> According to the FTP specification this is *not* valid (RFC-959 http://www.faqs.org/rfcs/rfc959.html APPENDIX II - DIRECTORY COMMANDS).
> There might be some FTP servers out there which curreclty create the directory, but 2 ftpd I tried just returned an error.
> Instead we should split up the directory paths and walk over them recursively.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira