You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Hans Duedal (JIRA)" <ji...@apache.org> on 2011/09/22 14:13:25 UTC
[jira] [Created] (THRIFT-1351) Compiler does not care about binary
strings
Compiler does not care about binary strings
-------------------------------------------
Key: THRIFT-1351
URL: https://issues.apache.org/jira/browse/THRIFT-1351
Project: Thrift
Issue Type: Bug
Components: Node.js - Compiler
Affects Versions: 0.7
Reporter: Hans Duedal
Fix For: 0.8
The node.js lib has support for binary strings, but the compiler does not check for it.
It's quite easily fixed:
https://github.com/onlinecity/thrift/commit/1d86faa2f44c7b8db80595375d6bd0b9b678c0ee
With the fix node.js server implementations can operate on binary arguments.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (THRIFT-1351) Compiler does not care about binary
strings
Posted by "Roger Meier (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roger Meier updated THRIFT-1351:
--------------------------------
Fix Version/s: (was: 0.8)
0.9
> Compiler does not care about binary strings
> -------------------------------------------
>
> Key: THRIFT-1351
> URL: https://issues.apache.org/jira/browse/THRIFT-1351
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Compiler
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Labels: compiler, node, nodejs
> Fix For: 0.9
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> The node.js lib has support for binary strings, but the compiler does not check for it.
> It's quite easily fixed:
> https://github.com/onlinecity/thrift/commit/1d86faa2f44c7b8db80595375d6bd0b9b678c0ee
> With the fix node.js server implementations can operate on binary arguments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (THRIFT-1351) Compiler does not care about
binary strings
Posted by "Roger Meier (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13119542#comment-13119542 ]
Roger Meier commented on THRIFT-1351:
-------------------------------------
Hi Hans,
please provide a patch and grant License to ASF?
see: http://wiki.apache.org/thrift/HowToContribute
Thanks!
-roger
> Compiler does not care about binary strings
> -------------------------------------------
>
> Key: THRIFT-1351
> URL: https://issues.apache.org/jira/browse/THRIFT-1351
> Project: Thrift
> Issue Type: Bug
> Components: Node.js - Compiler
> Affects Versions: 0.7
> Reporter: Hans Duedal
> Labels: compiler, node, nodejs
> Fix For: 0.8
>
> Original Estimate: 5m
> Remaining Estimate: 5m
>
> The node.js lib has support for binary strings, but the compiler does not check for it.
> It's quite easily fixed:
> https://github.com/onlinecity/thrift/commit/1d86faa2f44c7b8db80595375d6bd0b9b678c0ee
> With the fix node.js server implementations can operate on binary arguments.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira