You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2023/01/04 14:57:31 UTC

[GitHub] [beam] Abacn commented on a diff in pull request #24866: Shard Python PreCommit

Abacn commented on code in PR #24866:
URL: https://github.com/apache/beam/pull/24866#discussion_r1061562614


##########
sdks/python/scripts/run_pytest.sh:
##########
@@ -35,20 +35,32 @@ if [[ $pytest_args =~ "-m" ]] || [[ $posargs =~ "-m" ]]; then
   exit 1
 fi
 
+pyargs=""

Review Comment:
   Should this block be effective only when $3 is not exist (i.e. it is ambiguous whether $2 is pyargs or pytest_args). Otherwise there is no way to pass certain args to pyargs (currently there is only `--ignore` though)
   and some comment is appreciative



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org