You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Jayson Minard (JIRA)" <ji...@apache.org> on 2009/05/09 08:50:46 UTC
[jira] Created: (SOLR-1157) Change for timeouts in
RequestHandlerBase (rev674249) broke unit tests due to rsp.getResponse()
returning null
Change for timeouts in RequestHandlerBase (rev674249) broke unit tests due to rsp.getResponse() returning null
--------------------------------------------------------------------------------------------------------------
Key: SOLR-1157
URL: https://issues.apache.org/jira/browse/SOLR-1157
Project: Solr
Issue Type: Bug
Components: search
Affects Versions: 1.4
Reporter: Jayson Minard
Priority: Critical
This code:
<code>
boolean timedOut = (Boolean) rsp.getResponseHeader().get("partialResults") == null ? false : (Boolean) rsp.getResponseHeader().get("partialResults");
if (timedOut) {
numTimeouts++;
rsp.setHttpCaching(false);
}
</code>
in RequestHandlerBase around line 128 breaks unit tests. Needs a null check on getResponseHeader() before going further.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (SOLR-1157) Change for timeouts in
RequestHandlerBase (rev674249) broke unit tests due to rsp.getResponse()
returning null
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Shalin Shekhar Mangar resolved SOLR-1157.
-----------------------------------------
Resolution: Duplicate
Fixed with SOLR-1160.
> Change for timeouts in RequestHandlerBase (rev674249) broke unit tests due to rsp.getResponse() returning null
> --------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-1157
> URL: https://issues.apache.org/jira/browse/SOLR-1157
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.4
> Reporter: Jayson Minard
> Priority: Critical
>
> This code:
> <code>
> boolean timedOut = (Boolean) rsp.getResponseHeader().get("partialResults") == null ? false : (Boolean) rsp.getResponseHeader().get("partialResults");
> if (timedOut) {
> numTimeouts++;
> rsp.setHttpCaching(false);
> }
> </code>
> in RequestHandlerBase around line 128 breaks unit tests. Needs a null check on getResponseHeader() before going further.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SOLR-1157) Change for timeouts in
RequestHandlerBase (rev674249) broke unit tests due to rsp.getResponse()
returning null
Posted by "Shalin Shekhar Mangar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-1157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707641#action_12707641 ]
Shalin Shekhar Mangar commented on SOLR-1157:
---------------------------------------------
Which unit test was this?
> Change for timeouts in RequestHandlerBase (rev674249) broke unit tests due to rsp.getResponse() returning null
> --------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-1157
> URL: https://issues.apache.org/jira/browse/SOLR-1157
> Project: Solr
> Issue Type: Bug
> Components: search
> Affects Versions: 1.4
> Reporter: Jayson Minard
> Priority: Critical
>
> This code:
> <code>
> boolean timedOut = (Boolean) rsp.getResponseHeader().get("partialResults") == null ? false : (Boolean) rsp.getResponseHeader().get("partialResults");
> if (timedOut) {
> numTimeouts++;
> rsp.setHttpCaching(false);
> }
> </code>
> in RequestHandlerBase around line 128 breaks unit tests. Needs a null check on getResponseHeader() before going further.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.