You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "github-actions[bot] (via GitHub)" <gi...@apache.org> on 2023/04/01 08:40:34 UTC

[GitHub] [doris] github-actions[bot] commented on a diff in pull request #18306: [improvement](executor) Reduce ScannnerCtx Scheduling times

github-actions[bot] commented on code in PR #18306:
URL: https://github.com/apache/doris/pull/18306#discussion_r1155079098


##########
be/src/vec/exec/scan/pip_scanner_context.h:
##########
@@ -56,6 +56,15 @@ class PipScannerContext : public vectorized::ScannerContext {
                 return Status::OK();
             }
         }
+        {
+            std::unique_lock<std::mutex> l(_transfer_lock);
+            if (has_enough_space_in_blocks_queue()) {
+                auto submit_st = _scanner_scheduler->submit(this);

Review Comment:
   warning: member access into incomplete type 'doris::vectorized::ScannerScheduler' [clang-diagnostic-error]
   ```cpp
                   auto submit_st = _scanner_scheduler->submit(this);
                                                      ^
   ```
   **be/src/runtime/exec_env.h:31:** forward declaration of 'doris::vectorized::ScannerScheduler'
   ```cpp
   class ScannerScheduler;
         ^
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org