You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Kengo Seki (JIRA)" <ji...@apache.org> on 2015/07/11 16:28:07 UTC
[jira] [Updated] (HADOOP-12197) smart-apply-patch shouldn't print
successful dryrun in apply mode
[ https://issues.apache.org/jira/browse/HADOOP-12197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kengo Seki updated HADOOP-12197:
--------------------------------
Attachment: HADOOP-12197.HADOOP-12111.01.patch
Attaching a patch, though I'm not sure I can understand your intention correctly.
Before applying this patch:
{code}
Patch file /private/tmp/test-patch-hadoop/39431/patch copied to /tmp/apply-patch-25844.17287
Verifying the patch:
git apply --binary -v --check -p0 /private/tmp/test-patch-hadoop/39431/patch
Checking patch hadoop-common-project/hadoop-common/src/main/bin/hadoop.cmd...
Applying the patch:
git apply --binary -v --stat --apply -p0 /private/tmp/test-patch-hadoop/39431/patch
Checking patch hadoop-common-project/hadoop-common/src/main/bin/hadoop.cmd...
Applied patch hadoop-common-project/hadoop-common/src/main/bin/hadoop.cmd cleanly.
.../hadoop-common/src/main/bin/hadoop.cmd | 26 ++++++++++++++++++--
1 file changed, 24 insertions(+), 2 deletions(-)
{code}
After (duplicated "Checking patch …" disappeared):
{code}
Patch file /private/tmp/test-patch-hadoop/45920/patch copied to /tmp/apply-patch-6035.4976
Verifying the patch:
git apply --binary -v --check -p0 /private/tmp/test-patch-hadoop/45920/patch
Checking patch hadoop-common-project/hadoop-common/src/main/bin/hadoop.cmd...
Applying the patch:
git apply --binary -v --stat --apply -p0 /private/tmp/test-patch-hadoop/45920/patch
Applied patch hadoop-common-project/hadoop-common/src/main/bin/hadoop.cmd cleanly.
.../hadoop-common/src/main/bin/hadoop.cmd | 26 ++++++++++++++++++--
1 file changed, 24 insertions(+), 2 deletions(-)
{code}
> smart-apply-patch shouldn't print successful dryrun in apply mode
> -----------------------------------------------------------------
>
> Key: HADOOP-12197
> URL: https://issues.apache.org/jira/browse/HADOOP-12197
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: yetus
> Reporter: Allen Wittenauer
> Attachments: HADOOP-12197.HADOOP-12111.01.patch
>
>
> There is no value in printing the output of the check phase twice if the dryrun was successful since apply will also include dryrun in its output.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)