You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/02 08:57:38 UTC

[GitHub] [arrow] jorgecarleitao commented on pull request #9035: ARROW-11052: [Rust] [DataFusion] Implement metrics for HashJoinExec

jorgecarleitao commented on pull request #9035:
URL: https://github.com/apache/arrow/pull/9035#issuecomment-753449360


   @Dandandan , Thanks a lot for the review. I am approving because even though I consider most of your comments relevant, I do not consider them blocking the merge.
   
   For example, summing the number of rows of all batches is `O(number_of_batches)` and negligible when compared to the time it takes to execute the join, thus being too minor to block this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org