[GitHub] [tinkerpop] rpopov commented on a change in pull request #1175: Tinkerpop 2274 tp33

[GitBox <gi...@apache.org>]

rpopov commented on a change in pull request #1175: Tinkerpop 2274 tp33
URL: https://github.com/apache/tinkerpop/pull/1175#discussion_r312055104
 
 

 ##########
 File path: hadoop-gremlin/pom.xml
 ##########
 @@ -219,6 +219,35 @@ limitations under the License.
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-failsafe-plugin</artifactId>
             </plugin>
+
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-enforcer-plugin</artifactId>
+                <executions>
+                    <execution>
+                        <id>check-hadoop-installed</id>
 
 Review comment:
   My idea is to check the environment the build/tests run in and warn that it is incomplete, instead of throwing cryptic exceptions. Having this stated in the POM serves also as some documentation. In this specific case I could not realize the needed build environment setup neither how the CI environment provides Hadoop libraries for the tests

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services