[GitHub] [nifi] pvillard31 commented on a change in pull request #3882: NIFI-6861 - Added missing display name property for InfluxDB max connection timeout

[GitBox <gi...@apache.org>]

pvillard31 commented on a change in pull request #3882: NIFI-6861 - Added missing display name property for InfluxDB max connection timeout
URL: https://github.com/apache/nifi/pull/3882#discussion_r345646477
 
 

 ##########
 File path: nifi-nar-bundles/nifi-influxdb-bundle/nifi-influxdb-processors/src/main/java/org/apache/nifi/processors/influxdb/AbstractInfluxDBProcessor.java
 ##########
 @@ -56,7 +56,8 @@
             .build();
 
     public static final PropertyDescriptor INFLUX_DB_CONNECTION_TIMEOUT = new PropertyDescriptor.Builder()
-            .name("InfluxDB Max Connection Time Out (seconds)")
+            .name("influxdb-max-connection-time-out")
 
 Review comment:
   Unfortunately I think we don't want this change to happen. As soon as a processor is released, changing the ``.name()`` property would be a breaking change for existing flows with this processor. I think we might want to revisit all the processor for a 2.0 release but it'd need to be discussed and we would need to provide tools for a proper migration.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services