You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2026/10/21 19:17:52 UTC

[PR] [57_maintenance] Fix MSRV CI by installing cargo-msrv with taiki-e/install-action [arrow-rs]

alamb opened a new pull request, #11777:
URL: https://github.com/apache/arrow-rs/pull/11777

   # Which issue does this PR close?
   
   - Part of #11666 (57.3.2 release)
   
   # Rationale for this change
   
   The `Verify MSRV` job fails on PRs against `57_maintenance` (for example #11726) for reasons unrelated to those PRs:
   
   ```
   error: cannot install package `cargo-msrv 0.19.5`, it requires rustc 1.94.1 or newer, while the currently active rustc version is 1.91.1
   `cargo-msrv 0.19.3` supports rustc 1.91.1
   ```
   
   `cargo-msrv` 0.19.4 and 0.19.5 were released today (2026-10-21) and require rustc 1.94.1, but `57_maintenance` pins the toolchain to 1.91 in `rust-toolchain.toml`. `cargo install cargo-msrv --locked` (added in #11728) does not help because `--locked` only pins the dependency graph, not the `cargo-msrv` version itself.
   
   # What changes are included in this PR?
   
   Install `cargo-msrv` using `taiki-e/install-action` (which downloads a prebuilt binary and does not need to compile anything with the pinned toolchain), the same way `main` does since #10589. The action is pinned to the same commit as on `main`.
   
   # Are these changes tested?
   
   CI
   
   # Are there any user-facing changes?
   
   No, CI only.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [57_maintenance] Fix MSRV CI by installing cargo-msrv with taiki-e/install-action & pinning ubuntu [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #11777:
URL: https://github.com/apache/arrow-rs/pull/11777#issuecomment-6329487295

   looks good to me -- thanks @Jefffrey 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [57_maintenance] Fix MSRV CI by installing cargo-msrv with taiki-e/install-action & pinning ubuntu [arrow-rs]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on PR #11777:
URL: https://github.com/apache/arrow-rs/pull/11777#issuecomment-6329429232

   same fix as https://github.com/apache/arrow-rs/pull/11778#issuecomment-6329257122 applied


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [57_maintenance] Fix MSRV CI by installing cargo-msrv with taiki-e/install-action [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #11777:
URL: https://github.com/apache/arrow-rs/pull/11777#issuecomment-6326733499

   > was planning to wait until CI passed to approve this but it doesn't seem like the CI is running 🤔
   
   There is an ASF wide problem, see
   - https://github.com/apache/datafusion/issues/25088
   
   All the projects have long queue times


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [57_maintenance] Fix MSRV CI by installing cargo-msrv with taiki-e/install-action & pinning ubuntu [arrow-rs]

Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey merged PR #11777:
URL: https://github.com/apache/arrow-rs/pull/11777


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [57_maintenance] Fix MSRV CI by installing cargo-msrv with taiki-e/install-action [arrow-rs]

Posted by "Rich-T-kid (via GitHub)" <gi...@apache.org>.
Rich-T-kid commented on PR #11777:
URL: https://github.com/apache/arrow-rs/pull/11777#issuecomment-6324734900

   was planning to wait until CI passed to approve this but it doesn't seem like the CI is running 🤔 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org