You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/12/01 16:22:02 UTC

[GitHub] [phoenix-omid] richardantal opened a new pull request #82: OMID-191 Fix missing executable permission because of MASSEMBLY-941

richardantal opened a new pull request #82:
URL: https://github.com/apache/phoenix-omid/pull/82


   Change-Id: I63aeb3848e94c4c3fedfb2466e037f4211395002


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [phoenix-omid] stoty closed pull request #82: OMID-191 Fix missing executable permission because of MASSEMBLY-941

Posted by GitBox <gi...@apache.org>.
stoty closed pull request #82:
URL: https://github.com/apache/phoenix-omid/pull/82


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [phoenix-omid] stoty commented on pull request #82: OMID-191 Fix missing executable permission because of MASSEMBLY-941

Posted by GitBox <gi...@apache.org>.
stoty commented on pull request #82:
URL: https://github.com/apache/phoenix-omid/pull/82#issuecomment-736992438


   Thanks for the fix @richardantal 
   Committed with some changes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [phoenix-omid] stoty commented on a change in pull request #82: OMID-191 Fix missing executable permission because of MASSEMBLY-941

Posted by GitBox <gi...@apache.org>.
stoty commented on a change in pull request #82:
URL: https://github.com/apache/phoenix-omid/pull/82#discussion_r533897088



##########
File path: pom.xml
##########
@@ -250,6 +251,7 @@
 
                 <plugin>
                     <artifactId>maven-assembly-plugin</artifactId>
+                    <version>${maven-assembly-plugin-version}</version>

Review comment:
       Specifying the version in the pluginManagement section of the top-level pom will set it for every child.
   There's no need to specify the version elsewhere.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org