You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/10/12 19:46:16 UTC

[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3619: Enhance JAVA_HOME detection to support RPM

pan3793 commented on code in PR #3619:
URL: https://github.com/apache/incubator-kyuubi/pull/3619#discussion_r993835946


##########
build/dist:
##########
@@ -114,6 +126,7 @@ if [[ -z "$JAVA_HOME" ]]; then
   exit -1
 fi
 
+export JAVA_HOME="$JAVA_HOME"

Review Comment:
   we should export it, otherwise mvn can not see it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org