You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/05/14 10:48:00 UTC
[GitHub] [pulsar] gotopanic opened a new issue #6962: Pulsar Admin API / Incomplete OpenAPI Spec
gotopanic opened a new issue #6962:
URL: https://github.com/apache/pulsar/issues/6962
**Describe the bug**
it seemed to me that the OpenAPI specification of the [Pulsar Admin REST API (v2)](http://pulsar.apache.org/admin-rest-api/) is incomplete:
- the PUT /namespaces/{tenant}/{namespace} command had a missing in/body parameter for policies
- the GET /non-persistent/{tenant}/{namespace}/{topic}/lastMessageId, POST /non-persistent/{tenant}/{namespace}/{topic}/terminate, GET /persistent/{tenant}/{namespace}/{topic}/lastMessageId and POST /persistent/{tenant}/{namespace}/{topic}/terminate commands specified a MessageId object in their response, but the MessageId object definition has no property unlike the MessageIdImpl object definition.
**To Reproduce**
- Go to: http://pulsar.apache.org/admin-rest-api/
- Download OpenAPI specification
- Observe that the commands above are missing some items
**Expected behavior**
The specification should have the missing items
**Screenshots**
Not a screenshot but a paste from the OpenAPI definitions to illustrate an issue: The MessageId referenced in the response of some commands, doesn't define any property, unlike the MessageIdImpl:
```
"MessageId" : {
"type" : "object"
},
"MessageIdImpl" : {
"type" : "object",
"properties" : {
"ledgerId" : {
"type" : "integer",
"format" : "int64"
},
"entryId" : {
"type" : "integer",
"format" : "int64"
},
"partitionIndex" : {
"type" : "integer",
"format" : "int32"
}
}
},
```
**Desktop (please complete the following information):**
Pulsar Admin 2.5.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] adeal commented on issue #6962: Pulsar Admin API / Incomplete OpenAPI Spec
Posted by GitBox <gi...@apache.org>.
adeal commented on issue #6962:
URL: https://github.com/apache/pulsar/issues/6962#issuecomment-916303906
@gm7y8 were you able to make progress?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gotopanic commented on issue #6962: Pulsar Admin API / Incomplete OpenAPI Spec
Posted by GitBox <gi...@apache.org>.
gotopanic commented on issue #6962:
URL: https://github.com/apache/pulsar/issues/6962#issuecomment-636512130
I have never contributed before, so I would definitely appreciate some help!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] jiazhai commented on issue #6962: Pulsar Admin API / Incomplete OpenAPI Spec
Posted by GitBox <gi...@apache.org>.
jiazhai commented on issue #6962:
URL: https://github.com/apache/pulsar/issues/6962#issuecomment-629903935
@gotopanic Thanks for reporting this issue. Would you like to contribute to it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] zongtanghu commented on issue #6962: Pulsar Admin API / Incomplete OpenAPI Spec
Posted by GitBox <gi...@apache.org>.
zongtanghu commented on issue #6962:
URL: https://github.com/apache/pulsar/issues/6962#issuecomment-636470816
If no one else wanted to contribute for this issue, we can do it! @jiazhai @sijie
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie commented on issue #6962: Pulsar Admin API / Incomplete OpenAPI Spec
Posted by GitBox <gi...@apache.org>.
sijie commented on issue #6962:
URL: https://github.com/apache/pulsar/issues/6962#issuecomment-686947868
@gm7y8 Assigned.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gm7y8 commented on issue #6962: Pulsar Admin API / Incomplete OpenAPI Spec
Posted by GitBox <gi...@apache.org>.
gm7y8 commented on issue #6962:
URL: https://github.com/apache/pulsar/issues/6962#issuecomment-686928048
if no one is working on it can you assign this issue to me?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] gotopanic commented on issue #6962: Pulsar Admin API / Incomplete OpenAPI Spec
Posted by GitBox <gi...@apache.org>.
gotopanic commented on issue #6962:
URL: https://github.com/apache/pulsar/issues/6962#issuecomment-636134433
Sorry, I missed your reply. Yes I will gladly contribute, but I will need some guidance as this would be my first contribution... Would you be the committer who will review as per http://pulsar.apache.org/ja/contributing/ ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org