You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by Nakomis <gi...@git.apache.org> on 2014/07/22 16:42:04 UTC
[GitHub] incubator-brooklyn pull request: Fix/cassandara fabric potential s...
GitHub user Nakomis opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/88
Fix/cassandara fabric potential seeds vs quorum
Builds on #82, and fixes the logic for Cassandra fabric quorum
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Nakomis/incubator-brooklyn fix/cassandara-fabric-potential-seeds-vs-quorum
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/88.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #88
----
commit fede9621588ddf2a60cb58015db4cc00ab60deaa
Author: Aled Sage <al...@gmail.com>
Date: 2014-07-21T13:21:30Z
Improve DynamicFabric test coverage
- for when fabric has existing children
commit 35f267fe7c4a21d4afefc68a5f97caca1e04dfba
Author: Aled Sage <al...@gmail.com>
Date: 2014-07-21T13:31:23Z
DynamicFabric: add existing children as members
commit 406702291832cc21b9cc820d5d78920933f8233d
Author: Aled Sage <al...@gmail.com>
Date: 2014-07-21T13:48:07Z
Adds EntitySpec.groups and EntitySpec.members
commit 0618ea0d8a754730e65bc77ed08d9531ce0dd4e2
Author: Martin Harris <gi...@nakomis.com>
Date: 2014-07-22T14:05:16Z
Fixes logic for potential seed count / quorumSize
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix/cassandara fabric potential s...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/88#issuecomment-51198911
Looks good. Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix/cassandara fabric potential s...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/88
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix/cassandara fabric potential s...
Posted by Nakomis <gi...@git.apache.org>.
Github user Nakomis commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/88#issuecomment-50485186
Rebased as requested
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix/cassandara fabric potential s...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/88#issuecomment-50476444
For #82 not showing as merged, we've reported this to apache infra and commented on https://issues.apache.org/jira/browse/INFRA-8116
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix/cassandara fabric potential s...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/88#discussion_r15464281
--- Diff: software/nosql/src/main/java/brooklyn/entity/nosql/cassandra/CassandraFabricImpl.java ---
@@ -86,8 +86,11 @@
if (seeds == null || seeds.size() < quorumSize || containsDownEntity(seeds)) {
Set<Entity> newseeds;
Map<CassandraDatacenter,Set<Entity>> potentialSeeds = MutableMap.of();
+ int potentialSeedCount = 0;
for (CassandraDatacenter member : Iterables.filter(getMembers(), CassandraDatacenter.class)) {
- potentialSeeds.put(member, member.gatherPotentialSeeds());
+ Set<Entity> dcPotentialSeeds = member.gatherPotentialSeeds();
+ potentialSeeds.put(member, dcPotentialSeeds);
+ potentialSeedCount += potentialSeeds.size();
--- End diff --
This should be `potentialSeedCount += dcPotentialSeeds.size()`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix/cassandara fabric potential s...
Posted by Nakomis <gi...@git.apache.org>.
Github user Nakomis commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/88#issuecomment-50346823
#82 isn't showing as merged
On 28 July 2014 15:22, Aled Sage <no...@github.com> wrote:
> @Nakomis <https://github.com/Nakomis> I've merged #82
> <https://github.com/apache/incubator-brooklyn/pull/82>, where the first 3
> commits came from. Can you rebase this so it just contains the one new
> commit (with the fix above also in that one commit).
>
> —
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/incubator-brooklyn/pull/88#issuecomment-50344591>
> .
>
--
Martin Harris
Lead Software Engineer
Cloudsoft Corporation Ltd
www.cloudsoftcorp.com
Mobile: +44 (0)7989 047-855
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Fix/cassandara fabric potential s...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/88#issuecomment-50344591
@Nakomis I've merged https://github.com/apache/incubator-brooklyn/pull/82, where the first 3 commits came from. Can you rebase this so it just contains the one new commit (with the fix above also in that one commit).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---