Re: [PR] NIFI-14956 - AWS Credentials Provider - Add support for STS AssumeRoleWithWebIdentity [nifi]

["pvillard31 (via GitHub)" <gi...@apache.org>]

pvillard31 commented on code in PR #10294:
URL: https://github.com/apache/nifi/pull/10294#discussion_r2398836108


##########
nifi-extension-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/credentials/provider/service/AWSCredentialsProviderControllerService.java:
##########
@@ -260,6 +263,12 @@ public class AWSCredentialsProviderControllerService extends AbstractControllerS
         .dynamicallyModifiesClasspath(true)
         .build();
 
+    public static final PropertyDescriptor OAUTH2_ACCESS_TOKEN_PROVIDER = new PropertyDescriptor.Builder()
+        .name("OAuth2 Access Token Provider")
+        .description("Controller Service providing OAuth2/OIDC tokens to exchange for AWS temporary credentials using STS AssumeRoleWithWebIdentity.")
+        .identifiesControllerService(OAuth2AccessTokenProvider.class)
+        .required(false)

Review Comment:
   Yeah adding `.dependsOn(ASSUME_ROLE_ARN)`. I did think about adding a strategy property, but it was not obvious how to make it work and be 100% sure that it would not break existing flows during an upgrade. We have quite a lot of possible combinations here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org