You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@pulsar.apache.org by gi...@git.apache.org on 2017/08/07 13:58:48 UTC

[GitHub] maskit commented on a change in pull request #647: Add link checker and fix broken links

maskit commented on a change in pull request #647: Add link checker and fix broken links
URL: https://github.com/apache/incubator-pulsar/pull/647#discussion_r131661068
 
 

 ##########
 File path: site/Makefile
 ##########
 @@ -34,11 +34,14 @@ python_setup:
 	sudo pip install pdoc pygments
 
 setup: ruby_setup
+	scripts/html-setup.sh osx
+
+linkcheck_macos:
+	~/bin/htmltest-osx
 
 Review comment:
   I'm not a big fun of putting the file under a home directory. Why don't you put it under scripts/ or tools/ ?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services