You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "melgenek (via GitHub)" <gi...@apache.org> on 2023/02/01 16:31:27 UTC

[GitHub] [arrow-datafusion] melgenek opened a new pull request, #5148: [sqllogictest] Support `pg_typeof`

melgenek opened a new pull request, #5148:
URL: https://github.com/apache/arrow-datafusion/pull/5148

   # Which issue does this PR close?
   
   Closes #5147.
   
   # Rationale for this change
   
   In sqllogictest tests I could write a query for Datafusion like this one
   ```
   select arrow_typeof(null and null), arrow_typeof(null or null);
   ```
   I would like to write the same query for Postgres, so that not only values are checked for compatibility but also types
   ```
   select pg_typeof(null and null), pg_typeof(null or null);
   ```
   # What changes are included in this PR?
   
   This pr includes handling of `regtype` results in Postgres sqllogictest client.
   
   # Are these changes tested?
   
   Github actions
   
   # Are there any user-facing changes?
   
   Sqllogictest only


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] alamb merged pull request #5148: [sqllogictest] Support `pg_typeof`

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5148:
URL: https://github.com/apache/arrow-datafusion/pull/5148


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] ursabot commented on pull request #5148: [sqllogictest] Support `pg_typeof`

Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5148:
URL: https://github.com/apache/arrow-datafusion/pull/5148#issuecomment-1412842316

   Benchmark runs are scheduled for baseline = 8bae10b73091c2663da003249145c1f3ec56a241 and contender = b6dbb8d8b896861d23dcc17a8a4b3e0e4276db7e. b6dbb8d8b896861d23dcc17a8a4b3e0e4276db7e is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/3b1c4bcb64dd40c3ab6fa44b26d86c1c...d32ea572fa5c40b5bb20957f0596bfa0/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/28347bc439c14394b0b040d27d00bd94...2646397df27445a0888900139581d5b6/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/f0beb9e856a74f988bbe3335a590bd71...157abced1a5f4f6bb48278bc935c84c4/)
   [Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/949103078ed14d66ab1dcbaa992941e2...ac3eb562075d42f28954c38fd08c025b/)
   Buildkite builds:
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] alamb commented on pull request #5148: [sqllogictest] Support `pg_typeof`

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5148:
URL: https://github.com/apache/arrow-datafusion/pull/5148#issuecomment-1412455864

   Thanks @melgenek 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org