You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by bpmcd <gi...@git.apache.org> on 2015/06/10 20:18:14 UTC

[GitHub] incubator-zeppelin pull request: Adding PySparkInterpreterTest for...

GitHub user bpmcd opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/98

    Adding PySparkInterpreterTest for better test coverage.

    The new test class was modeled after the SparkInterpreterTest and
    SparkSqlInterpreterTest classes.
    
    
    https://issues.apache.org/jira/browse/ZEPPELIN-100
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bpmcd/incubator-zeppelin pyspark-tests

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/98.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #98
    
----
commit 8c1dfb9841f8a005637ef27ccd9720e417f737f1
Author: Brian McDevitt <bm...@nerdery.com>
Date:   2015-06-10T12:19:42Z

    Adding PySparkInterpreterTest for better test coverage.
    
    The new test class was modeled after the SparkInterpreterTest and
    SparkSqlInterpreterTest classes.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Adding PySparkInterpreterTest for...

Posted by bpmcd <gi...@git.apache.org>.
Github user bpmcd commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/98#issuecomment-111553323
  
    @Leemoonsoo Sounds good.  I will clean up the Travis failures and update the PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Adding PySparkInterpreterTest for...

Posted by bpmcd <gi...@git.apache.org>.
Github user bpmcd commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/98#issuecomment-111487750
  
    So, are you saying I should move the test methods in PySparkInterpreterTest class to SparkInterpreter class?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Adding PySparkInterpreterTest for...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/98#issuecomment-111533689
  
    @bpmcd Not really, because of the test methods in ZeppelinSparkClusterTest calls REST api to run the test against running ZeppelinServer. it's not available in spark module. So i was meaning more like it would be good if spark module can have test without REST api and ZeppelinServer running.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Adding PySparkInterpreterTest for...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/98#issuecomment-112296007
  
    @bpmcd I'm not sure but, according to travis [documentation](http://docs.travis-ci.com/user/environment-variables/), something like `SPARK_HOME=$TRAVIS_BUILD_DIR/incubator-zeppelin/spark-1.3.1-bin-hadoop2.3` or `SPARK_HOME=$TRAVIS_BUILD_DIR/spark-1.3.1-bin-hadoop2.3` (looks like you already tried this one) should work.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Adding PySparkInterpreterTest for...

Posted by bpmcd <gi...@git.apache.org>.
Github user bpmcd commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/98#issuecomment-112122875
  
    @Leemoonsoo For these tests to pass, the SPARK_HOME variable needs to be absolute.  Any thoughts on how to get the Travis configuration to expand the SPARK_HOME path?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-zeppelin pull request: Adding PySparkInterpreterTest for...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/98#issuecomment-111031487
  
    Awesome. Really great work.
    
    FYI, Recently test for pyspark has been added here https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-server/src/test/java/org/apache/zeppelin/rest/ZeppelinSparkClusterTest.java
    
    unlike ZeppelinSparkClusterTest, If we can have test inside of spark interpreter module, it would be great.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---