You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/09/12 04:03:41 UTC

[GitHub] [shardingsphere] flycoolman commented on a change in pull request #7416: 7307

flycoolman commented on a change in pull request #7416:
URL: https://github.com/apache/shardingsphere/pull/7416#discussion_r487364135



##########
File path: shardingsphere-features/pom.xml
##########
@@ -32,7 +32,7 @@
     <modules>
         <module>shardingsphere-sharding</module>
         <module>shardingsphere-replica</module>
-        <module>shardingsphere-master-slave</module>
+        <module>shardingsphere-primary-replica</module>

Review comment:
       Got it! 
   If there are other places you can imagine to use other names, not just plain translate from master-slave to primary-replica, please let me know.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org