[GitHub] [solr] madrob commented on a change in pull request #225: SOLR-15538 Update Lucene Preview Release dependency

[GitBox <gi...@apache.org>]

madrob commented on a change in pull request #225:
URL: https://github.com/apache/solr/pull/225#discussion_r682949171



##########
File path: solr/core/src/test/org/apache/solr/search/FuzzySearchTest.java
##########
@@ -51,6 +52,7 @@ public void setupCollection() throws Exception {
   }
 
   @Test
+  @Ignore //  no longer too complex in latest Lucene ...

Review comment:
       Do we have an idea of q that _would_ be too complex? If not, let's delete the whole test instead of leaving it around and ignored.

##########
File path: solr/core/src/java/org/apache/solr/analysis/TokenizerChain.java
##########
@@ -49,7 +49,6 @@ public TokenizerChain(CustomAnalyzer customAnalyzer) {
         customAnalyzer.getTokenizerFactory(),
         customAnalyzer.getTokenFilterFactories().toArray(new TokenFilterFactory[0]));
     setPositionIncrementGap(customAnalyzer.getPositionIncrementGap(null));
-    setVersion(customAnalyzer.getVersion());

Review comment:
       It surprises. me that there is no replacement here.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org