You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/05 18:41:56 UTC

[GitHub] [beam] vectorijk opened a new pull request #11058: [SQL] vendor calcite 1.22.0

vectorijk opened a new pull request #11058: [SQL] vendor calcite 1.22.0
URL: https://github.com/apache/beam/pull/11058
 
 
   vendor calcite 1.22.0
   
   ------------------------------------------------------------------------------------------------
   
   Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
   --- | --- | --- | --- | --- | --- | --- | ---
   Go | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
   Java | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
   Python | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[![Build Status](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[![Build Status](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[![Build Status](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/) | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[![Build Status](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
   XLang | --- | --- | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
   
   Pre-Commit Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   
   --- |Java | Python | Go | Website
   --- | --- | --- | --- | ---
   Non-portable | [![Build Status](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[![Build Status](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/) 
   Portable | --- | [![Build Status](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
   
   See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] vectorijk commented on issue #11058: [BEAM-9379] vendor calcite 1.22.0

Posted by GitBox <gi...@apache.org>.
vectorijk commented on issue #11058: [BEAM-9379] vendor calcite 1.22.0
URL: https://github.com/apache/beam/pull/11058#issuecomment-596698482
 
 
   fixed and passed vendored jar validation

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] amaliujia commented on issue #11058: [BEAM-9379] vendor calcite 1.22.0

Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11058: [BEAM-9379] vendor calcite 1.22.0
URL: https://github.com/apache/beam/pull/11058#issuecomment-596709733
 
 
   Thank you @vectorijk.
   
   I will merge this PR after tests pass.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] lukecwik commented on a change in pull request #11058: [BEAM-9379] vendor calcite 1.22.0

Posted by GitBox <gi...@apache.org>.
lukecwik commented on a change in pull request #11058: [BEAM-9379] vendor calcite 1.22.0
URL: https://github.com/apache/beam/pull/11058#discussion_r389886788
 
 

 ##########
 File path: vendor/calcite-1_22_0/build.gradle
 ##########
 @@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+plugins { id 'org.apache.beam.vendor-java' }
+
+description = "Apache Beam :: Vendored Dependencies :: Calcite 1.22.0"
+
+group = "org.apache.beam"
+version = "0.1"
+
+def calcite_version = "1.22.0"
+def avatica_version = "1.16.0"
+def prefix = "org.apache.beam.vendor.calcite.v1_22_0"
+
+List<String> packagesToRelocate = [
+        "antlr",
+        "com.beust",
+        "com.esri",
+        "com.fasterxml",
+        "com.google.common",
+        "com.google.gson",
+        "com.google.inject",
+        "com.google.protobuf",
+        "com.google.thirdparty",
+        "com.jayway.jsonpath",
+        "com.yahoo",
+        "javax",
+        "net.minidev",
+        "net.sf",
+        "org.antlr",
+        "org.aopalliance",
+        "org.apache.calcite",
+        "org.apache.commons",
+        "org.apache.http",
+        "org.apache.tool",
+        "org.apiguardian.api",
+        "org.codehaus",
+        "org.easymock",
+        "org.eclipse.jetty",
+        "org.json",
+        "org.objectweb",
+        "org.objenesis",
+        "org.pentaho",
+        "org.slf4j",
 
 Review comment:
   If you relocate logging, you will lose all logging from this vendored library.
   
   Consider not relocating them and marking them as runtime depedencies.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] amaliujia commented on issue #11058: [BEAM-9379] vendor calcite 1.22.0

Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11058: [BEAM-9379] vendor calcite 1.22.0
URL: https://github.com/apache/beam/pull/11058#issuecomment-596804887
 
 
   Since shading/vendoring seems need more knowledge to do it right, I will also try to test this PR once I have some time this week.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] lukecwik commented on issue #11058: [SQL] vendor calcite 1.22.0

Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11058: [SQL] vendor calcite 1.22.0
URL: https://github.com/apache/beam/pull/11058#issuecomment-595390962
 
 
   Please run the linkage checker to see if there were any changes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] lukecwik commented on issue #11058: [SQL] vendor calcite 1.22.0

Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11058: [SQL] vendor calcite 1.22.0
URL: https://github.com/apache/beam/pull/11058#issuecomment-595854257
 
 
   retest this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] vectorijk commented on issue #11058: [SQL] vendor calcite 1.22.0

Posted by GitBox <gi...@apache.org>.
vectorijk commented on issue #11058: [SQL] vendor calcite 1.22.0
URL: https://github.com/apache/beam/pull/11058#issuecomment-595634115
 
 
   yes, it is optional.  I reduced the set of linkage errors being reported.
   ```
   > Task :checkJavaLinkage
   SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
   SLF4J: Defaulting to no-operation (NOP) logger implementation
   SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
   Class org.apache.tapestry5.ioc.services.Coercion is not found;
     referenced by 2 class files
       org.apache.tapestry5.internal.json.StringToJSONArray (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.tapestry5.internal.json.StringToJSONObject (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class org.apache.tapestry5.ioc.services.CoercionTuple is not found;
     referenced by 1 class file
       org.apache.tapestry5.json.modules.JSONModule (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class org.apache.tapestry5.ioc.Configuration is not found;
     referenced by 1 class file
       org.apache.tapestry5.json.modules.JSONModule (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class org.droidparts.dexmaker.stock.ProxyBuilder is not found;
     referenced by 1 class file
       org.easymock.internal.AndroidClassProxyFactory (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class org.junit.jupiter.api.extension.TestInstancePostProcessor is not found;
     referenced by 1 class file
       org.easymock.EasyMockExtension (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   
   beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar is at:
     org.apache.beam:beam-vendor-calcite-1_22_0:0.1-SNAPSHOT (compile)
   
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] amaliujia commented on issue #11058: [BEAM-9379] vendor calcite 1.22.0

Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11058: [BEAM-9379] vendor calcite 1.22.0
URL: https://github.com/apache/beam/pull/11058#issuecomment-596713933
 
 
   retest this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] vectorijk commented on issue #11058: [SQL] vendor calcite 1.22.0

Posted by GitBox <gi...@apache.org>.
vectorijk commented on issue #11058: [SQL] vendor calcite 1.22.0
URL: https://github.com/apache/beam/pull/11058#issuecomment-595385225
 
 
   R: @amaliujia @apilloud 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] amaliujia commented on issue #11058: [SQL] vendor calcite 1.22.0

Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11058: [SQL] vendor calcite 1.22.0
URL: https://github.com/apache/beam/pull/11058#issuecomment-595389298
 
 
   As I recall, we can merge this PR first and then start a vendor calcite release, right?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] lukecwik commented on a change in pull request #11058: [BEAM-9379] vendor calcite 1.22.0

Posted by GitBox <gi...@apache.org>.
lukecwik commented on a change in pull request #11058: [BEAM-9379] vendor calcite 1.22.0
URL: https://github.com/apache/beam/pull/11058#discussion_r389887843
 
 

 ##########
 File path: vendor/calcite-1_22_0/build.gradle
 ##########
 @@ -0,0 +1,111 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * License); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+plugins { id 'org.apache.beam.vendor-java' }
+
+description = "Apache Beam :: Vendored Dependencies :: Calcite 1.22.0"
+
+group = "org.apache.beam"
+version = "0.1"
+
+def calcite_version = "1.22.0"
+def avatica_version = "1.16.0"
+def prefix = "org.apache.beam.vendor.calcite.v1_22_0"
+
+List<String> packagesToRelocate = [
+        "antlr",
+        "com.beust",
+        "com.esri",
+        "com.fasterxml",
+        "com.google.common",
+        "com.google.gson",
+        "com.google.inject",
+        "com.google.protobuf",
+        "com.google.thirdparty",
+        "com.jayway.jsonpath",
+        "com.yahoo",
+        "javax",
+        "net.minidev",
+        "net.sf",
+        "org.antlr",
+        "org.aopalliance",
+        "org.apache.calcite",
+        "org.apache.commons",
+        "org.apache.http",
+        "org.apache.tool",
+        "org.apiguardian.api",
+        "org.codehaus",
+        "org.easymock",
+        "org.eclipse.jetty",
+        "org.json",
+        "org.objectweb",
+        "org.objenesis",
+        "org.pentaho",
+        "org.slf4j",
+        "org.testng",
+        "org.yaml",
+]
+
+vendorJava(
+        dependencies: [
+                "org.apache.calcite:calcite-core:$calcite_version",
+                "org.apache.calcite:calcite-linq4j:$calcite_version",
+                "org.apache.calcite.avatica:avatica-core:$avatica_version",
+                library.java.protobuf_java,
+                library.java.slf4j_api,
+
+                "cglib:cglib:3.3.0",
+                "com.google.code.gson:gson:2.8.6",
+                "javax.servlet:javax.servlet-api:3.0.1",
+                "javax.transaction:javax.transaction-api:1.2",
+                "org.antlr:stringtemplate:3.2.1",
+                "org.apache.ant:ant:1.9.2",
+                "org.codehaus.jettison:jettison:1.4.0",
+                "org.easymock:easymock:4.1",
+                "org.eclipse.jetty:jetty-jmx:9.4.27.v20200227",
+                "org.json:json:20190722",
+                "org.testng:testng:7.1.0",
+        ],
+        runtimeDependencies: [
+                "com.jayway.jsonpath:json-path:2.4.0",
 
 Review comment:
   Why are you relocating com.jayway and marking json-path as a runtime dependency?
   
   Ditto for other libraries below such as commons-logging, antlr, slf4j

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] lukecwik edited a comment on issue #11058: [SQL] vendor calcite 1.22.0

Posted by GitBox <gi...@apache.org>.
lukecwik edited a comment on issue #11058: [SQL] vendor calcite 1.22.0
URL: https://github.com/apache/beam/pull/11058#issuecomment-595390962
 
 
   Please run the linkage checker to see if there were any changes.
   
   Optionally, reduce the set of linkage errors being reported.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] lukecwik commented on issue #11058: [SQL] vendor calcite 1.22.0

Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11058: [SQL] vendor calcite 1.22.0
URL: https://github.com/apache/beam/pull/11058#issuecomment-595468858
 
 
   > Class net.minidev.json.JSONArray is not found;	
   > Class net.minidev.json.JSONObject is not found;	
   > Class net.minidev.json.JSONStyle is not found;	
   > Class net.minidev.json.JSONValue is not found;	
   > Class net.minidev.json.parser.JSONParser is not found;	
   > Class net.minidev.json.parser.ParseException is not found;	
   > Class net.minidev.json.writer.JsonReaderI is not found;	
   > Class net.minidev.json.writer.JsonReader is not found;
   
   Seem to be new warnings.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] vectorijk commented on issue #11058: [SQL] vendor calcite 1.22.0

Posted by GitBox <gi...@apache.org>.
vectorijk commented on issue #11058: [SQL] vendor calcite 1.22.0
URL: https://github.com/apache/beam/pull/11058#issuecomment-595978375
 
 
   looking these classes without relocating

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] amaliujia commented on issue #11058: [SQL] vendor calcite 1.22.0

Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11058: [SQL] vendor calcite 1.22.0
URL: https://github.com/apache/beam/pull/11058#issuecomment-595389761
 
 
   Run Gradle Build

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] lukecwik edited a comment on issue #11058: [SQL] vendor calcite 1.22.0

Posted by GitBox <gi...@apache.org>.
lukecwik edited a comment on issue #11058: [SQL] vendor calcite 1.22.0
URL: https://github.com/apache/beam/pull/11058#issuecomment-595857534
 
 
   The vendored jar fails validation. You can rerun the validation locally with
   ```
   ./gradlew -p vendor/calcite-1_22_0 check
   ```
   
   Your shading without relocating lots of classes, such as:
   ```
   org/objectweb/asm/AnnotationVisitor.class
   org/objectweb/asm/AnnotationWriter.class
   org/objectweb/asm/Attribute$Set.class
   org/objectweb/asm/Attribute.class
   org/objectweb/asm/ByteVector.class
   org/objectweb/asm/ClassReader.class
   org/objectweb/asm/ClassTooLargeException.class
   org/objectweb/asm/ClassVisitor.class
   org/objectweb/asm/ClassWriter.class
   org/objectweb/asm/ConstantDynamic.class
   org/objectweb/asm/Constants.class
   org/objectweb/asm/Context.class
   ```
   
   The above command will enumerate them all.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] lukecwik commented on issue #11058: [SQL] vendor calcite 1.22.0

Posted by GitBox <gi...@apache.org>.
lukecwik commented on issue #11058: [SQL] vendor calcite 1.22.0
URL: https://github.com/apache/beam/pull/11058#issuecomment-595857534
 
 
   The vendored jar fails validation. You can rerun the validation locally with
   ```
   ./gradlew -p vendor/calcite-1_22_0 check
   ```
   
   Your shading without relocating lots of classes, such as (the above command will enumerate them all):
   ```
   org/objectweb/asm/AnnotationVisitor.class
   org/objectweb/asm/AnnotationWriter.class
   org/objectweb/asm/Attribute$Set.class
   org/objectweb/asm/Attribute.class
   org/objectweb/asm/ByteVector.class
   org/objectweb/asm/ClassReader.class
   org/objectweb/asm/ClassTooLargeException.class
   org/objectweb/asm/ClassVisitor.class
   org/objectweb/asm/ClassWriter.class
   org/objectweb/asm/ConstantDynamic.class
   org/objectweb/asm/Constants.class
   org/objectweb/asm/Context.class
   ```
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] amaliujia commented on issue #11058: [BEAM-9379] vendor calcite 1.22.0

Posted by GitBox <gi...@apache.org>.
amaliujia commented on issue #11058: [BEAM-9379] vendor calcite 1.22.0
URL: https://github.com/apache/beam/pull/11058#issuecomment-596709574
 
 
   retest this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] vectorijk commented on issue #11058: [SQL] vendor calcite 1.22.0

Posted by GitBox <gi...@apache.org>.
vectorijk commented on issue #11058: [SQL] vendor calcite 1.22.0
URL: https://github.com/apache/beam/pull/11058#issuecomment-595458965
 
 
   rerun `./gradlew -PvendoredDependenciesOnly -Ppublishing -PjavaLinkageArtifactIds=beam-vendor-calcite-1_20_0:0.2-SNAPSHOT :checkJavaLinkage` and compared with linkage error in BEAM-9412. I think there is no major changes
   
   ```
   > Task :checkJavaLinkage
   SLF4J: Failed to load class "org.slf4j.impl.StaticLoggerBinder".
   SLF4J: Defaulting to no-operation (NOP) logger implementation
   SLF4J: See http://www.slf4j.org/codes.html#StaticLoggerBinder for further details.
   Class org.slf4j.Logger is not found;
     referenced by 59 class files
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.adapter.enumerable.EnumerableAggregateRule (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.adapter.jdbc.JdbcRules (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.interpreter.Bindables (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.plan.AbstractRelOptPlanner (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.plan.hep.HepPlanner (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.plan.volcano.RelSet (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.plan.volcano.RelSubset (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.plan.volcano.RuleQueue (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.plan.volcano.VolcanoPlanner (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.plan.volcano.VolcanoRuleCall (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.prepare.Prepare (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.rel.AbstractRelNode (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.rel.hint.HintStrategyTable (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.rel.rules.CalcRelSplitter (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.runtime.CalciteException (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.runtime.ResultSetEnumerable (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.sql.SqlDialect (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.sql.dialect.HsqldbSqlDialect (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.sql.dialect.JethroDataSqlDialect (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.sql.dialect.MysqlSqlDialect (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.sql.parser.SqlParserUtil (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.sql.parser.impl.SqlParserImpl (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.sql.validate.SqlValidatorException (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.sql.validate.SqlValidatorImpl (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.sql2rel.RelDecorrelator (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.sql2rel.RelFieldTrimmer (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.sql2rel.SqlToRelConverter (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.util.Benchmark (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.util.Util (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.util.trace.CalciteLogger (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.util.trace.CalciteTimingTracer (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.jdbc.JdbcMeta (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.server.AvaticaJsonHandler (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.server.AvaticaProtobufHandler (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.server.AvaticaSpnegoAuthenticator (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.server.DelegatingAvaticaHandler (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.server.HandlerFactory (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.server.HttpServer (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.server.PropertyBasedSpnegoLoginService (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.server.ServerKeytabJaasConf (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.remote.AvaticaCommonsHttpClientImpl (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.remote.AvaticaCommonsHttpClientSpnegoImpl (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.remote.AvaticaHttpClientFactoryImpl (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.remote.ClientKeytabJaasConf (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.remote.Driver (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.remote.KerberosConnection (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.remote.ProtobufTranslationImpl (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.remote.RemoteProtobufService (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.internal.filter.FilterCompiler (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.internal.filter.RelationalExpressionNode (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.internal.filter.ValueNode (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.internal.JsonContext (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.internal.path.ArrayPathToken (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.internal.path.CompiledPath (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.internal.path.PredicateContextImpl (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.mapper.GsonMappingProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.metrics.MetricsSystemLoader (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.eclipse.jetty.util.log.JettyAwareLogger (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.eclipse.jetty.util.log.Slf4jLog (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class org.slf4j.LoggerFactory is not found;
     referenced by 39 class files
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.plan.RexImplicationChecker (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.plan.VisitorDataContext (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.rel.rules.AbstractMaterializedViewRule (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.runtime.CalciteException (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.runtime.ResultSetEnumerable (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.sql.SqlDialect (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.sql.SqlDialectFactoryImpl (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.sql.pretty.SqlPrettyWriter (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.sql.validate.SqlValidatorException (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.util.Benchmark (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.util.trace.CalciteTrace (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.jdbc.JdbcMeta (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.server.AvaticaJsonHandler (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.server.AvaticaProtobufHandler (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.server.AvaticaSpnegoAuthenticator (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.server.DelegatingAvaticaHandler (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.server.HandlerFactory (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.server.HttpServer (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.server.PropertyBasedSpnegoLoginService (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.server.ServerKeytabJaasConf (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.remote.AvaticaCommonsHttpClientImpl (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.remote.AvaticaCommonsHttpClientSpnegoImpl (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.remote.AvaticaHttpClientFactoryImpl (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.remote.ClientKeytabJaasConf (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.remote.Driver (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.remote.KerberosConnection (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.remote.ProtobufTranslationImpl (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.remote.RemoteProtobufService (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.internal.filter.FilterCompiler (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.internal.filter.RelationalExpressionNode (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.internal.filter.ValueNode (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.internal.JsonContext (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.internal.path.ArrayPathToken (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.internal.path.CompiledPath (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.internal.path.PredicateContextImpl (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.JsonOrgJsonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.mapper.GsonMappingProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.avatica.metrics.MetricsSystemLoader (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.eclipse.jetty.util.log.Slf4jLog (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class org.slf4j.helpers.MessageFormatter is not found;
     referenced by 2 class files
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.util.Litmus (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.eclipse.jetty.util.log.JettyAwareLogger (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class org.slf4j.helpers.FormattingTuple is not found;
     referenced by 2 class files
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.calcite.util.Litmus (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.eclipse.jetty.util.log.JettyAwareLogger (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class com.google.gson.Gson is not found;
     referenced by 2 class files
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.GsonJsonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.mapper.GsonMappingProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class com.google.gson.JsonElement is not found;
     referenced by 2 class files
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.GsonJsonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.mapper.GsonMappingProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class com.google.gson.JsonPrimitive is not found;
     referenced by 1 class file
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.GsonJsonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class com.google.gson.JsonParser is not found;
     referenced by 1 class file
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.GsonJsonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class com.google.gson.JsonArray is not found;
     referenced by 1 class file
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.GsonJsonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class com.google.gson.JsonObject is not found;
     referenced by 1 class file
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.GsonJsonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class org.apache.beam.vendor.calcite.v1_22_0.org.codehaus.jettison.json.JSONArray is not found;
     referenced by 1 class file
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.JettisonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class org.apache.beam.vendor.calcite.v1_22_0.org.codehaus.jettison.json.JSONObject is not found;
     referenced by 1 class file
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.JettisonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class org.apache.beam.vendor.calcite.v1_22_0.org.codehaus.jettison.json.JSONException is not found;
     referenced by 1 class file
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.JettisonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class org.apache.beam.vendor.calcite.v1_22_0.org.codehaus.jettison.json.JSONTokener is not found;
     referenced by 1 class file
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.JettisonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class org.json.JSONException is not found;
     referenced by 1 class file
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.JsonOrgJsonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class org.json.JSONTokener is not found;
     referenced by 1 class file
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.JsonOrgJsonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class org.json.JSONObject is not found;
     referenced by 2 class files
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.JsonOrgJsonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.mapper.JsonOrgMappingProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class org.json.JSONArray is not found;
     referenced by 2 class files
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.JsonOrgJsonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.mapper.JsonOrgMappingProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class org.apache.tapestry5.json.JSONObject is not found;
     referenced by 1 class file
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.TapestryJsonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class org.apache.tapestry5.json.JSONCollection is not found;
     referenced by 1 class file
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.TapestryJsonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class org.apache.tapestry5.json.JSONArray is not found;
     referenced by 1 class file
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.json.TapestryJsonProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class com.google.gson.TypeAdapter is not found;
     referenced by 1 class file
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.mapper.GsonMappingProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class com.google.gson.reflect.TypeToken is not found;
     referenced by 1 class file
       org.apache.beam.vendor.calcite.v1_22_0.com.jayway.jsonpath.spi.mapper.GsonMappingProvider (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class javax.transaction.RollbackException is not found;
     referenced by 1 class file
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.commons.dbcp2.managed.TransactionContext (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class javax.transaction.SystemException is not found;
     referenced by 2 class files
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.commons.dbcp2.managed.TransactionContext (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.commons.dbcp2.managed.TransactionRegistry (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class javax.transaction.Transaction is not found;
     referenced by 1 class file
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.commons.dbcp2.managed.TransactionContext (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class javax.transaction.TransactionSynchronizationRegistry is not found;
     referenced by 1 class file
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.commons.dbcp2.managed.TransactionContext (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class javax.transaction.Synchronization is not found;
     referenced by 1 class file
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.commons.dbcp2.managed.TransactionContext (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class javax.transaction.TransactionManager is not found;
     referenced by 1 class file
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.commons.dbcp2.managed.TransactionRegistry (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class org.apache.tools.ant.taskdefs.compilers.DefaultCompilerAdapter is not found;
     referenced by 1 class file
       org.apache.beam.vendor.calcite.v1_22_0.org.codehaus.janino.AntCompilerAdapter (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class org.apache.tools.ant.types.Path is not found;
     referenced by 1 class file
       org.apache.beam.vendor.calcite.v1_22_0.org.codehaus.janino.AntCompilerAdapter (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class org.apache.tools.ant.taskdefs.Javac is not found;
     referenced by 1 class file
       org.apache.beam.vendor.calcite.v1_22_0.org.codehaus.janino.AntCompilerAdapter (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class org.apache.avalon.framework.logger.Logger is not found;
     referenced by 1 class file
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.commons.logging.impl.AvalonLogger (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class org.apache.log4j.Logger is not found;
     referenced by 1 class file
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.commons.logging.impl.Log4JLogger (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class org.apache.log4j.Level is not found;
     referenced by 1 class file
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.commons.logging.impl.Log4JLogger (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class org.apache.log4j.Priority is not found;
     referenced by 1 class file
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.commons.logging.impl.Log4JLogger (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class org.apache.log.Hierarchy is not found;
     referenced by 1 class file
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.commons.logging.impl.LogKitLogger (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class org.apache.log.Logger is not found;
     referenced by 1 class file
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.commons.logging.impl.LogKitLogger (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class org.eclipse.jetty.jmx.ObjectMBean is not found;
     referenced by 3 class files
       org.eclipse.jetty.server.jmx.AbstractConnectorMBean (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.eclipse.jetty.server.jmx.ServerMBean (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.eclipse.jetty.server.handler.jmx.AbstractHandlerMBean (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class org.slf4j.spi.LocationAwareLogger is not found;
     referenced by 2 class files
       org.eclipse.jetty.util.log.JettyAwareLogger (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
       org.eclipse.jetty.util.log.Slf4jLog (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class net.sf.cglib.proxy.MethodInterceptor is not found;
     referenced by 1 class file
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.commons.pool2.proxy.CglibProxyHandler (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class net.sf.cglib.proxy.Enhancer is not found;
     referenced by 1 class file
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.commons.pool2.proxy.CglibProxySource (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   Class net.sf.cglib.proxy.Factory is not found;
     referenced by 1 class file
       org.apache.beam.vendor.calcite.v1_22_0.org.apache.commons.pool2.proxy.CglibProxySource (beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar)
   
   beam-vendor-calcite-1_22_0-0.1-SNAPSHOT.jar is at:
     org.apache.beam:beam-vendor-calcite-1_22_0:0.1-SNAPSHOT (compile)
   ```
   
   diff https://www.diffchecker.com/JnoAgq4M

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] lukecwik edited a comment on issue #11058: [SQL] vendor calcite 1.22.0

Posted by GitBox <gi...@apache.org>.
lukecwik edited a comment on issue #11058: [SQL] vendor calcite 1.22.0
URL: https://github.com/apache/beam/pull/11058#issuecomment-595468858
 
 
   > Class net.minidev.json.JSONArray is not found;	
   > Class net.minidev.json.JSONObject is not found;	
   > Class net.minidev.json.JSONStyle is not found;	
   > Class net.minidev.json.JSONValue is not found;	
   > Class net.minidev.json.parser.JSONParser is not found;	
   > Class net.minidev.json.parser.ParseException is not found;	
   > Class net.minidev.json.writer.JsonReaderI is not found;	
   > Class net.minidev.json.writer.JsonReader is not found;
   
   Seem to be new warnings. Is the minidev JSON dependency important/optional/provided?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services