[GitHub] [pulsar] eolivelli commented on a diff in pull request #14453: Improve /metrics endpoint performance

[GitBox <gi...@apache.org>]

eolivelli commented on code in PR #14453:
URL: https://github.com/apache/pulsar/pull/14453#discussion_r869929494


##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -2316,6 +2316,11 @@ public class ServiceConfiguration implements PulsarConfiguration {
         doc = "If true, export topic level metrics otherwise namespace level"
     )
     private boolean exposeTopicLevelMetricsInPrometheus = true;
+    @FieldContext(
+            category = CATEGORY_METRICS,
+            doc = "If true, export buffered metrics"
+    )
+    private boolean enableExposeBufferMetrics = false;

Review Comment:
   what about `metricsBufferResponse` ?
   
   the prefix "metrics" makes it clearer that this is something related to metrics
   I would drop "enable" as it is not a "feature" but more a optimisation, probably in the next release we will turn this on by default (maybe you can create a issue)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org