You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/06/26 22:21:09 UTC

[GitHub] [incubator-superset] nytai commented on a change in pull request #10178: style: new toast design closer to SIP-34

nytai commented on a change in pull request #10178:
URL: https://github.com/apache/incubator-superset/pull/10178#discussion_r446435061



##########
File path: superset-frontend/src/components/ListView/Filters.tsx
##########
@@ -145,8 +145,11 @@ function SelectFilter({
           data-test="filters-select"
           themeConfig={filterSelectTheme}
           stylesConfig={filterSelectStyles}
+          // @ts-ignore

Review comment:
       It seems I introduced these issues when I added https://github.com/vtaits/react-select-async-paginate in https://github.com/apache/incubator-superset/pull/10035 and this PR merely uncovered them (for some reason... 🤔). I'll address in another PR if it's possible, the types for that package are quite confusing. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org