You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by cc...@apache.org on 2016/09/26 19:02:23 UTC

incubator-mynewt-newt git commit: newt - Don't duplicate syscfg definitions.

Repository: incubator-mynewt-newt
Updated Branches:
  refs/heads/develop bef54e049 -> 498e1d703


newt - Don't duplicate syscfg definitions.

syscfg #defines were being written twice to the syscfg.h file.  This
wasn't causing any observable problems, but it made the syscfg.h file
confusing.


Project: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-newt/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-newt/commit/498e1d70
Tree: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-newt/tree/498e1d70
Diff: http://git-wip-us.apache.org/repos/asf/incubator-mynewt-newt/diff/498e1d70

Branch: refs/heads/develop
Commit: 498e1d703f64efde44d64fc9dc57000873f51405
Parents: bef54e0
Author: Christopher Collins <cc...@apache.org>
Authored: Mon Sep 26 12:01:33 2016 -0700
Committer: Christopher Collins <cc...@apache.org>
Committed: Mon Sep 26 12:01:33 2016 -0700

----------------------------------------------------------------------
 newt/syscfg/syscfg.go | 4 ----
 1 file changed, 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-mynewt-newt/blob/498e1d70/newt/syscfg/syscfg.go
----------------------------------------------------------------------
diff --git a/newt/syscfg/syscfg.go b/newt/syscfg/syscfg.go
index d95ac6b..04241ec 100644
--- a/newt/syscfg/syscfg.go
+++ b/newt/syscfg/syscfg.go
@@ -805,10 +805,6 @@ func writeSettings(cfg Cfg, w io.Writer) {
 	// Group settings by package name so that the generated header file is
 	// easier to read.
 	pkgEntries := EntriesByPkg(cfg)
-	for _, v := range cfg.Settings {
-		name := v.History[0].Name()
-		pkgEntries[name] = append(pkgEntries[name], v)
-	}
 
 	pkgNames := make([]string, 0, len(pkgEntries))
 	for name, _ := range pkgEntries {