You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Atsuhiko Yamanaka <ym...@jcraft.com> on 2006/06/16 11:18:03 UTC

[PATCH] resultproperty for sshexec

Hi,

The attached patch will add the 'resultproperty'  attribute support to
sshexec task.
You know that  'resultproperty'  is supported by exec task.

There is no problem even if this patch is ignored, but I strongly recommend
to use channel.isClosed() instead of channel.isEOF() in SSHExec.java.
There is a possibility that the current implementation may fail to get
exit-status code in some timing.


Re: [PATCH] resultproperty for sshexec

Posted by Stefan Bodewig <bo...@apache.org>.
On Fri, 16 Jun 2006, Atsuhiko Yamanaka <ym...@jcraft.com> wrote:

> The attached patch will add the 'resultproperty' attribute support
> to sshexec task.  You know that 'resultproperty' is supported by
> exec task.

I had put this mail aside before I went on vacation and just now saw
there is no attachment, soory.

> There is no problem even if this patch is ignored, but I strongly
> recommend to use channel.isClosed() instead of channel.isEOF() in
> SSHExec.java.  There is a possibility that the current
> implementation may fail to get exit-status code in some timing.

Then we should fix it.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org