[jira] [Commented] (YARN-1729) TimelineWebServices always passes primary and secondary filters as strings

["Chris K Wensel (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-1729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14265474#comment-14265474 ] 

Chris K Wensel commented on YARN-1729:
--------------------------------------

Just want to point out that if a value passed to TimelineWebServices#parsePairStr starts with a number, it is parsed as a number, causing the filter to fail if the value is stored as a string. 

That is, the rules for parsing the query string (String vs Object) are not consistent with the put methods that parse the JSON entity.

ckw



> TimelineWebServices always passes primary and secondary filters as strings
> --------------------------------------------------------------------------
>
>                 Key: YARN-1729
>                 URL: https://issues.apache.org/jira/browse/YARN-1729
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Billie Rinaldi
>            Assignee: Billie Rinaldi
>             Fix For: 2.4.0
>
>         Attachments: YARN-1729.1.patch, YARN-1729.2.patch, YARN-1729.3.patch, YARN-1729.4.patch, YARN-1729.5.patch, YARN-1729.6.patch, YARN-1729.7.patch
>
>
> Primary filters and secondary filter values can be arbitrary json-compatible Object.  The web services should determine if the filters specified as query parameters are objects or strings before passing them to the store.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)