You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oleg Nechiporenko <on...@apache.org> on 2017/03/09 12:04:43 UTC

Review Request 57457: Remove duplicate code from wizard menu

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57457/
-----------------------------------------------------------

Review request for Ambari and Denys Buzhor.


Bugs: AMBARI-20375
    https://issues.apache.org/jira/browse/AMBARI-20375


Repository: ambari


Description
-------

{{'isStep..Disabled'}} and {{'isStep..Completed'}} may be rewritten as computed macros


Diffs
-----

  ambari-web/app/mixins/wizard/wizard_menu_view.js 90b7354 
  ambari-web/app/views/main/service/reassign_view.js 4adbf11 


Diff: https://reviews.apache.org/r/57457/diff/1/


Testing
-------

20573 passing (22s)
  153 pending


Thanks,

Oleg Nechiporenko

Re: Review Request 57457: Remove duplicate code from wizard menu

Posted by Denys Buzhor <bd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57457/#review168440
-----------------------------------------------------------


Ship it!




Ship It!

- Denys Buzhor


On March 9, 2017, 12:04 p.m., Oleg Nechiporenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57457/
> -----------------------------------------------------------
> 
> (Updated March 9, 2017, 12:04 p.m.)
> 
> 
> Review request for Ambari and Denys Buzhor.
> 
> 
> Bugs: AMBARI-20375
>     https://issues.apache.org/jira/browse/AMBARI-20375
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> {{'isStep..Disabled'}} and {{'isStep..Completed'}} may be rewritten as computed macros
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/mixins/wizard/wizard_menu_view.js 90b7354 
>   ambari-web/app/views/main/service/reassign_view.js 4adbf11 
> 
> 
> Diff: https://reviews.apache.org/r/57457/diff/1/
> 
> 
> Testing
> -------
> 
> 20573 passing (22s)
>   153 pending
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>