You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by GitBox <gi...@apache.org> on 2020/11/16 13:00:38 UTC
[GitHub] [james-project] jeantil opened a new pull request #261: JAMES-1902 reorganizes blob modules
jeantil opened a new pull request #261:
URL: https://github.com/apache/james-project/pull/261
This PR also removes a couple duplicate dependencies that were present in the POM files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #261: JAMES-1902 reorganizes blob modules
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #261:
URL: https://github.com/apache/james-project/pull/261#issuecomment-728616446
> Should it be configured to run automatically on every compile ?
And abort the build if needed? => :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on a change in pull request #261: JAMES-1902 reorganizes blob modules
Posted by GitBox <gi...@apache.org>.
jeantil commented on a change in pull request #261:
URL: https://github.com/apache/james-project/pull/261#discussion_r524265938
##########
File path: server/container/guice/blob/blob-api-guice/pom.xml
##########
@@ -25,7 +25,7 @@
<groupId>org.apache.james</groupId>
<artifactId>james-server-guice</artifactId>
<version>3.6.0-SNAPSHOT</version>
- <relativePath>../pom.xml</relativePath>
+ <relativePath>../../pom.xml</relativePath>
Review comment:
the queue-xxx- modules were already in *clean* directories ( neither prefix nor suffix)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil edited a comment on pull request #261: JAMES-1902 reorganizes blob modules
Posted by GitBox <gi...@apache.org>.
jeantil edited a comment on pull request #261:
URL: https://github.com/apache/james-project/pull/261#issuecomment-728066998
>We did not run that for ages, but the rules still applies, and we should do a run... (conflicts likely expected!) You are very right...
Should it be configured to run automatically on every compile ?
something like
```
mvn compile -Psort
```
to make it easier to sort the modules ? then each new PR can commit the fixed poms it has modified
after a while a mass commit of usually untouched pom files and then a strict enforcement right into mvn compile ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a change in pull request #261: JAMES-1902 reorganizes blob modules
Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #261:
URL: https://github.com/apache/james-project/pull/261#discussion_r524258532
##########
File path: server/container/guice/blob/blob-api-guice/pom.xml
##########
@@ -25,7 +25,7 @@
<groupId>org.apache.james</groupId>
<artifactId>james-server-guice</artifactId>
<version>3.6.0-SNAPSHOT</version>
- <relativePath>../pom.xml</relativePath>
+ <relativePath>../../pom.xml</relativePath>
Review comment:
Should we do the same for the queue-xx-guice modules, if any?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on pull request #261: JAMES-1902 reorganizes blob modules
Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #261:
URL: https://github.com/apache/james-project/pull/261#issuecomment-728017295
Looking to make sure I had the proper sort order in the POM files I stumbled upon sortpom, wich led me to `site/src/xdoc/contribute` which helpfully provides:
```
mvn com.github.ekryd.sortpom:sortpom-maven-plugin:sort -Dsort.keepBlankLines -Dsort.sortDependencies=groupId,artifactId -Dsort.nrOfIndentSpace=4 -Dsort.createBackupFile=false -Dsort.sortModules=true -Dsort.expandEmptyElements=false -Dsort.predefinedSortOrder="recommended_2008_06"
```
I'm not sure if this recommandation is still applicable because running it returned over 150 incorrectly sorted pom, I applied the fixes to pom files from :
- `server/container/guice/queue/*`
- `server/container/guice/blob/*`
- `server/container/guice/pom.xml`
hopefully that's ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil closed pull request #261: JAMES-1902 reorganizes blob modules
Posted by GitBox <gi...@apache.org>.
jeantil closed pull request #261:
URL: https://github.com/apache/james-project/pull/261
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #261: JAMES-1902 reorganizes blob modules
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #261:
URL: https://github.com/apache/james-project/pull/261#issuecomment-729342563
I just merged this work. Can we close the PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on a change in pull request #261: JAMES-1902 reorganizes blob modules
Posted by GitBox <gi...@apache.org>.
chibenwa commented on a change in pull request #261:
URL: https://github.com/apache/james-project/pull/261#discussion_r524253411
##########
File path: server/container/guice/blob/blob-api-guice/pom.xml
##########
@@ -25,7 +25,7 @@
<groupId>org.apache.james</groupId>
<artifactId>james-server-guice</artifactId>
<version>3.6.0-SNAPSHOT</version>
- <relativePath>../pom.xml</relativePath>
+ <relativePath>../../pom.xml</relativePath>
Review comment:
Does it makes sense to keep the blob- prefix for folders inside a blob directory? Idem for the guice suffix.
Shouldn't the naming scheme be guice/blob/api ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on pull request #261: JAMES-1902 reorganizes blob modules
Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #261:
URL: https://github.com/apache/james-project/pull/261#issuecomment-728066998
>We did not run that for ages, but the rules still applies, and we should do a run... (conflicts likely expected!) You are very right...
Should it be configured to run automatically on every compile ?
something like
```
mvn compile -Psort
```
to make it easier to sort the modules ? then each new PR can commit the fixed poms it has modified
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] chibenwa commented on pull request #261: JAMES-1902 reorganizes blob modules
Posted by GitBox <gi...@apache.org>.
chibenwa commented on pull request #261:
URL: https://github.com/apache/james-project/pull/261#issuecomment-728032056
We did not run that for ages, but the rules still applies, and we should do a run... (conflicts likely expected!) You are very right...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
[GitHub] [james-project] jeantil commented on a change in pull request #261: JAMES-1902 reorganizes blob modules
Posted by GitBox <gi...@apache.org>.
jeantil commented on a change in pull request #261:
URL: https://github.com/apache/james-project/pull/261#discussion_r524257613
##########
File path: server/container/guice/blob/blob-api-guice/pom.xml
##########
@@ -25,7 +25,7 @@
<groupId>org.apache.james</groupId>
<artifactId>james-server-guice</artifactId>
<version>3.6.0-SNAPSHOT</version>
- <relativePath>../pom.xml</relativePath>
+ <relativePath>../../pom.xml</relativePath>
Review comment:
you are right, I wanted to minimize changes but should have included that bit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org