You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2019/07/20 22:22:05 UTC

[Bug 63574] New: HTTP Cache Manager does not cache

https://bz.apache.org/bugzilla/show_bug.cgi?id=63574

            Bug ID: 63574
           Summary: HTTP Cache Manager does not cache
           Product: JMeter
           Version: 5.1.1
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: HTTP
          Assignee: issues@jmeter.apache.org
          Reporter: flavio6311@gmail.com
  Target Milestone: JMETER_5.2

Created attachment 36669
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=36669&action=edit
HTTP CACHE MANAGER

ON the jmeter.apache.org, there is a file new-style.css that I'd want to add to
cache. However, this file is not cached by using the HTTP Cache Manager with
the default options. The file has two caching headers Last-Modified  and  ETag. 

In my view, that file should be cached in conformity to its headers.
It's easy to reproduce my question. Just add one HTTP sampler to Jmeter Home
and iterate two times. After that, examine the view result tree, looking for
new-style.css in both iterations.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 63574] HTTP Cache Manager does not cache resource if Cache-Control header is missing

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63574

--- Comment #1 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
My understanding of this
https://paulcalvano.com/index.php/2018/03/14/http-heuristic-caching-missing-cache-control-and-expires-headers-explained/
and rfc leads to the fix I made.

@Team, can you please review and confirm that I am correct ?

Thanks

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 63574] HTTP Cache Manager does not cache resource if Cache-Control header is missing

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63574

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED
           Keywords|                            |FixedInTrunk

--- Comment #2 from Philippe Mouawad <p....@ubik-ingenierie.com> ---
This is an automated email from the ASF dual-hosted git repository.

pmouawad pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/jmeter.git


The following commit(s) were added to refs/heads/master by this push:
     new 5883d81  Bug 63574 - HTTP Cache Manager does not cache resource if
Cache-Control header is missing
5883d81 is described below

commit 5883d81abf5f0b4e7f4134aa6560ba21a62f5c43
Author: pmouawad <p....@ubik-ingenierie.com>
AuthorDate: Sun Jul 28 11:14:31 2019 +0200

    Bug 63574 - HTTP Cache Manager does not cache resource if Cache-Control
    header is missing

    This resolves Bug 63574
---
 .../jmeter/protocol/http/control/CacheManager.java |  4 ++--
 .../http/control/TestCacheManagerBase.java         | 22 ++++++++++++++++++++++
 xdocs/changes.xml                                  |  3 ++-
 3 files changed, 26 insertions(+), 3 deletions(-)

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 63574] HTTP Cache Manager does not cache resource if Cache-Control header is missing

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63574

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|HTTP Cache Manager does not |HTTP Cache Manager does not
                   |cache resource if           |cache resource if
                   |Cache-Control is missing    |Cache-Control header is
                   |                            |missing

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 63574] HTTP Cache Manager does not cache resource if Cache-Control is missing

Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=63574

Philippe Mouawad <p....@ubik-ingenierie.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|HTTP Cache Manager does not |HTTP Cache Manager does not
                   |cache                       |cache resource if
                   |                            |Cache-Control is missing
            Version|5.1.1                       |2.13
                 CC|                            |p.mouawad@ubik-ingenierie.c
                   |                            |om
                 OS|Linux                       |All
           Hardware|PC                          |All

-- 
You are receiving this mail because:
You are the assignee for the bug.