You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2020/08/17 11:50:53 UTC
[GitHub] [systemds] Shafaq-Siddiqi opened a new pull request #1023: [WIP][SYSTEMDS-2625]: Cleanup GMM [SYSTEMDS-200] with builtin for LogSumExp
Shafaq-Siddiqi opened a new pull request #1023:
URL: https://github.com/apache/systemds/pull/1023
This cleanup includes the functions reordering, branching cleanups and elimination of lists, now matrices are used for storing covariance. The private function logSumExp is replaced with a new builtin logSumExp().
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] mboehm7 commented on pull request #1023: [WIP][SYSTEMDS-2625]: Cleanup GMM [SYSTEMDS-200] with builtin for LogSumExp
Posted by GitBox <gi...@apache.org>.
mboehm7 commented on pull request #1023:
URL: https://github.com/apache/systemds/pull/1023#issuecomment-724965141
Thanks for the cleanup @Shafaq-Siddiqi - when finalizing the rework, could you please also have a look into (1) making the default number of components consistent with the documentation (1 vs 3), and (2) add tests with default configurations but more than one component (right now it fails for me with dimension mismatches with n=10 but runs fine with n=1). Once this PR is out of WIP status, I'll have a look and merge it in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] asfgit closed pull request #1023: [SYSTEMDS-2625]: Cleanup GMM [SYSTEMDS-200] with builtin for LogSumExp
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1023:
URL: https://github.com/apache/systemds/pull/1023
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemds] mboehm7 commented on pull request #1023: [SYSTEMDS-2625]: Cleanup GMM [SYSTEMDS-200] with builtin for LogSumExp
Posted by GitBox <gi...@apache.org>.
mboehm7 commented on pull request #1023:
URL: https://github.com/apache/systemds/pull/1023#issuecomment-728301245
LGTM - thanks for the cleanup @Shafaq-Siddiqi. The scenario with 10 components was still failing, but after some debugging it turned out this was due to Kmeans not converging. During the merge I fixed the hard-coded maximum iterations for Kmeans, some formatting issues, and vectorized part of the cholesky computation. With those changes it ran fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org