[jira] [Commented] (NIFI-4156) SplitText processor Fragment.count does not match number of output FlowFiles.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089817#comment-16089817 ] 

ASF GitHub Bot commented on NIFI-4156:
--------------------------------------

GitHub user mattyb149 opened a pull request:

    https://github.com/apache/nifi/pull/2014

    NIFI-4156: Fixed fragment.count in SplitText to equal emitted flow files

    Tried a few different use cases / code paths, to check for correct change in behavior.
    
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mattyb149/nifi NIFI-4156

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2014.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2014
    
----
commit acc6725cd57a0976502e849ba4d12f50811eb8be
Author: Matt Burgess <ma...@apache.org>
Date:   2017-07-17T13:23:55Z

    NIFI-4156: Fixed fragment.count in SplitText to equal emitted flow files

----


> SplitText processor Fragment.count does not match number of output FlowFiles.
> -----------------------------------------------------------------------------
>
>                 Key: NIFI-4156
>                 URL: https://issues.apache.org/jira/browse/NIFI-4156
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 1.1.0
>            Reporter: Matthew Clarke
>            Assignee: Matt Burgess
>            Priority: Minor
>
> SplitText processor configured as follows:
> - line split count = 1
> - Remove trailing Newlines = true
> If the FlowFile being split contains 1 or more blank lines, those blank lines are not turned into split FlowFiles as expected based on above settings.
> However, those blank lines are still counted in the fragment.count attribute. The fragment.count should actually match the number of emitted FlowFiles.
> Fragment count is likely to be used as a method to confirm all FlowFiles have been processed later downstream of splitText. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)