You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@spark.apache.org by "Min Yang (Jira)" <ji...@apache.org> on 2022/04/08 17:50:00 UTC

[jira] [Created] (SPARK-38836) Increase the performance of ExpressionSet

Min Yang created SPARK-38836:
--------------------------------

             Summary: Increase the performance of ExpressionSet
                 Key: SPARK-38836
                 URL: https://issues.apache.org/jira/browse/SPARK-38836
             Project: Spark
          Issue Type: Improvement
          Components: Optimizer
    Affects Versions: 3.2.1
            Reporter: Min Yang


Since the constructor of `ExpressionSet` is protected, callers can only modify the state of an `ExpressionSet` by calling `add` and `remove`, so it maintains the invariants of:
 # Every expr `e` in `baseSet` satisfies `e.deterministic && e.canonicalized == e`
 # Every deterministic expr `e` in `originals` satisfies that `e.canonicalized` is already accessed.

The current implementation ignores the invariant and unnecessarily calls `.canonicalized` in lots of places which can cause performance issues as `canonicalized` is a pretty expensive operation.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org