You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2011/04/29 05:18:03 UTC
[jira] [Commented] (QPID-3233) In some cases the JMS Session does
not get notified of the AMQP session closed, due to an execution exception
received from the broker.
[ https://issues.apache.org/jira/browse/QPID-3233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13026820#comment-13026820 ]
jiraposter@reviews.apache.org commented on QPID-3233:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/676/
-----------------------------------------------------------
Review request for qpid.
Summary
-------
Any execution exception received will now be notified to AMQSession_0_10 via the SessionListener.
Also the AMQSession_0_10 will be marked closed.
The Exception thrown when the session is accessed after it was closed, will now contain information about the underlying AMQ Exception that caused the session closure.
This addresses bug QPID-3233.
https://issues.apache.org/jira/browse/QPID-3233
Diffs
-----
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession.java 1097636
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession_0_10.java 1097636
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQSession_0_8.java 1097636
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/client/src/test/java/org/apache/qpid/test/unit/message/TestAMQSession.java 1097636
http://svn.apache.org/repos/asf/qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/transport/Session.java 1097636
Diff: https://reviews.apache.org/r/676/diff
Testing
-------
Thanks,
rajith
> In some cases the JMS Session does not get notified of the AMQP session closed, due to an execution exception received from the broker.
> ---------------------------------------------------------------------------------------------------------------------------------------
>
> Key: QPID-3233
> URL: https://issues.apache.org/jira/browse/QPID-3233
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: 0.10
> Reporter: Rajith Attapattu
> Assignee: Rajith Attapattu
> Fix For: 0.11
>
>
> If the JMS client receives an execution exception asynchronously it will not notify the JMS Session (AMQSession_0_10.java) object.
> Therefore the JMS Session remains opened while the underlying AMQP session was closed.
> Any subsequent operation that only relies on the check "checkNotClosed()" will not throw an exception.
> Ex. Creating a producer with an already resolved destination or creating messages (ex. session.createTextMessage()).
> The JMS session will only throw an exception if only a call is delegated to the underlying AMQ session class.
> We should also ensure that when the JMS Session gets notified about the underlying session being closed, it should also keep information about the exception that caused it.
> This exception should then be included in the JMS Exception that gets thrown in a subsequent operation due to the JMS Session being closed.
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org