You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "TaiJuWu (via GitHub)" <gi...@apache.org> on 2024/08/24 03:15:23 UTC
[PR] KAFKA-17390:Remove broker-list in GetOffsetShell [kafka]
TaiJuWu opened a new pull request, #16992:
URL: https://github.com/apache/kafka/pull/16992
Jira: https://issues.apache.org/jira/browse/KAFKA-17390
*More detailed description of your change,
Remove broker-list in GetOffsetShell
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17390:Remove broker-list in GetOffsetShell [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #16992:
URL: https://github.com/apache/kafka/pull/16992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17390:Remove broker-list in GetOffsetShell [kafka]
Posted by "TaiJuWu (via GitHub)" <gi...@apache.org>.
TaiJuWu commented on code in PR #16992:
URL: https://github.com/apache/kafka/pull/16992#discussion_r1732725787
##########
tools/src/main/java/org/apache/kafka/tools/GetOffsetShell.java:
##########
@@ -107,12 +107,7 @@ private static class GetOffsetShellOptions extends CommandDefaultOptions {
public GetOffsetShellOptions(String[] args) throws TerseException {
super(args);
- OptionSpec<String> brokerListOpt = parser.accepts("broker-list", "DEPRECATED, use --bootstrap-server instead; ignored if --bootstrap-server is specified. The server(s) to connect to in the form HOST1:PORT1,HOST2:PORT2.")
- .withRequiredArg()
- .describedAs("HOST1:PORT1,...,HOST3:PORT3")
- .ofType(String.class);
OptionSpec<String> bootstrapServerOpt = parser.accepts("bootstrap-server", "REQUIRED. The server(s) to connect to in the form HOST1:PORT1,HOST2:PORT2.")
Review Comment:
@chia7712 Thanks for review, updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-17390:Remove broker-list in GetOffsetShell [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #16992:
URL: https://github.com/apache/kafka/pull/16992#discussion_r1730323750
##########
tools/src/main/java/org/apache/kafka/tools/GetOffsetShell.java:
##########
@@ -107,12 +107,7 @@ private static class GetOffsetShellOptions extends CommandDefaultOptions {
public GetOffsetShellOptions(String[] args) throws TerseException {
super(args);
- OptionSpec<String> brokerListOpt = parser.accepts("broker-list", "DEPRECATED, use --bootstrap-server instead; ignored if --bootstrap-server is specified. The server(s) to connect to in the form HOST1:PORT1,HOST2:PORT2.")
- .withRequiredArg()
- .describedAs("HOST1:PORT1,...,HOST3:PORT3")
- .ofType(String.class);
OptionSpec<String> bootstrapServerOpt = parser.accepts("bootstrap-server", "REQUIRED. The server(s) to connect to in the form HOST1:PORT1,HOST2:PORT2.")
Review Comment:
Please rename `effectiveBrokerListOpt` to `bootstrapServerOpt`. Also, please initialize it in line#110
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org