You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2018/08/25 20:58:37 UTC

[kudu-CR] build-and-test: export EXTRA GRADLE FLAGS

Hello Kudu Jenkins, Adar Dembo, Grant Henke, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/11329

to look at the new patch set (#2).

Change subject: build-and-test: export EXTRA_GRADLE_FLAGS
......................................................................

build-and-test: export EXTRA_GRADLE_FLAGS

build-and-test.sh generates a list of flags with which to configure
gradle. Unless these configurations are `export`ed, they won't be
visible in other processes, e.g. when running dist_test.py.

Notably, this would result in dist_test.py calling gradlew with Scala
formatting (which breaks some builds), even though it was expected to be
disabled.

I didn't test the fix explicitly, but I ran the following to verify the
fix should work:

$ echo "import os
print os.getenv('TEST_VAR', '')" > test.py
$ TEST_VAR=3
$ python test.py

$ export TEST_VAR=5
$ python test.py
5

Change-Id: I84ffdab0d2c78419d0edc65e6c03d79b510676fb
---
M build-support/jenkins/build-and-test.sh
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/11329/2
-- 
To view, visit http://gerrit.cloudera.org:8080/11329
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I84ffdab0d2c78419d0edc65e6c03d79b510676fb
Gerrit-Change-Number: 11329
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins