You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by "vlsi (via GitHub)" <gi...@apache.org> on 2023/05/19 13:58:06 UTC
[GitHub] [jmeter] vlsi opened a new pull request, #5936: doc: update the next version to be 5.6
vlsi opened a new pull request, #5936:
URL: https://github.com/apache/jmeter/pull/5936
I am not sure if the versions should be `5.6` or `5.6.0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] milamberspace commented on a diff in pull request #5936: doc: update the next version to be 5.6
Posted by "milamberspace (via GitHub)" <gi...@apache.org>.
milamberspace commented on code in PR #5936:
URL: https://github.com/apache/jmeter/pull/5936#discussion_r1199569229
##########
xdocs/changes.xml:
##########
@@ -123,21 +123,39 @@ Summary
<li><pr>725</pr>Add Chinese Simplified Translation for Open Model Thread Group</li>
<li><pr>5710</pr>Add GitHub Issue templates</li>
<li><pr>5910</pr>Use Caffeine for caching customizers in TestBeanGUI instead of commons-collections4 LRUMap</li>
- <li><pr>5713</pr>Update Spock to 2.2-groovy-3.0 (from 2.1-groovy-3.0)</li>
+ <li><pr>5713</pr>Update Spock to 2.3-groovy-3.0 (from 2.1-groovy-3.0)</li>
Review Comment:
No need to put all history of changes between 2 official releases, just the old version to the new version at the moment of the new release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] milamberspace commented on a diff in pull request #5936: doc: update the next version to be 5.6
Posted by "milamberspace (via GitHub)" <gi...@apache.org>.
milamberspace commented on code in PR #5936:
URL: https://github.com/apache/jmeter/pull/5936#discussion_r1199569338
##########
xdocs/changes.xml:
##########
@@ -208,12 +208,18 @@ Summary
<p>We thank all contributors mentioned in bug and improvement sections above:
</p>
<ul>
+ <li>Arnout Engelen (raboof at github)</li>
+ <li>Clay Johnson (clayburn at github)</li>
+ <li>David Getzlaff (dgetzlaf at github)</li>
Review Comment:
Why not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] vlsi commented on pull request #5936: doc: update the next version to be 5.6
Posted by "vlsi (via GitHub)" <gi...@apache.org>.
vlsi commented on PR #5936:
URL: https://github.com/apache/jmeter/pull/5936#issuecomment-1554995850
Unfortunately, httpcore5 5.1.3 is not the latest one is 5.2.1.
We should probably add constraints on the transitive dependencies so Renovate would suggest updates
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] vlsi commented on a diff in pull request #5936: doc: update the next version to be 5.6
Posted by "vlsi (via GitHub)" <gi...@apache.org>.
vlsi commented on code in PR #5936:
URL: https://github.com/apache/jmeter/pull/5936#discussion_r1199177186
##########
xdocs/changes.xml:
##########
@@ -123,21 +123,39 @@ Summary
<li><pr>725</pr>Add Chinese Simplified Translation for Open Model Thread Group</li>
<li><pr>5710</pr>Add GitHub Issue templates</li>
<li><pr>5910</pr>Use Caffeine for caching customizers in TestBeanGUI instead of commons-collections4 LRUMap</li>
- <li><pr>5713</pr>Update Spock to 2.2-groovy-3.0 (from 2.1-groovy-3.0)</li>
+ <li><pr>5713</pr>Update Spock to 2.3-groovy-3.0 (from 2.1-groovy-3.0)</li>
Review Comment:
I'm not sure what do we do about changelog entries that update the same dependency several times.
For instance, we have updated spock from 2.1 to 2.2, and then to 2.3 in different PRs (commits).
Do we really want to reflect all those updates individually?
I would probably be time-consuming, and it would be unreadable at the same time.
Any thoughts on that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] vlsi commented on a diff in pull request #5936: doc: update the next version to be 5.6
Posted by "vlsi (via GitHub)" <gi...@apache.org>.
vlsi commented on code in PR #5936:
URL: https://github.com/apache/jmeter/pull/5936#discussion_r1199157686
##########
xdocs/changes.xml:
##########
@@ -208,12 +208,18 @@ Summary
<p>We thank all contributors mentioned in bug and improvement sections above:
</p>
<ul>
+ <li>Arnout Engelen (raboof at github)</li>
+ <li>Clay Johnson (clayburn at github)</li>
+ <li>David Getzlaff (dgetzlaf at github)</li>
Review Comment:
I wonder if we would like to use real links to GitHub profiles instead of `... at github`.
Any thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] vlsi merged pull request #5936: doc: update the next version to be 5.6
Posted by "vlsi (via GitHub)" <gi...@apache.org>.
vlsi merged PR #5936:
URL: https://github.com/apache/jmeter/pull/5936
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org