You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/03/25 16:05:18 UTC
[GitHub] [skywalking] CalvinKirs opened a new pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
CalvinKirs opened a new pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👇 ====
### Add an agent plugin to support <framework name>
- [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking/blob/master/docs/en/guides/Plugin-test.md)
- [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/92c0cb856d4df5ded4708d285c4e0ecce97dfd7a?el=desc) (92c0cb8) will **increase** coverage by `1.72%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
+ Coverage 49.25% 50.98% +1.72%
- Complexity 3594 3787 +193
============================================
Files 999 1037 +38
Lines 24877 25660 +783
Branches 2423 2512 +89
============================================
+ Hits 12253 13082 +829
+ Misses 11583 11451 -132
- Partials 1041 1127 +86
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | `3.00 <0.00> (ø)` | |
| [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | `33.33% <0.00%> (-26.67%)` | `3.00% <0.00%> (ø%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `87.96% <0.00%> (-6.49%)` | `26.00% <0.00%> (-3.00%)` | |
| [...e/skywalking/apm/agent/core/meter/MeterSender.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZW5kZXIuamF2YQ==) | `23.63% <0.00%> (-4.03%)` | `7.00% <0.00%> (ø%)` | |
| [...age/plugin/elasticsearch/base/IndexController.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9JbmRleENvbnRyb2xsZXIuamF2YQ==) | `88.88% <0.00%> (ø)` | `9.00% <0.00%> (ø%)` | |
| [...pache/skywalking/apm/agent/core/meter/Counter.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...king/apm/agent/core/context/util/KeyValuePair.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL0tleVZhbHVlUGFpci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...ent/core/context/status/ExceptionCheckContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvRXhjZXB0aW9uQ2hlY2tDb250ZXh0LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [98 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `23.34%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 35.55% -23.35%
+ Complexity 4185 2480 -1705
=============================================
Files 997 979 -18
Lines 24973 24048 -925
Branches 2436 2337 -99
=============================================
- Hits 14710 8550 -6160
- Misses 8976 14838 +5862
+ Partials 1287 660 -627
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [411 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `9.99%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 48.90% -10.00%
+ Complexity 4185 3647 -538
=============================================
Files 997 1020 +23
Lines 24973 25260 +287
Branches 2436 2459 +23
=============================================
- Hits 14710 12354 -2356
- Misses 8976 11843 +2867
+ Partials 1287 1063 -224
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | `3.00 <0.00> (ø)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [196 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `20.25%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 38.64% -20.26%
+ Complexity 4185 2782 -1403
=============================================
Files 997 1017 +20
Lines 24973 25125 +152
Branches 2436 2446 +10
=============================================
- Hits 14710 9710 -5000
- Misses 8976 14670 +5694
+ Partials 1287 745 -542
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [359 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `10.24%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 48.65% -10.25%
+ Complexity 4185 3634 -551
=============================================
Files 997 1020 +23
Lines 24973 25260 +287
Branches 2436 2459 +23
=============================================
- Hits 14710 12290 -2420
- Misses 8976 11913 +2937
+ Partials 1287 1057 -230
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | `3.00 <0.00> (ø)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [200 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `23.30%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 35.60% -23.31%
+ Complexity 4185 2480 -1705
=============================================
Files 997 976 -21
Lines 24973 24016 -957
Branches 2436 2335 -101
=============================================
- Hits 14710 8550 -6160
- Misses 8976 14806 +5830
+ Partials 1287 660 -627
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [408 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (9d4932f) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `28.02%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 9d4932f differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 30.87% -28.03%
+ Complexity 4185 1896 -2289
=============================================
Files 997 812 -185
Lines 24973 19861 -5112
Branches 2436 1848 -588
=============================================
- Hits 14710 6132 -8578
- Misses 8976 13294 +4318
+ Partials 1287 435 -852
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `18.01% <0.00%> (-64.56%)` | `4.00 <0.00> (-20.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `9.17% <0.00%> (-54.22%)` | `9.00 <0.00> (-54.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [534 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `58.90%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
- Coverage 58.90% 0.00% -58.91%
============================================
Files 997 174 -823
Lines 24973 4316 -20657
Branches 2436 484 -1952
============================================
- Hits 14710 0 -14710
+ Misses 8976 4316 -4660
+ Partials 1287 0 -1287
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [976 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `21.71%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 37.18% -21.72%
+ Complexity 4185 2692 -1493
=============================================
Files 997 1016 +19
Lines 24973 25085 +112
Branches 2436 2442 +6
=============================================
- Hits 14710 9328 -5382
- Misses 8976 15036 +6060
+ Partials 1287 721 -566
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [378 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (b6d6ce0) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `58.90%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
- Coverage 58.90% 0.00% -58.91%
============================================
Files 997 173 -824
Lines 24973 4312 -20661
Branches 2436 484 -1952
============================================
- Hits 14710 0 -14710
+ Misses 8976 4312 -4664
+ Partials 1287 0 -1287
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [976 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (9d4932f) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `31.43%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 9d4932f differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 27.46% -31.44%
+ Complexity 4185 1717 -2468
=============================================
Files 997 812 -185
Lines 24973 19852 -5121
Branches 2436 1848 -588
=============================================
- Hits 14710 5453 -9257
- Misses 8976 14002 +5026
+ Partials 1287 397 -890
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `18.01% <0.00%> (-64.56%)` | `4.00 <0.00> (-20.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `9.17% <0.00%> (-54.22%)` | `9.00 <0.00> (-54.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [556 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/92c0cb856d4df5ded4708d285c4e0ecce97dfd7a?el=desc) (92c0cb8) will **increase** coverage by `0.07%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
+ Coverage 52.90% 52.98% +0.07%
+ Complexity 4070 3892 -178
============================================
Files 1796 1037 -759
Lines 38497 25660 -12837
Branches 4236 2512 -1724
============================================
- Hits 20367 13596 -6771
+ Misses 17139 10888 -6251
- Partials 991 1176 +185
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+4.18%)` | `3.00 <0.00> (ø)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [1288 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (b6d6ce0) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `32.94%`.
> The diff coverage is `3.29%`.
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 25.96% -32.95%
+ Complexity 4185 1916 -2269
=============================================
Files 997 971 -26
Lines 24973 23886 -1087
Branches 2436 2328 -108
=============================================
- Hits 14710 6201 -8509
- Misses 8976 17210 +8234
+ Partials 1287 475 -812
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [531 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (b6d6ce0) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `17.70%`.
> The diff coverage is `3.29%`.
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 41.20% -17.71%
+ Complexity 4185 3044 -1141
=============================================
Files 997 974 -23
Lines 24973 24065 -908
Branches 2436 2353 -83
=============================================
- Hits 14710 9915 -4795
- Misses 8976 13300 +4324
+ Partials 1287 850 -437
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | `3.00 <0.00> (ø)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [301 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `9.78%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
- Coverage 58.90% 49.12% -9.79%
+ Complexity 4185 3659 -526
============================================
Files 997 1020 +23
Lines 24973 25260 +287
Branches 2436 2459 +23
============================================
- Hits 14710 12408 -2302
- Misses 8976 11787 +2811
+ Partials 1287 1065 -222
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | `3.00 <0.00> (ø)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [190 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] muse-dev[bot] commented on a change in pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
muse-dev[bot] commented on a change in pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#discussion_r601670465
##########
File path: apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/context/ids/GlobalIdGenerator.java
##########
@@ -74,11 +74,8 @@ private long timestamp() {
if (currentTimeMillis < lastTimestamp) {
// Just for considering time-shift-back by Ops or OS. @hanahmily 's suggestion.
- if (random == null) {
- random = new Random();
- }
if (runRandomTimestamp != currentTimeMillis) {
- lastRandomValue = random.nextInt();
+ lastRandomValue = ThreadLocalRandom.current().nextInt();
Review comment:
*PREDICTABLE_RANDOM:* This random generator (java.util.concurrent.ThreadLocalRandom) is predictable [(details)](https://find-sec-bugs.github.io/bugs.htm#PREDICTABLE_RANDOM)
(at-me [in a reply](https://docs.muse.dev/docs/talk-to-muse/) with `help` or `ignore`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/92c0cb856d4df5ded4708d285c4e0ecce97dfd7a?el=desc) (92c0cb8) will **increase** coverage by `2.10%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
+ Coverage 49.25% 51.35% +2.10%
- Complexity 3594 3804 +210
============================================
Files 999 1037 +38
Lines 24877 25660 +783
Branches 2423 2512 +89
============================================
+ Hits 12253 13178 +925
+ Misses 11583 11332 -251
- Partials 1041 1150 +109
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | `3.00 <0.00> (ø)` | |
| [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | `33.33% <0.00%> (-26.67%)` | `3.00% <0.00%> (ø%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `87.96% <0.00%> (-6.49%)` | `26.00% <0.00%> (-3.00%)` | |
| [...e/skywalking/apm/agent/core/meter/MeterSender.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZW5kZXIuamF2YQ==) | `23.63% <0.00%> (-4.03%)` | `7.00% <0.00%> (ø%)` | |
| [...age/plugin/elasticsearch/base/IndexController.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9JbmRleENvbnRyb2xsZXIuamF2YQ==) | `88.88% <0.00%> (ø)` | `9.00% <0.00%> (ø%)` | |
| [...che/skywalking/apm/agent/core/meter/BaseMeter.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQmFzZU1ldGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [.../skywalking/amp/testcase/undertow/Application.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL3VuZGVydG93LXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FtcC90ZXN0Y2FzZS91bmRlcnRvdy9BcHBsaWNhdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [101 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (b6d6ce0) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `58.90%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
- Coverage 58.90% 0.00% -58.91%
============================================
Files 997 174 -823
Lines 24973 4316 -20657
Branches 2436 484 -1952
============================================
- Hits 14710 0 -14710
+ Misses 8976 4316 -4660
+ Partials 1287 0 -1287
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [976 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (9d4932f) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `28.23%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 9d4932f differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 30.66% -28.24%
+ Complexity 4185 1965 -2220
=============================================
Files 997 843 -154
Lines 24973 20764 -4209
Branches 2436 1936 -500
=============================================
- Hits 14710 6368 -8342
- Misses 8976 13946 +4970
+ Partials 1287 450 -837
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `18.01% <0.00%> (-64.56%)` | `4.00 <0.00> (-20.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `9.17% <0.00%> (-54.22%)` | `9.00 <0.00> (-54.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [507 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/92c0cb856d4df5ded4708d285c4e0ecce97dfd7a?el=desc) (92c0cb8) will **increase** coverage by `1.26%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
+ Coverage 50.09% 51.35% +1.26%
- Complexity 3643 3804 +161
============================================
Files 999 1037 +38
Lines 24899 25660 +761
Branches 2424 2512 +88
============================================
+ Hits 12473 13178 +705
+ Misses 11354 11332 -22
- Partials 1072 1150 +78
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | `3.00 <0.00> (ø)` | |
| [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | `33.33% <0.00%> (-26.67%)` | `3.00% <0.00%> (ø%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `87.96% <0.00%> (-6.49%)` | `26.00% <0.00%> (-3.00%)` | |
| [...e/skywalking/apm/agent/core/meter/MeterSender.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZW5kZXIuamF2YQ==) | `23.63% <0.00%> (-4.03%)` | `7.00% <0.00%> (ø%)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `72.07% <0.00%> (-0.91%)` | `22.00% <0.00%> (-1.00%)` | |
| [...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...che/skywalking/apm/agent/core/meter/Histogram.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvSGlzdG9ncmFtLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...apache/skywalking/apm/agent/core/util/IOUtils.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9JT1V0aWxzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [87 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `23.47%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 35.42% -23.48%
+ Complexity 4185 2480 -1705
=============================================
Files 997 985 -12
Lines 24973 24133 -840
Branches 2436 2347 -89
=============================================
- Hits 14710 8550 -6160
- Misses 8976 14923 +5947
+ Partials 1287 660 -627
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [417 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `23.29%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 35.60% -23.30%
+ Complexity 4185 2480 -1705
=============================================
Files 997 975 -22
Lines 24973 24011 -962
Branches 2436 2335 -101
=============================================
- Hits 14710 8550 -6160
- Misses 8976 14801 +5825
+ Partials 1287 660 -627
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [407 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (9d4932f) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `26.03%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 9d4932f differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 32.86% -26.04%
+ Complexity 4185 2090 -2095
=============================================
Files 997 843 -154
Lines 24973 20764 -4209
Branches 2436 1936 -500
=============================================
- Hits 14710 6825 -7885
- Misses 8976 13436 +4460
+ Partials 1287 503 -784
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `18.01% <0.00%> (-64.56%)` | `4.00 <0.00> (-20.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `9.17% <0.00%> (-54.22%)` | `9.00 <0.00> (-54.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [491 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `20.34%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 38.55% -20.35%
+ Complexity 4185 2782 -1403
=============================================
Files 997 1019 +22
Lines 24973 25184 +211
Branches 2436 2453 +17
=============================================
- Hits 14710 9710 -5000
- Misses 8976 14729 +5753
+ Partials 1287 745 -542
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [361 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/6186a7970f64e8415d63c205f54676da36ed32db?el=desc) (6186a79) will **increase** coverage by `5.31%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
+ Coverage 44.34% 49.66% +5.31%
- Complexity 2576 3714 +1138
============================================
Files 811 1037 +226
Lines 20117 25638 +5521
Branches 1924 2511 +587
============================================
+ Hits 8921 12733 +3812
- Misses 10511 11816 +1305
- Partials 685 1089 +404
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (+0.54%)` | `22.00 <0.00> (+1.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-1.63%)` | `55.00 <0.00> (ø)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../parser/listener/DatabaseSlowStatementBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9hZ2VudC1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2FuYWx5emVyL3Byb3ZpZGVyL3RyYWNlL3BhcnNlci9saXN0ZW5lci9EYXRhYmFzZVNsb3dTdGF0ZW1lbnRCdWlsZGVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| ... and [350 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/92c0cb856d4df5ded4708d285c4e0ecce97dfd7a?el=desc) (92c0cb8) will **increase** coverage by `0.69%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
+ Coverage 54.18% 54.88% +0.69%
+ Complexity 4194 4044 -150
============================================
Files 1796 1037 -759
Lines 38497 25681 -12816
Branches 4237 2513 -1724
============================================
- Hits 20861 14095 -6766
+ Misses 16648 10359 -6289
- Partials 988 1227 +239
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+4.18%)` | `3.00 <0.00> (ø)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1258 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (b6d6ce0) into [master](https://codecov.io/gh/apache/skywalking/commit/92c0cb856d4df5ded4708d285c4e0ecce97dfd7a?el=desc) (92c0cb8) will **decrease** coverage by `7.24%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
- Coverage 51.14% 43.90% -7.25%
+ Complexity 3872 3203 -669
============================================
Files 1796 978 -818
Lines 38497 24244 -14253
Branches 4236 2369 -1867
============================================
- Hits 19691 10645 -9046
+ Misses 17813 12705 -5108
+ Partials 993 894 -99
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+4.18%)` | `3.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1312 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 merged pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
kezhenxu94 merged pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `23.47%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 35.42% -23.48%
+ Complexity 4185 2480 -1705
=============================================
Files 997 985 -12
Lines 24973 24133 -840
Branches 2436 2347 -89
=============================================
- Hits 14710 8550 -6160
- Misses 8976 14923 +5947
+ Partials 1287 660 -627
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [417 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `10.76%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 48.14% -10.77%
+ Complexity 4185 3595 -590
=============================================
Files 997 1020 +23
Lines 24973 25260 +287
Branches 2436 2459 +23
=============================================
- Hits 14710 12161 -2549
- Misses 8976 12063 +3087
+ Partials 1287 1036 -251
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | `3.00 <0.00> (ø)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [219 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/92c0cb856d4df5ded4708d285c4e0ecce97dfd7a?el=desc) (92c0cb8) will **increase** coverage by `1.86%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
+ Coverage 52.95% 54.81% +1.86%
+ Complexity 4079 4034 -45
============================================
Files 1796 1037 -759
Lines 38497 25665 -12832
Branches 4236 2512 -1724
============================================
- Hits 20385 14068 -6317
+ Misses 17122 10368 -6754
- Partials 990 1229 +239
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+4.18%)` | `3.00 <0.00> (ø)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1268 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `9.62%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
- Coverage 58.90% 49.27% -9.63%
+ Complexity 4185 3665 -520
============================================
Files 997 1020 +23
Lines 24973 25260 +287
Branches 2436 2459 +23
============================================
- Hits 14710 12448 -2262
- Misses 8976 11738 +2762
+ Partials 1287 1074 -213
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | `3.00 <0.00> (ø)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [189 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `9.95%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
- Coverage 58.90% 48.94% -9.96%
+ Complexity 4185 3653 -532
============================================
Files 997 1020 +23
Lines 24973 25260 +287
Branches 2436 2459 +23
============================================
- Hits 14710 12364 -2346
- Misses 8976 11833 +2857
+ Partials 1287 1063 -224
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | `3.00 <0.00> (ø)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [191 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/92c0cb856d4df5ded4708d285c4e0ecce97dfd7a?el=desc) (92c0cb8) will **increase** coverage by `3.88%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
+ Coverage 46.51% 50.40% +3.88%
- Complexity 3459 3747 +288
============================================
Files 999 1037 +38
Lines 24877 25638 +761
Branches 2423 2511 +88
============================================
+ Hits 11572 12923 +1351
+ Misses 12323 11616 -707
- Partials 982 1099 +117
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | `3.00 <0.00> (ø)` | |
| [...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [.../plugin/elasticsearch7/query/TraceQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9UcmFjZVF1ZXJ5RXM3REFPLmphdmE=) | `3.57% <0.00%> (-42.86%)` | `1.00% <0.00%> (-2.00%)` | |
| [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | `33.33% <0.00%> (-26.67%)` | `3.00% <0.00%> (ø%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...e/skywalking/apm/agent/core/meter/MeterSender.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZW5kZXIuamF2YQ==) | `23.63% <0.00%> (-4.03%)` | `7.00% <0.00%> (ø%)` | |
| [...in/elasticsearch7/client/ElasticSearch7Client.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdDbGllbnQuamF2YQ==) | `51.59% <0.00%> (-1.07%)` | `18.00% <0.00%> (-1.00%)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-0.91%)` | `22.00% <0.00%> (-1.00%)` | |
| [...age/plugin/elasticsearch/base/IndexController.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9JbmRleENvbnRyb2xsZXIuamF2YQ==) | `88.88% <0.00%> (ø)` | `9.00% <0.00%> (ø%)` | |
| [...ache/skywalking/apm/agent/core/meter/MeterTag.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUYWcuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [128 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/92c0cb856d4df5ded4708d285c4e0ecce97dfd7a?el=desc) (92c0cb8) will **decrease** coverage by `0.40%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
- Coverage 52.90% 52.50% -0.41%
+ Complexity 4070 3854 -216
============================================
Files 1796 1037 -759
Lines 38497 25660 -12837
Branches 4236 2512 -1724
============================================
- Hits 20367 13472 -6895
+ Misses 17139 11022 -6117
- Partials 991 1166 +175
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+4.18%)` | `3.00 <0.00> (ø)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [1293 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (9d4932f) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `28.77%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 9d4932f differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 30.12% -28.78%
+ Complexity 4185 1854 -2331
=============================================
Files 997 812 -185
Lines 24973 19861 -5112
Branches 2436 1848 -588
=============================================
- Hits 14710 5983 -8727
- Misses 8976 13447 +4471
+ Partials 1287 431 -856
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `18.01% <0.00%> (-64.56%)` | `4.00 <0.00> (-20.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `9.17% <0.00%> (-54.22%)` | `9.00 <0.00> (-54.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/source/RequestType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL1JlcXVlc3RUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [543 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `27.23%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 31.66% -27.24%
+ Complexity 4185 2256 -1929
=============================================
Files 997 975 -22
Lines 24973 23992 -981
Branches 2436 2335 -101
=============================================
- Hits 14710 7598 -7112
- Misses 8976 15820 +6844
+ Partials 1287 574 -713
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [443 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/6186a7970f64e8415d63c205f54676da36ed32db?el=desc) (6186a79) will **increase** coverage by `13.74%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
+ Coverage 36.60% 50.34% +13.74%
- Complexity 2186 3714 +1528
=============================================
Files 811 1020 +209
Lines 20063 25291 +5228
Branches 1913 2461 +548
=============================================
+ Hits 7344 12733 +5389
+ Misses 12166 11469 -697
- Partials 553 1089 +536
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (ø)` | `3.00 <0.00> (?)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (+0.54%)` | `22.00 <0.00> (+1.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-1.24%)` | `55.00 <0.00> (ø)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...lugin/elasticsearch7/query/MetricsQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9NZXRyaWNzUXVlcnlFczdEQU8uamF2YQ==) | `6.25% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| ... and [366 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/92c0cb856d4df5ded4708d285c4e0ecce97dfd7a?el=desc) (92c0cb8) will **increase** coverage by `0.78%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
+ Coverage 54.18% 54.97% +0.78%
+ Complexity 4194 4047 -147
============================================
Files 1796 1037 -759
Lines 38497 25681 -12816
Branches 4237 2513 -1724
============================================
- Hits 20861 14119 -6742
+ Misses 16648 10328 -6320
- Partials 988 1234 +246
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+4.18%)` | `3.00 <0.00> (ø)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1258 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `20.40%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 38.49% -20.41%
+ Complexity 4185 2782 -1403
=============================================
Files 997 1020 +23
Lines 24973 25223 +250
Branches 2436 2454 +18
=============================================
- Hits 14710 9710 -5000
- Misses 8976 14768 +5792
+ Partials 1287 745 -542
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [362 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `20.19%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 38.70% -20.20%
+ Complexity 4185 2782 -1403
=============================================
Files 997 1016 +19
Lines 24973 25085 +112
Branches 2436 2442 +6
=============================================
- Hits 14710 9710 -5000
- Misses 8976 14630 +5654
+ Partials 1287 745 -542
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [358 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/92c0cb856d4df5ded4708d285c4e0ecce97dfd7a?el=desc) (92c0cb8) will **increase** coverage by `10.46%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
+ Coverage 39.93% 50.40% +10.46%
- Complexity 2930 3747 +817
=============================================
Files 968 1037 +69
Lines 23834 25638 +1804
Branches 2322 2511 +189
=============================================
+ Hits 9519 12923 +3404
+ Misses 13494 11616 -1878
- Partials 821 1099 +278
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | `3.00 <0.00> (ø)` | |
| [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | `33.33% <0.00%> (-26.67%)` | `3.00% <0.00%> (ø%)` | |
| [.../log/provider/handler/LogReportServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbG9nLXJlY2V2aWVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2V2aWVyL2xvZy9wcm92aWRlci9oYW5kbGVyL0xvZ1JlcG9ydFNlcnZpY2VIYW5kbGVyLmphdmE=) | `71.42% <0.00%> (-20.88%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...r/receiver/event/grpc/EventGrpcServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctZXZlbnQtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZXZlbnQvZ3JwYy9FdmVudEdycGNTZXJ2aWNlSGFuZGxlci5qYXZh) | `80.00% <0.00%> (-11.67%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...e/skywalking/apm/agent/core/meter/MeterSender.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZW5kZXIuamF2YQ==) | `23.63% <0.00%> (-4.03%)` | `7.00% <0.00%> (ø%)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `100.00% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
| [.../agent/core/context/util/ThrowableTransformer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1Rocm93YWJsZVRyYW5zZm9ybWVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...orage/plugin/elasticsearch7/dao/MetricsEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9kYW8vTWV0cmljc0VzN0RBTy5qYXZh) | `100.00% <0.00%> (ø)` | `1.00% <0.00%> (?%)` | |
| [...ache/skywalking/apm/toolkit/meter/BaseBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvQmFzZUJ1aWxkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [243 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `20.04%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 38.85% -20.05%
+ Complexity 4185 2812 -1373
=============================================
Files 997 1020 +23
Lines 24973 25251 +278
Branches 2436 2459 +23
=============================================
- Hits 14710 9811 -4899
- Misses 8976 14689 +5713
+ Partials 1287 751 -536
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [356 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `23.30%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 35.59% -23.31%
+ Complexity 4185 2480 -1705
=============================================
Files 997 977 -20
Lines 24973 24020 -953
Branches 2436 2335 -101
=============================================
- Hits 14710 8550 -6160
- Misses 8976 14810 +5834
+ Partials 1287 660 -627
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [409 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (b6d6ce0) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `58.90%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
- Coverage 58.90% 0.00% -58.91%
============================================
Files 997 176 -821
Lines 24973 4328 -20645
Branches 2436 484 -1952
============================================
- Hits 14710 0 -14710
+ Misses 8976 4328 -4648
+ Partials 1287 0 -1287
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [976 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `20.89%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 38.00% -20.90%
+ Complexity 4185 2735 -1450
=============================================
Files 997 1016 +19
Lines 24973 25085 +112
Branches 2436 2442 +6
=============================================
- Hits 14710 9534 -5176
- Misses 8976 14811 +5835
+ Partials 1287 740 -547
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [370 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/92c0cb856d4df5ded4708d285c4e0ecce97dfd7a?el=desc) (92c0cb8) will **increase** coverage by `1.58%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
+ Coverage 48.96% 50.55% +1.58%
- Complexity 3582 3756 +174
============================================
Files 999 1037 +38
Lines 24877 25638 +761
Branches 2423 2511 +88
============================================
+ Hits 12182 12961 +779
+ Misses 11670 11569 -101
- Partials 1025 1108 +83
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | `3.00 <0.00> (ø)` | |
| [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | `33.33% <0.00%> (-26.67%)` | `3.00% <0.00%> (ø%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...e/skywalking/apm/agent/core/meter/MeterSender.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZW5kZXIuamF2YQ==) | `23.63% <0.00%> (-4.03%)` | `7.00% <0.00%> (ø%)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-0.91%)` | `22.00% <0.00%> (-1.00%)` | |
| [...age/plugin/elasticsearch/base/IndexController.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9JbmRleENvbnRyb2xsZXIuamF2YQ==) | `88.88% <0.00%> (ø)` | `9.00% <0.00%> (ø%)` | |
| [...pache/skywalking/apm/agent/core/meter/Counter.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...ache/skywalking/apm/agent/core/meter/MeterTag.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUYWcuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...apm/agent/core/context/RuntimeContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9SdW50aW1lQ29udGV4dFNuYXBzaG90LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...apache/skywalking/apm/agent/core/util/IOUtils.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9JT1V0aWxzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [90 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (b6d6ce0) into [master](https://codecov.io/gh/apache/skywalking/commit/92c0cb856d4df5ded4708d285c4e0ecce97dfd7a?el=desc) (92c0cb8) will **decrease** coverage by `7.19%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
- Coverage 51.20% 44.01% -7.20%
+ Complexity 3878 3213 -665
============================================
Files 1796 978 -818
Lines 38497 24244 -14253
Branches 4236 2369 -1867
============================================
- Hits 19713 10670 -9043
+ Misses 17791 12681 -5110
+ Partials 993 893 -100
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+4.18%)` | `3.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...king/oap/server/configuration/api/ConfigTable.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwaS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBpL0NvbmZpZ1RhYmxlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/receiver/envoy/als/Role.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL1JvbGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1312 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (b6d6ce0) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `58.90%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
- Coverage 58.90% 0.00% -58.91%
============================================
Files 997 174 -823
Lines 24973 4316 -20657
Branches 2436 484 -1952
============================================
- Hits 14710 0 -14710
+ Misses 8976 4316 -4660
+ Partials 1287 0 -1287
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [976 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `23.47%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 35.42% -23.48%
+ Complexity 4185 2480 -1705
=============================================
Files 997 985 -12
Lines 24973 24133 -840
Branches 2436 2347 -89
=============================================
- Hits 14710 8550 -6160
- Misses 8976 14923 +5947
+ Partials 1287 660 -627
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [417 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/92c0cb856d4df5ded4708d285c4e0ecce97dfd7a?el=desc) (92c0cb8) will **increase** coverage by `1.29%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
+ Coverage 49.25% 50.55% +1.29%
- Complexity 3594 3756 +162
============================================
Files 999 1037 +38
Lines 24877 25638 +761
Branches 2423 2511 +88
============================================
+ Hits 12253 12961 +708
+ Misses 11583 11569 -14
- Partials 1041 1108 +67
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | `3.00 <0.00> (ø)` | |
| [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | `33.33% <0.00%> (-26.67%)` | `3.00% <0.00%> (ø%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `87.96% <0.00%> (-6.49%)` | `26.00% <0.00%> (-3.00%)` | |
| [...e/skywalking/apm/agent/core/meter/MeterSender.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZW5kZXIuamF2YQ==) | `23.63% <0.00%> (-4.03%)` | `7.00% <0.00%> (ø%)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-0.91%)` | `22.00% <0.00%> (-1.00%)` | |
| [...age/plugin/elasticsearch/base/IndexController.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9JbmRleENvbnRyb2xsZXIuamF2YQ==) | `88.88% <0.00%> (ø)` | `9.00% <0.00%> (ø%)` | |
| [...pache/skywalking/apm/agent/core/meter/Counter.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...king/apm/agent/core/context/util/KeyValuePair.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL0tleVZhbHVlUGFpci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [88 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (b6d6ce0) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `17.93%`.
> The diff coverage is `3.29%`.
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 40.96% -17.94%
+ Complexity 4185 3032 -1153
=============================================
Files 997 974 -23
Lines 24973 24065 -908
Branches 2436 2353 -83
=============================================
- Hits 14710 9859 -4851
- Misses 8976 13362 +4386
+ Partials 1287 844 -443
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | `3.00 <0.00> (ø)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [306 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/92c0cb856d4df5ded4708d285c4e0ecce97dfd7a?el=desc) (92c0cb8) will **increase** coverage by `2.10%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
+ Coverage 49.25% 51.35% +2.10%
- Complexity 3594 3804 +210
============================================
Files 999 1037 +38
Lines 24877 25660 +783
Branches 2423 2512 +89
============================================
+ Hits 12253 13178 +925
+ Misses 11583 11332 -251
- Partials 1041 1150 +109
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | `3.00 <0.00> (ø)` | |
| [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | `33.33% <0.00%> (-26.67%)` | `3.00% <0.00%> (ø%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `87.96% <0.00%> (-6.49%)` | `26.00% <0.00%> (-3.00%)` | |
| [...e/skywalking/apm/agent/core/meter/MeterSender.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZW5kZXIuamF2YQ==) | `23.63% <0.00%> (-4.03%)` | `7.00% <0.00%> (ø%)` | |
| [...age/plugin/elasticsearch/base/IndexController.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9JbmRleENvbnRyb2xsZXIuamF2YQ==) | `88.88% <0.00%> (ø)` | `9.00% <0.00%> (ø%)` | |
| [...pache/skywalking/apm/agent/core/meter/MeterId.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJJZC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...g/apache/skywalking/apm/toolkit/meter/Counter.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvQ291bnRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...pache/skywalking/apm/agent/core/meter/Counter.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [101 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/92c0cb856d4df5ded4708d285c4e0ecce97dfd7a?el=desc) (92c0cb8) will **increase** coverage by `2.10%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
+ Coverage 49.25% 51.35% +2.10%
- Complexity 3594 3804 +210
============================================
Files 999 1037 +38
Lines 24877 25660 +783
Branches 2423 2512 +89
============================================
+ Hits 12253 13178 +925
+ Misses 11583 11332 -251
- Partials 1041 1150 +109
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | `3.00 <0.00> (ø)` | |
| [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | `33.33% <0.00%> (-26.67%)` | `3.00% <0.00%> (ø%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `87.96% <0.00%> (-6.49%)` | `26.00% <0.00%> (-3.00%)` | |
| [...e/skywalking/apm/agent/core/meter/MeterSender.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZW5kZXIuamF2YQ==) | `23.63% <0.00%> (-4.03%)` | `7.00% <0.00%> (ø%)` | |
| [...age/plugin/elasticsearch/base/IndexController.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9JbmRleENvbnRyb2xsZXIuamF2YQ==) | `88.88% <0.00%> (ø)` | `9.00% <0.00%> (ø%)` | |
| [...pache/skywalking/apm/agent/core/meter/MeterId.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJJZC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...g/apache/skywalking/apm/toolkit/meter/Counter.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvQ291bnRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...pache/skywalking/apm/agent/core/meter/Counter.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [101 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/92c0cb856d4df5ded4708d285c4e0ecce97dfd7a?el=desc) (92c0cb8) will **increase** coverage by `2.10%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
+ Coverage 49.25% 51.35% +2.10%
- Complexity 3594 3804 +210
============================================
Files 999 1037 +38
Lines 24877 25660 +783
Branches 2423 2512 +89
============================================
+ Hits 12253 13178 +925
+ Misses 11583 11332 -251
- Partials 1041 1150 +109
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | `3.00 <0.00> (ø)` | |
| [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | `33.33% <0.00%> (-26.67%)` | `3.00% <0.00%> (ø%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `87.96% <0.00%> (-6.49%)` | `26.00% <0.00%> (-3.00%)` | |
| [...e/skywalking/apm/agent/core/meter/MeterSender.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZW5kZXIuamF2YQ==) | `23.63% <0.00%> (-4.03%)` | `7.00% <0.00%> (ø%)` | |
| [...age/plugin/elasticsearch/base/IndexController.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9JbmRleENvbnRyb2xsZXIuamF2YQ==) | `88.88% <0.00%> (ø)` | `9.00% <0.00%> (ø%)` | |
| [.../agent/core/context/util/ThrowableTransformer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1Rocm93YWJsZVRyYW5zZm9ybWVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...ache/skywalking/apm/toolkit/meter/BaseBuilder.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvQmFzZUJ1aWxkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...g/apache/skywalking/apm/toolkit/meter/MeterId.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvTWV0ZXJJZC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [101 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `23.30%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 35.59% -23.31%
+ Complexity 4185 2480 -1705
=============================================
Files 997 977 -20
Lines 24973 24020 -953
Branches 2436 2335 -101
=============================================
- Hits 14710 8550 -6160
- Misses 8976 14810 +5834
+ Partials 1287 660 -627
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [409 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `23.34%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 35.55% -23.35%
+ Complexity 4185 2480 -1705
=============================================
Files 997 979 -18
Lines 24973 24048 -925
Branches 2436 2337 -99
=============================================
- Hits 14710 8550 -6160
- Misses 8976 14838 +5862
+ Partials 1287 660 -627
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [411 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (b6d6ce0) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `15.02%`.
> The diff coverage is `3.29%`.
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 43.87% -15.03%
+ Complexity 4185 3192 -993
=============================================
Files 997 974 -23
Lines 24973 24179 -794
Branches 2436 2361 -75
=============================================
- Hits 14710 10609 -4101
- Misses 8976 12681 +3705
+ Partials 1287 889 -398
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | `3.00 <0.00> (ø)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `79.27% <0.00%> (-3.29%)` | `23.00 <0.00> (-1.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `60.00% <0.00%> (-3.39%)` | `62.00 <0.00> (-1.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [254 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `10.36%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 48.53% -10.37%
+ Complexity 4185 3631 -554
=============================================
Files 997 1020 +23
Lines 24973 25260 +287
Branches 2436 2459 +23
=============================================
- Hits 14710 12261 -2449
- Misses 8976 11951 +2975
+ Partials 1287 1048 -239
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | `3.00 <0.00> (ø)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| [...core/browser/source/BrowserAppTrafficCategory.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFRyYWZmaWNDYXRlZ29yeS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [201 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/92c0cb856d4df5ded4708d285c4e0ecce97dfd7a?el=desc) (92c0cb8) will **increase** coverage by `0.85%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
+ Coverage 54.18% 55.04% +0.85%
+ Complexity 4194 4049 -145
============================================
Files 1796 1037 -759
Lines 38497 25681 -12816
Branches 4237 2513 -1724
============================================
- Hits 20861 14135 -6726
+ Misses 16648 10305 -6343
- Partials 988 1241 +253
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+4.18%)` | `3.00 <0.00> (ø)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1258 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/92c0cb856d4df5ded4708d285c4e0ecce97dfd7a?el=desc) (92c0cb8) will **decrease** coverage by `0.80%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
- Coverage 52.76% 51.96% -0.81%
+ Complexity 4061 3830 -231
============================================
Files 1796 1037 -759
Lines 38497 25660 -12837
Branches 4236 2512 -1724
============================================
- Hits 20314 13333 -6981
+ Misses 17192 11172 -6020
- Partials 991 1155 +164
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+4.18%)` | `3.00 <0.00> (ø)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...rver/core/browser/source/BrowserErrorCategory.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckVycm9yQ2F0ZWdvcnkuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-8.00%)` | |
| ... and [1289 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `21.01%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 37.89% -21.02%
+ Complexity 4185 2727 -1458
=============================================
Files 997 1016 +19
Lines 24973 25085 +112
Branches 2436 2442 +6
=============================================
- Hits 14710 9505 -5205
- Misses 8976 14847 +5871
+ Partials 1287 733 -554
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [372 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/92c0cb856d4df5ded4708d285c4e0ecce97dfd7a?el=desc) (92c0cb8) will **increase** coverage by `1.90%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
+ Coverage 49.25% 51.16% +1.90%
- Complexity 3594 3796 +202
============================================
Files 999 1037 +38
Lines 24877 25660 +783
Branches 2423 2512 +89
============================================
+ Hits 12253 13128 +875
+ Misses 11583 11394 -189
- Partials 1041 1138 +97
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | `3.00 <0.00> (ø)` | |
| [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | `33.33% <0.00%> (-26.67%)` | `3.00% <0.00%> (ø%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `87.96% <0.00%> (-6.49%)` | `26.00% <0.00%> (-3.00%)` | |
| [...e/skywalking/apm/agent/core/meter/MeterSender.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZW5kZXIuamF2YQ==) | `23.63% <0.00%> (-4.03%)` | `7.00% <0.00%> (ø%)` | |
| [...age/plugin/elasticsearch/base/IndexController.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9JbmRleENvbnRyb2xsZXIuamF2YQ==) | `88.88% <0.00%> (ø)` | `9.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/jvm/gc/SerialGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1NlcmlhbEdDTW9kdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...g/apache/skywalking/apm/toolkit/meter/Counter.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvQ291bnRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...m/agent/core/conf/RuntimeContextConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9SdW50aW1lQ29udGV4dENvbmZpZ3VyYXRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [99 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `27.98%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 30.91% -27.99%
+ Complexity 4185 2208 -1977
=============================================
Files 997 975 -22
Lines 24973 23953 -1020
Branches 2436 2334 -102
=============================================
- Hits 14710 7405 -7305
- Misses 8976 15990 +7014
+ Partials 1287 558 -729
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [457 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `23.45%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 35.45% -23.46%
+ Complexity 4185 2480 -1705
=============================================
Files 997 984 -13
Lines 24973 24117 -856
Branches 2436 2343 -93
=============================================
- Hits 14710 8550 -6160
- Misses 8976 14907 +5931
+ Partials 1287 660 -627
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [416 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/92c0cb856d4df5ded4708d285c4e0ecce97dfd7a?el=desc) (92c0cb8) will **increase** coverage by `0.39%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
+ Coverage 50.96% 51.35% +0.39%
- Complexity 3698 3804 +106
============================================
Files 999 1037 +38
Lines 24927 25660 +733
Branches 2429 2512 +83
============================================
+ Hits 12704 13178 +474
- Misses 11119 11332 +213
- Partials 1104 1150 +46
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | `3.00 <0.00> (ø)` | |
| [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | `33.33% <0.00%> (-26.67%)` | `3.00% <0.00%> (ø%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `87.96% <0.00%> (-6.49%)` | `26.00% <0.00%> (-3.00%)` | |
| [...e/skywalking/apm/agent/core/meter/MeterSender.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZW5kZXIuamF2YQ==) | `23.63% <0.00%> (-4.03%)` | `7.00% <0.00%> (ø%)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `72.07% <0.00%> (-0.91%)` | `22.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/jvm/gc/SerialGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1NlcmlhbEdDTW9kdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...g/apache/skywalking/apm/toolkit/meter/Counter.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvQ291bnRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...m/agent/core/conf/RuntimeContextConfiguration.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29uZi9SdW50aW1lQ29udGV4dENvbmZpZ3VyYXRpb24uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [71 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (9d4932f) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `17.88%`.
> The diff coverage is `3.33%`.
> :exclamation: Current head 9d4932f differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 41.01% -17.89%
+ Complexity 4185 2550 -1635
=============================================
Files 997 844 -153
Lines 24973 20993 -3980
Branches 2436 1985 -451
=============================================
- Hits 14710 8611 -6099
- Misses 8976 11729 +2753
+ Partials 1287 653 -634
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `52.25% <0.00%> (-30.32%)` | `16.00 <0.00> (-8.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `23.84% <0.00%> (-39.54%)` | `20.00 <0.00> (-43.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...log/analyzer/provider/log/ILogAnalyzerService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9sb2ctYW5hbHl6ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL2xvZy9hbmFseXplci9wcm92aWRlci9sb2cvSUxvZ0FuYWx5emVyU2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...server/library/util/prometheus/metrics/Metric.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpYy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [381 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `27.94%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 30.95% -27.95%
+ Complexity 4185 2208 -1977
=============================================
Files 997 970 -27
Lines 24973 23921 -1052
Branches 2436 2333 -103
=============================================
- Hits 14710 7405 -7305
- Misses 8976 15958 +6982
+ Partials 1287 558 -729
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [454 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (b6d6ce0) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `27.15%`.
> The diff coverage is `3.29%`.
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 31.74% -27.16%
+ Complexity 4185 2274 -1911
=============================================
Files 997 972 -25
Lines 24973 23975 -998
Branches 2436 2335 -101
=============================================
- Hits 14710 7612 -7098
- Misses 8976 15796 +6820
+ Partials 1287 567 -720
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-12.30%)` | `22.00 <0.00> (-2.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [427 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/92c0cb856d4df5ded4708d285c4e0ecce97dfd7a?el=desc) (92c0cb8) will **increase** coverage by `0.71%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
+ Coverage 54.10% 54.81% +0.71%
+ Complexity 4185 4034 -151
============================================
Files 1796 1037 -759
Lines 38497 25665 -12832
Branches 4237 2512 -1725
============================================
- Hits 20827 14068 -6759
+ Misses 16682 10368 -6314
- Partials 988 1229 +241
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+4.18%)` | `3.00 <0.00> (ø)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...e/skywalking/apm/agent/core/meter/CounterMode.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlck1vZGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...g/oap/server/core/cluster/ClusterHealthStatus.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvY2x1c3Rlci9DbHVzdGVySGVhbHRoU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1262 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/92c0cb856d4df5ded4708d285c4e0ecce97dfd7a?el=desc) (92c0cb8) will **increase** coverage by `2.10%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
+ Coverage 49.25% 51.35% +2.10%
- Complexity 3594 3804 +210
============================================
Files 999 1037 +38
Lines 24877 25660 +783
Branches 2423 2512 +89
============================================
+ Hits 12253 13178 +925
+ Misses 11583 11332 -251
- Partials 1041 1150 +109
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | `3.00 <0.00> (ø)` | |
| [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | `33.33% <0.00%> (-26.67%)` | `3.00% <0.00%> (ø%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `87.96% <0.00%> (-6.49%)` | `26.00% <0.00%> (-3.00%)` | |
| [...e/skywalking/apm/agent/core/meter/MeterSender.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZW5kZXIuamF2YQ==) | `23.63% <0.00%> (-4.03%)` | `7.00% <0.00%> (ø%)` | |
| [...age/plugin/elasticsearch/base/IndexController.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9JbmRleENvbnRyb2xsZXIuamF2YQ==) | `88.88% <0.00%> (ø)` | `9.00% <0.00%> (ø%)` | |
| [...ywalking/apm/agent/core/jvm/gc/SerialGCModule.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1NlcmlhbEdDTW9kdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...apache/skywalking/apm/toolkit/meter/BaseMeter.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvQmFzZU1ldGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [.../apache/skywalking/apm/agent/core/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [101 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `20.34%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 38.55% -20.35%
+ Complexity 4185 2782 -1403
=============================================
Files 997 1019 +22
Lines 24973 25184 +211
Branches 2436 2453 +17
=============================================
- Hits 14710 9710 -5000
- Misses 8976 14729 +5753
+ Partials 1287 745 -542
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [361 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/92c0cb856d4df5ded4708d285c4e0ecce97dfd7a?el=desc) (92c0cb8) will **increase** coverage by `2.10%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
+ Coverage 49.25% 51.35% +2.10%
- Complexity 3594 3804 +210
============================================
Files 999 1037 +38
Lines 24877 25660 +783
Branches 2423 2512 +89
============================================
+ Hits 12253 13178 +925
+ Misses 11583 11332 -251
- Partials 1041 1150 +109
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | `3.00 <0.00> (ø)` | |
| [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | `33.33% <0.00%> (-26.67%)` | `3.00% <0.00%> (ø%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `87.96% <0.00%> (-6.49%)` | `26.00% <0.00%> (-3.00%)` | |
| [...e/skywalking/apm/agent/core/meter/MeterSender.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZW5kZXIuamF2YQ==) | `23.63% <0.00%> (-4.03%)` | `7.00% <0.00%> (ø%)` | |
| [...age/plugin/elasticsearch/base/IndexController.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9JbmRleENvbnRyb2xsZXIuamF2YQ==) | `88.88% <0.00%> (ø)` | `9.00% <0.00%> (ø%)` | |
| [...pache/skywalking/apm/agent/core/meter/Counter.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...king/apm/agent/core/context/util/KeyValuePair.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL0tleVZhbHVlUGFpci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...ent/core/context/status/ExceptionCheckContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvRXhjZXB0aW9uQ2hlY2tDb250ZXh0LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [101 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (b6d6ce0) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `32.94%`.
> The diff coverage is `3.29%`.
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 25.96% -32.95%
+ Complexity 4185 1916 -2269
=============================================
Files 997 971 -26
Lines 24973 23886 -1087
Branches 2436 2328 -108
=============================================
- Hits 14710 6201 -8509
- Misses 8976 17210 +8234
+ Partials 1287 475 -812
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [531 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/92c0cb856d4df5ded4708d285c4e0ecce97dfd7a?el=desc) (92c0cb8) will **increase** coverage by `2.10%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
+ Coverage 49.25% 51.35% +2.10%
- Complexity 3594 3804 +210
============================================
Files 999 1037 +38
Lines 24877 25660 +783
Branches 2423 2512 +89
============================================
+ Hits 12253 13178 +925
+ Misses 11583 11332 -251
- Partials 1041 1150 +109
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | `3.00 <0.00> (ø)` | |
| [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | `33.33% <0.00%> (-26.67%)` | `3.00% <0.00%> (ø%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `87.96% <0.00%> (-6.49%)` | `26.00% <0.00%> (-3.00%)` | |
| [...e/skywalking/apm/agent/core/meter/MeterSender.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZW5kZXIuamF2YQ==) | `23.63% <0.00%> (-4.03%)` | `7.00% <0.00%> (ø%)` | |
| [...age/plugin/elasticsearch/base/IndexController.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9JbmRleENvbnRyb2xsZXIuamF2YQ==) | `88.88% <0.00%> (ø)` | `9.00% <0.00%> (ø%)` | |
| [...ent/core/context/status/ExceptionCheckContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvRXhjZXB0aW9uQ2hlY2tDb250ZXh0LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [.../apache/skywalking/apm/agent/core/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...ache/skywalking/apm/agent/core/util/FileUtils.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9GaWxlVXRpbHMuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...apache/skywalking/apm/toolkit/meter/BaseMeter.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvQmFzZU1ldGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [101 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/92c0cb856d4df5ded4708d285c4e0ecce97dfd7a?el=desc) (92c0cb8) will **increase** coverage by `3.19%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
+ Coverage 47.34% 50.54% +3.19%
- Complexity 3493 3754 +261
============================================
Files 999 1037 +38
Lines 24877 25638 +761
Branches 2423 2511 +88
============================================
+ Hits 11779 12958 +1179
+ Misses 12105 11572 -533
- Partials 993 1108 +115
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | `3.00 <0.00> (ø)` | |
| [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | `33.33% <0.00%> (-26.67%)` | `3.00% <0.00%> (ø%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [...e/skywalking/apm/agent/core/meter/MeterSender.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZW5kZXIuamF2YQ==) | `23.63% <0.00%> (-4.03%)` | `7.00% <0.00%> (ø%)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `70.27% <0.00%> (-0.91%)` | `22.00% <0.00%> (-1.00%)` | |
| [...age/plugin/elasticsearch/base/IndexController.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9JbmRleENvbnRyb2xsZXIuamF2YQ==) | `88.88% <0.00%> (ø)` | `9.00% <0.00%> (ø%)` | |
| [...pache/skywalking/apm/agent/core/meter/Counter.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQ291bnRlci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...king/apm/agent/core/context/util/KeyValuePair.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL0tleVZhbHVlUGFpci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...ent/core/context/status/ExceptionCheckContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvRXhjZXB0aW9uQ2hlY2tDb250ZXh0LmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [113 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `23.41%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 35.49% -23.42%
+ Complexity 4185 2480 -1705
=============================================
Files 997 983 -14
Lines 24973 24091 -882
Branches 2436 2343 -93
=============================================
- Hits 14710 8550 -6160
- Misses 8976 14881 +5905
+ Partials 1287 660 -627
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [415 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/92c0cb856d4df5ded4708d285c4e0ecce97dfd7a?el=desc) (92c0cb8) will **increase** coverage by `2.10%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
+ Coverage 49.25% 51.35% +2.10%
- Complexity 3594 3804 +210
============================================
Files 999 1037 +38
Lines 24877 25660 +783
Branches 2423 2512 +89
============================================
+ Hits 12253 13178 +925
+ Misses 11583 11332 -251
- Partials 1041 1150 +109
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | `3.00 <0.00> (ø)` | |
| [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | `33.33% <0.00%> (-26.67%)` | `3.00% <0.00%> (ø%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `87.96% <0.00%> (-6.49%)` | `26.00% <0.00%> (-3.00%)` | |
| [...e/skywalking/apm/agent/core/meter/MeterSender.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZW5kZXIuamF2YQ==) | `23.63% <0.00%> (-4.03%)` | `7.00% <0.00%> (ø%)` | |
| [...age/plugin/elasticsearch/base/IndexController.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9JbmRleENvbnRyb2xsZXIuamF2YQ==) | `88.88% <0.00%> (ø)` | `9.00% <0.00%> (ø%)` | |
| [...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...org/apache/skywalking/apm/toolkit/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...apache/skywalking/apm/toolkit/meter/BaseMeter.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvQmFzZU1ldGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [101 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `20.40%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 38.49% -20.41%
+ Complexity 4185 2782 -1403
=============================================
Files 997 1020 +23
Lines 24973 25223 +250
Branches 2436 2454 +18
=============================================
- Hits 14710 9710 -5000
- Misses 8976 14768 +5792
+ Partials 1287 745 -542
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [362 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `20.19%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 38.70% -20.20%
+ Complexity 4185 2782 -1403
=============================================
Files 997 1016 +19
Lines 24973 25085 +112
Branches 2436 2442 +6
=============================================
- Hits 14710 9710 -5000
- Misses 8976 14630 +5654
+ Partials 1287 745 -542
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [358 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `19.95%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 38.94% -19.96%
+ Complexity 4185 2821 -1364
=============================================
Files 997 1020 +23
Lines 24973 25251 +278
Branches 2436 2459 +23
=============================================
- Hits 14710 9835 -4875
- Misses 8976 14665 +5689
+ Partials 1287 751 -536
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [351 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `27.97%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 30.92% -27.98%
+ Complexity 4185 2208 -1977
=============================================
Files 997 973 -24
Lines 24973 23942 -1031
Branches 2436 2334 -102
=============================================
- Hits 14710 7405 -7305
- Misses 8976 15979 +7003
+ Partials 1287 558 -729
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [455 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (b6d6ce0) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `15.06%`.
> The diff coverage is `3.29%`.
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 43.83% -15.07%
+ Complexity 4185 3189 -996
=============================================
Files 997 974 -23
Lines 24973 24179 -794
Branches 2436 2361 -75
=============================================
- Hits 14710 10599 -4111
- Misses 8976 12691 +3715
+ Partials 1287 889 -398
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | `3.00 <0.00> (ø)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `79.27% <0.00%> (-3.29%)` | `23.00 <0.00> (-1.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `60.00% <0.00%> (-3.39%)` | `62.00 <0.00> (-1.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [.../apm/agent/core/context/ids/PropagatedTraceId.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvUHJvcGFnYXRlZFRyYWNlSWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [258 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `23.47%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 35.42% -23.48%
+ Complexity 4185 2480 -1705
=============================================
Files 997 985 -12
Lines 24973 24133 -840
Branches 2436 2347 -89
=============================================
- Hits 14710 8550 -6160
- Misses 8976 14923 +5947
+ Partials 1287 660 -627
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [417 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/a396888de804a8f7090db70e6a2b7879684c4bf0?el=desc) (a396888) will **decrease** coverage by `20.40%`.
> The diff coverage is `3.29%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
=============================================
- Coverage 58.90% 38.49% -20.41%
+ Complexity 4185 2782 -1403
=============================================
Files 997 1020 +23
Lines 24973 25223 +250
Branches 2436 2454 +18
=============================================
- Hits 14710 9710 -5000
- Misses 8976 14768 +5792
+ Partials 1287 745 -542
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `0.00% <0.00%> (-62.50%)` | `0.00 <0.00> (-3.00)` | |
| [...apache/skywalking/oap/meter/analyzer/Analyzer.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvQW5hbHl6ZXIuamF2YQ==) | `68.46% <0.00%> (-14.11%)` | `21.00 <0.00> (-3.00)` | |
| [...p/meter/analyzer/dsl/ExpressionParsingContext.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0V4cHJlc3Npb25QYXJzaW5nQ29udGV4dC5qYXZh) | `93.75% <ø> (ø)` | `6.00 <0.00> (ø)` | |
| [...kywalking/oap/meter/analyzer/dsl/SampleFamily.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL1NhbXBsZUZhbWlseS5qYXZh) | `52.30% <0.00%> (-11.08%)` | `55.00 <0.00> (-8.00)` | |
| [...ng/oap/meter/analyzer/dsl/tagOpt/K8sRetagType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL3RhZ09wdC9LOHNSZXRhZ1R5cGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...alking/oap/meter/analyzer/k8s/K8sInfoRegistry.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvazhzL0s4c0luZm9SZWdpc3RyeS5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [.../apache/skywalking/oap/meter/analyzer/dsl/DSL.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9hbmFseXplci9tZXRlci1hbmFseXplci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvbWV0ZXIvYW5hbHl6ZXIvZHNsL0RTTC5qYXZh) | `88.88% <100.00%> (+5.55%)` | `1.00 <0.00> (ø)` | |
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...he/skywalking/apm/agent/core/boot/BootService.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYm9vdC9Cb290U2VydmljZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [362 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/92c0cb856d4df5ded4708d285c4e0ecce97dfd7a?el=desc) (92c0cb8) will **increase** coverage by `1.90%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
+ Coverage 49.25% 51.16% +1.90%
- Complexity 3594 3796 +202
============================================
Files 999 1037 +38
Lines 24877 25660 +783
Branches 2423 2512 +89
============================================
+ Hits 12253 13128 +875
+ Misses 11583 11394 -189
- Partials 1041 1138 +97
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | `3.00 <0.00> (ø)` | |
| [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | `33.33% <0.00%> (-26.67%)` | `3.00% <0.00%> (ø%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `87.96% <0.00%> (-6.49%)` | `26.00% <0.00%> (-3.00%)` | |
| [...e/skywalking/apm/agent/core/meter/MeterSender.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZW5kZXIuamF2YQ==) | `23.63% <0.00%> (-4.03%)` | `7.00% <0.00%> (ø%)` | |
| [...age/plugin/elasticsearch/base/IndexController.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9JbmRleENvbnRyb2xsZXIuamF2YQ==) | `88.88% <0.00%> (ø)` | `9.00% <0.00%> (ø%)` | |
| [...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...pache/skywalking/apm/agent/core/meter/MeterId.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJJZC5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...apache/skywalking/apm/agent/core/util/IOUtils.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9JT1V0aWxzLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [.../apache/skywalking/apm/agent/core/meter/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvR2F1Z2UuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [99 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/92c0cb856d4df5ded4708d285c4e0ecce97dfd7a?el=desc) (92c0cb8) will **increase** coverage by `2.10%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
+ Coverage 49.25% 51.35% +2.10%
- Complexity 3594 3804 +210
============================================
Files 999 1037 +38
Lines 24877 25660 +783
Branches 2423 2512 +89
============================================
+ Hits 12253 13178 +925
+ Misses 11583 11332 -251
- Partials 1041 1150 +109
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | `3.00 <0.00> (ø)` | |
| [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | `33.33% <0.00%> (-26.67%)` | `3.00% <0.00%> (ø%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `87.96% <0.00%> (-6.49%)` | `26.00% <0.00%> (-3.00%)` | |
| [...e/skywalking/apm/agent/core/meter/MeterSender.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZW5kZXIuamF2YQ==) | `23.63% <0.00%> (-4.03%)` | `7.00% <0.00%> (ø%)` | |
| [...age/plugin/elasticsearch/base/IndexController.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9JbmRleENvbnRyb2xsZXIuamF2YQ==) | `88.88% <0.00%> (ø)` | `9.00% <0.00%> (ø%)` | |
| [...ache/skywalking/apm/agent/core/meter/MeterTag.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUYWcuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...alking/apm/agent/core/logging/core/FileWriter.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0ZpbGVXcml0ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...che/skywalking/apm/agent/core/meter/MeterType.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...apache/skywalking/apm/toolkit/meter/Histogram.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLWFwcGxpY2F0aW9uLXRvb2xraXQvYXBtLXRvb2xraXQtbWV0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3Rvb2xraXQvbWV0ZXIvSGlzdG9ncmFtLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [101 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #6623: Timestamp in GlobalIdGenerator is implemented using ThreadLocalRandom
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #6623:
URL: https://github.com/apache/skywalking/pull/6623#issuecomment-807053277
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=h1) Report
> Merging [#6623](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=desc) (1dda54e) into [master](https://codecov.io/gh/apache/skywalking/commit/92c0cb856d4df5ded4708d285c4e0ecce97dfd7a?el=desc) (92c0cb8) will **increase** coverage by `1.86%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 1dda54e differs from pull request most recent head b6d6ce0. Consider uploading reports for the commit b6d6ce0 to get more accurate results
[](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6623 +/- ##
============================================
+ Coverage 49.25% 51.11% +1.86%
- Complexity 3594 3792 +198
============================================
Files 999 1037 +38
Lines 24877 25660 +783
Branches 2423 2512 +89
============================================
+ Hits 12253 13116 +863
+ Misses 11583 11406 -177
- Partials 1041 1138 +97
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../apm/agent/core/context/ids/GlobalIdGenerator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9pZHMvR2xvYmFsSWRHZW5lcmF0b3IuamF2YQ==) | `68.18% <0.00%> (+5.68%)` | `3.00 <0.00> (ø)` | |
| [...apm/agent/core/remote/AuthenticationDecorator.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0F1dGhlbnRpY2F0aW9uRGVjb3JhdG9yLmphdmE=) | `33.33% <0.00%> (-26.67%)` | `3.00% <0.00%> (ø%)` | |
| [...king/aop/server/receiver/mesh/MeshGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL01lc2hHUlBDSGFuZGxlci5qYXZh) | `64.28% <0.00%> (-10.72%)` | `3.00% <0.00%> (+1.00%)` | :arrow_down: |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `87.96% <0.00%> (-6.49%)` | `26.00% <0.00%> (-3.00%)` | |
| [...e/skywalking/apm/agent/core/meter/MeterSender.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvTWV0ZXJTZW5kZXIuamF2YQ==) | `23.63% <0.00%> (-4.03%)` | `7.00% <0.00%> (ø%)` | |
| [...age/plugin/elasticsearch/base/IndexController.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9JbmRleENvbnRyb2xsZXIuamF2YQ==) | `88.88% <0.00%> (ø)` | `9.00% <0.00%> (ø%)` | |
| [...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...ent/core/jvm/memorypool/SerialCollectorModule.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeXBvb2wvU2VyaWFsQ29sbGVjdG9yTW9kdWxlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...che/skywalking/apm/agent/core/meter/BaseMeter.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbWV0ZXIvQmFzZU1ldGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
| ... and [99 more](https://codecov.io/gh/apache/skywalking/pull/6623/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=footer). Last update [92c0cb8...b6d6ce0](https://codecov.io/gh/apache/skywalking/pull/6623?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org