You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Hive QA (JIRA)" <ji...@apache.org> on 2018/09/06 18:11:00 UTC

[jira] [Commented] (HIVE-20095) Fix jdbc external table feature

    [ https://issues.apache.org/jira/browse/HIVE-20095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16606195#comment-16606195 ] 

Hive QA commented on HIVE-20095:
--------------------------------

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 38s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  8m  8s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m  6s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 19s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 44s{color} | {color:blue} serde in master has 195 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 28s{color} | {color:blue} druid-handler in master has 13 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  0m 26s{color} | {color:blue} jdbc-handler in master has 8 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue}  4m 13s{color} | {color:blue} ql in master has 2310 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 38s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 10s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 17s{color} | {color:red} druid-handler in the patch failed. {color} |
| {color:red}-1{color} | {color:red} mvninstall {color} | {color:red}  0m 14s{color} | {color:red} jdbc-handler in the patch failed. {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m  6s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  2m  6s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 16s{color} | {color:red} serde: The patch generated 1 new + 2 unchanged - 0 fixed = 3 total (was 2) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 11s{color} | {color:green} druid-handler: The patch generated 0 new + 10 unchanged - 1 fixed = 10 total (was 11) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red}  0m 11s{color} | {color:red} jdbc-handler: The patch generated 78 new + 25 unchanged - 0 fixed = 103 total (was 25) {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 42s{color} | {color:green} The patch ql passed checkstyle {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red}  0m  0s{color} | {color:red} The patch has 11 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  0m 32s{color} | {color:red} jdbc-handler generated 3 new + 8 unchanged - 0 fixed = 11 total (was 8) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  1m 37s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 13s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 35m  1s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:jdbc-handler |
|  |  Exception is caught when Exception is not thrown in org.apache.hive.storage.jdbc.JdbcSerDe.initialize(Configuration, Properties)  At JdbcSerDe.java:is not thrown in org.apache.hive.storage.jdbc.JdbcSerDe.initialize(Configuration, Properties)  At JdbcSerDe.java:[line 114] |
|  |  org.apache.hive.storage.jdbc.dao.GenericJdbcDatabaseAccessor.getColumnTypes(Configuration) may fail to clean up java.sql.ResultSet  Obligation to clean up resource created at GenericJdbcDatabaseAccessor.java:up java.sql.ResultSet  Obligation to clean up resource created at GenericJdbcDatabaseAccessor.java:[line 115] is not discharged |
|  |  org.apache.hive.storage.jdbc.dao.GenericJdbcDatabaseAccessor.getColumnTypes(Configuration) may fail to clean up java.sql.Statement  Obligation to clean up resource created at GenericJdbcDatabaseAccessor.java:up java.sql.Statement  Obligation to clean up resource created at GenericJdbcDatabaseAccessor.java:[line 114] is not discharged |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests |  asflicense  javac  javadoc  findbugs  checkstyle  compile  |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-13627/dev-support/hive-personality.sh |
| git revision | master / 50d5bbb |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.0 |
| mvninstall | http://104.198.109.242/logs//PreCommit-HIVE-Build-13627/yetus/patch-mvninstall-druid-handler.txt |
| mvninstall | http://104.198.109.242/logs//PreCommit-HIVE-Build-13627/yetus/patch-mvninstall-jdbc-handler.txt |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-13627/yetus/diff-checkstyle-serde.txt |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-13627/yetus/diff-checkstyle-jdbc-handler.txt |
| whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-13627/yetus/whitespace-eol.txt |
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-13627/yetus/new-findbugs-jdbc-handler.html |
| modules | C: serde druid-handler itests jdbc-handler ql U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-13627/yetus.txt |
| Powered by | Apache Yetus    http://yetus.apache.org |


This message was automatically generated.



> Fix jdbc external table feature
> -------------------------------
>
>                 Key: HIVE-20095
>                 URL: https://issues.apache.org/jira/browse/HIVE-20095
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Jonathan Doron
>            Assignee: Jonathan Doron
>            Priority: Major
>         Attachments: HIVE-20095.1.patch, HIVE-20095.2.patch, HIVE-20095.3.patch, HIVE-20095.4.patch, HIVE-20095.5.patch
>
>
> It seems like the committed code for HIVE-19161 
> (7584b3276bebf64aa006eaa162c0a6264d8fcb56) reverted some of HIVE-18423 updates, and therefore some of the external table queries are not working correctly.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)