[jira] [Created] (THRIFT-2657) py.twisted/test_suite.py:ThriftTestCase.testOneway spuriously fails on loaded machines

["James Broadhead (JIRA)" <ji...@apache.org>]

James Broadhead created THRIFT-2657:
---------------------------------------

             Summary: py.twisted/test_suite.py:ThriftTestCase.testOneway spuriously fails on loaded machines 
                 Key: THRIFT-2657
                 URL: https://issues.apache.org/jira/browse/THRIFT-2657
             Project: Thrift
          Issue Type: Bug
            Reporter: James Broadhead
            Priority: Minor


py.twisted/test_suite.py:ThriftTestCase.testOneway
relies on a call to 
client.testOneway(2)
taking less than
2.005 seconds 
(2.004 succeeds, because round(2 - 2.004, 2) == 0)
On a loaded (or slow) machine, this isn't guaranteed. 

Suggest that the sensitivity of this test be significantly relaxed, unless this is a  test measuring performance (which I do not believe it to be)
 
{code}
===============================================================================
[FAIL]
Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/twisted/internet/defer.py", line 1070, in _inlineCallbacks
    result = g.send(result)
  File "/home/hangfire/checkouts/github/thrift-clean/test/py.twisted/test_suite.py", line 184, in testOneway
    self.assertAlmostEquals(seconds, (end - start), places=2)
  File "/usr/lib64/python2.7/site-packages/twisted/trial/_synctest.py", line 472, in assertAlmostEqual
    % (first, second, places))
twisted.trial.unittest.FailTest: 2 != 2.0055909156799316 within 2 places

test_suite.ThriftTestCase.testOneway
-------------------------------------------------------------------------------
{code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)