You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Michael Tamm (JIRA)" <ji...@apache.org> on 2009/03/06 11:07:59 UTC
[jira] Created: (HADOOP-5423) It should be posible to specify
metadata for the output file produced by SequenceFile.Sorter.sort
It should be posible to specify metadata for the output file produced by SequenceFile.Sorter.sort
-------------------------------------------------------------------------------------------------
Key: HADOOP-5423
URL: https://issues.apache.org/jira/browse/HADOOP-5423
Project: Hadoop Core
Issue Type: Improvement
Components: io
Affects Versions: 0.19.1
Reporter: Michael Tamm
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-5423) It should be posible to specify
metadata for the output file produced by SequenceFile.Sorter.sort
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting reassigned HADOOP-5423:
------------------------------------
Assignee: Michael Tamm (was: Doug Cutting)
The test looks good. Can you please combine the two patches into a single patch file, then select "Submit Patch" to trigger automated testing? Thanks!
Also, the "Assignee" should stay set to the primary author of the patch, so that they retain credit for the contribution.
> It should be posible to specify metadata for the output file produced by SequenceFile.Sorter.sort
> -------------------------------------------------------------------------------------------------
>
> Key: HADOOP-5423
> URL: https://issues.apache.org/jira/browse/HADOOP-5423
> Project: Hadoop Core
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.19.1
> Reporter: Michael Tamm
> Assignee: Michael Tamm
> Attachments: SequenceFile.patch, TestSequenceFile.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5423) It should be posible to specify
metadata for the output file produced by SequenceFile.Sorter.sort
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-5423:
----------------------------------
Resolution: Fixed
Fix Version/s: 0.21.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
+1
I committed this. Thanks, Michael
> It should be posible to specify metadata for the output file produced by SequenceFile.Sorter.sort
> -------------------------------------------------------------------------------------------------
>
> Key: HADOOP-5423
> URL: https://issues.apache.org/jira/browse/HADOOP-5423
> Project: Hadoop Core
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.19.1
> Reporter: Michael Tamm
> Assignee: Michael Tamm
> Fix For: 0.21.0
>
> Attachments: fix_and_test_for_HADOOP-5423.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5423) It should be posible to specify
metadata for the output file produced by SequenceFile.Sorter.sort
Posted by "Michael Tamm (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Tamm updated HADOOP-5423:
---------------------------------
Attachment: (was: TestSequenceFile.patch)
> It should be posible to specify metadata for the output file produced by SequenceFile.Sorter.sort
> -------------------------------------------------------------------------------------------------
>
> Key: HADOOP-5423
> URL: https://issues.apache.org/jira/browse/HADOOP-5423
> Project: Hadoop Core
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.19.1
> Reporter: Michael Tamm
> Assignee: Michael Tamm
> Attachments: fix_and_test_for_HADOOP-5423.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5423) It should be posible to specify
metadata for the output file produced by SequenceFile.Sorter.sort
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12681882#action_12681882 ]
Hadoop QA commented on HADOOP-5423:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12402134/fix_and_test_for_HADOOP-5423.patch
against trunk revision 753113.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/62/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/62/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/62/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/62/console
This message is automatically generated.
> It should be posible to specify metadata for the output file produced by SequenceFile.Sorter.sort
> -------------------------------------------------------------------------------------------------
>
> Key: HADOOP-5423
> URL: https://issues.apache.org/jira/browse/HADOOP-5423
> Project: Hadoop Core
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.19.1
> Reporter: Michael Tamm
> Assignee: Michael Tamm
> Attachments: fix_and_test_for_HADOOP-5423.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (HADOOP-5423) It should be posible to specify
metadata for the output file produced by SequenceFile.Sorter.sort
Posted by "Michael Tamm (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on HADOOP-5423 started by Michael Tamm.
> It should be posible to specify metadata for the output file produced by SequenceFile.Sorter.sort
> -------------------------------------------------------------------------------------------------
>
> Key: HADOOP-5423
> URL: https://issues.apache.org/jira/browse/HADOOP-5423
> Project: Hadoop Core
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.19.1
> Reporter: Michael Tamm
> Assignee: Michael Tamm
> Attachments: SequenceFile.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5423) It should be posible to specify
metadata for the output file produced by SequenceFile.Sorter.sort
Posted by "Michael Tamm (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Tamm updated HADOOP-5423:
---------------------------------
Status: Patch Available (was: In Progress)
> It should be posible to specify metadata for the output file produced by SequenceFile.Sorter.sort
> -------------------------------------------------------------------------------------------------
>
> Key: HADOOP-5423
> URL: https://issues.apache.org/jira/browse/HADOOP-5423
> Project: Hadoop Core
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.19.1
> Reporter: Michael Tamm
> Assignee: Michael Tamm
> Attachments: fix_and_test_for_HADOOP-5423.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-5423) It should be posible to specify
metadata for the output file produced by SequenceFile.Sorter.sort
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting reassigned HADOOP-5423:
------------------------------------
Assignee: Michael Tamm
Can you please add a test for this, probably to TestSequenceFile.java? Thanks!
> It should be posible to specify metadata for the output file produced by SequenceFile.Sorter.sort
> -------------------------------------------------------------------------------------------------
>
> Key: HADOOP-5423
> URL: https://issues.apache.org/jira/browse/HADOOP-5423
> Project: Hadoop Core
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.19.1
> Reporter: Michael Tamm
> Assignee: Michael Tamm
> Attachments: SequenceFile.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5423) It should be posible to specify
metadata for the output file produced by SequenceFile.Sorter.sort
Posted by "Michael Tamm (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Tamm updated HADOOP-5423:
---------------------------------
Attachment: SequenceFile.patch
I attached a patch, which fixes this issue.
> It should be posible to specify metadata for the output file produced by SequenceFile.Sorter.sort
> -------------------------------------------------------------------------------------------------
>
> Key: HADOOP-5423
> URL: https://issues.apache.org/jira/browse/HADOOP-5423
> Project: Hadoop Core
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.19.1
> Reporter: Michael Tamm
> Attachments: SequenceFile.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-5423) It should be posible to specify
metadata for the output file produced by SequenceFile.Sorter.sort
Posted by "Michael Tamm (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Tamm reassigned HADOOP-5423:
------------------------------------
Assignee: Doug Cutting (was: Michael Tamm)
> It should be posible to specify metadata for the output file produced by SequenceFile.Sorter.sort
> -------------------------------------------------------------------------------------------------
>
> Key: HADOOP-5423
> URL: https://issues.apache.org/jira/browse/HADOOP-5423
> Project: Hadoop Core
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.19.1
> Reporter: Michael Tamm
> Assignee: Doug Cutting
> Attachments: SequenceFile.patch, TestSequenceFile.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5423) It should be posible to specify
metadata for the output file produced by SequenceFile.Sorter.sort
Posted by "Michael Tamm (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Tamm updated HADOOP-5423:
---------------------------------
Attachment: (was: SequenceFile.patch)
> It should be posible to specify metadata for the output file produced by SequenceFile.Sorter.sort
> -------------------------------------------------------------------------------------------------
>
> Key: HADOOP-5423
> URL: https://issues.apache.org/jira/browse/HADOOP-5423
> Project: Hadoop Core
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.19.1
> Reporter: Michael Tamm
> Assignee: Michael Tamm
> Attachments: fix_and_test_for_HADOOP-5423.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5423) It should be posible to specify
metadata for the output file produced by SequenceFile.Sorter.sort
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695446#action_12695446 ]
Hudson commented on HADOOP-5423:
--------------------------------
Integrated in Hadoop-trunk #796 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/796/])
> It should be posible to specify metadata for the output file produced by SequenceFile.Sorter.sort
> -------------------------------------------------------------------------------------------------
>
> Key: HADOOP-5423
> URL: https://issues.apache.org/jira/browse/HADOOP-5423
> Project: Hadoop Core
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.19.1
> Reporter: Michael Tamm
> Assignee: Michael Tamm
> Fix For: 0.21.0
>
> Attachments: fix_and_test_for_HADOOP-5423.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5423) It should be posible to specify
metadata for the output file produced by SequenceFile.Sorter.sort
Posted by "Michael Tamm (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Tamm updated HADOOP-5423:
---------------------------------
Attachment: fix_and_test_for_HADOOP-5423.patch
Attached fix_and_test_for_HADOOP-5423.patch, which contains the fix and the test.
> It should be posible to specify metadata for the output file produced by SequenceFile.Sorter.sort
> -------------------------------------------------------------------------------------------------
>
> Key: HADOOP-5423
> URL: https://issues.apache.org/jira/browse/HADOOP-5423
> Project: Hadoop Core
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.19.1
> Reporter: Michael Tamm
> Assignee: Michael Tamm
> Attachments: fix_and_test_for_HADOOP-5423.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5423) It should be posible to specify
metadata for the output file produced by SequenceFile.Sorter.sort
Posted by "Michael Tamm (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Tamm updated HADOOP-5423:
---------------------------------
Attachment: TestSequenceFile.patch
I just attached TestSequenceFile.patch, which adds the test for metadata handling by SequenceFile.Sorter to the already existing testSequenceFileMetadata method. (This patch of course uses the new SequenceFile.Sorter constructor provided by [SequenceFile.patch|https://issues.apache.org/jira/secure/attachment/12401614/SequenceFile.patch].)
> It should be posible to specify metadata for the output file produced by SequenceFile.Sorter.sort
> -------------------------------------------------------------------------------------------------
>
> Key: HADOOP-5423
> URL: https://issues.apache.org/jira/browse/HADOOP-5423
> Project: Hadoop Core
> Issue Type: Improvement
> Components: io
> Affects Versions: 0.19.1
> Reporter: Michael Tamm
> Assignee: Michael Tamm
> Attachments: SequenceFile.patch, TestSequenceFile.patch
>
>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.