[jira] Commented: (HBASE-3198) Log rolling archives files prematurely

["HBase Review Board (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-3198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928829#action_12928829 ] 

HBase Review Board commented on HBASE-3198:
-------------------------------------------

Message from: "Jean-Daniel Cryans" <jd...@apache.org>

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://review.cloudera.org/r/1181/
-----------------------------------------------------------

Review request for hbase.


Summary
-------

Removes the +1, -1 madness that I described in the jira and adds a unit test for log cleaning.


This addresses bug HBASE-3198.
    http://issues.apache.org/jira/browse/HBASE-3198


Diffs
-----

  /trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLog.java 1031797 
  /trunk/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestHLog.java 1031797 

Diff: http://review.cloudera.org/r/1181/diff


Testing
-------


Thanks,

Jean-Daniel




> Log rolling archives files prematurely
> --------------------------------------
>
>                 Key: HBASE-3198
>                 URL: https://issues.apache.org/jira/browse/HBASE-3198
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Jean-Daniel Cryans
>            Assignee: Jean-Daniel Cryans
>            Priority: Blocker
>             Fix For: 0.90.0
>
>
> From the mailing list, Erdem Agaoglu found a case where when an HLog gets rolled from the periodic log roller and it gets archived even tho the region (ROOT) still has edits in the MemStore. I did an experiment on a local empty machine and it does look broken:
> {noformat}
> org.apache.hadoop.hbase.regionserver.LogRoller: Hlog roll period 6000ms elapsed
> org.apache.hadoop.hbase.regionserver.wal.SequenceFileLogWriter: Using syncFs -- HDFS-200
> org.apache.hadoop.hbase.regionserver.wal.HLog: Roll /hbase-89-su/.logs/hbasedev,60020,1288977933643/10.10.1.177%3A60020.1288977933829, entries=1,
>  filesize=295. New hlog /hbase-89-su/.logs/hbasedev,60020,1288977933643/10.10.1.177%3A60020.1288977943913
> org.apache.hadoop.hbase.regionserver.wal.HLog: Found 1 hlogs to remove  out of total 1; oldest outstanding sequenceid is 270055 from region -ROOT-,,0
> org.apache.hadoop.hbase.regionserver.wal.HLog: moving old hlog file /hbase-89-su/.logs/hbasedev,60020,1288977933643/10.10.1.177%3A60020.1288977933829
>  whose highest sequenceid is 270054 to /hbase-89-su/.oldlogs/10.10.1.177%3A60020.1288977933829
> {noformat}
> Marking as Blocker and taking a deeper look.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.