[GitHub] [incubator-streampark] wolfboys commented on a diff in pull request #1799: [Improve] Add file name interception

[GitBox <gi...@apache.org>]

wolfboys commented on code in PR #1799:
URL: https://github.com/apache/incubator-streampark/pull/1799#discussion_r991821083


##########
streampark-console/streampark-console-service/src/test/java/org/apache/streampark/console/core/service/ApplicationServiceTest.java:
##########
@@ -89,4 +94,15 @@ public void start() throws Exception {
         applicationService.start(application, false);
     }
 
+    @Test
+    public void uploadTest() throws Exception {

Review Comment:
   > I think we need to add another test for verifying the uploaded file is not a jar file. It looks like we just verify the ContentType
   
   Thanks very much for your review, next we will provide test cases to verify the upload file type.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org