You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by Gus Heck <gu...@gmail.com> on 2021/02/20 22:13:59 UTC

Simplifying source pattern checks

I noticed today that SOLR-10883 added checks for patterns that didn't play
nice with PDF generation. Now that we don't generate the PDF anymore
perhaps we can do away with those checks? Anyone have thoughts to the
contrary?

https://issues.apache.org/jira/browse/SOLR-10883

-Gus

-- 
http://www.needhamsoftware.com (work)
http://www.the111shift.com (play)

Re: Simplifying source pattern checks

Posted by Gus Heck <gu...@gmail.com>.
Sure I can do that. Was going to file an issue and link. I think adding a
link sends a mail to the linked issue, but I could be wrong.

On Sun, Feb 21, 2021 at 11:57 AM David Smiley <ds...@apache.org> wrote:

> Makes sense.  I see you haven't commented on the issue about this; I
> prefer that tactic as it gets noticed by everyone "Watching" the original
> issue, even if it's old.
>
> ~ David Smiley
> Apache Lucene/Solr Search Developer
> http://www.linkedin.com/in/davidwsmiley
>
>
> On Sat, Feb 20, 2021 at 5:14 PM Gus Heck <gu...@gmail.com> wrote:
>
>> I noticed today that SOLR-10883 added checks for patterns that didn't
>> play nice with PDF generation. Now that we don't generate the PDF anymore
>> perhaps we can do away with those checks? Anyone have thoughts to the
>> contrary?
>>
>> https://issues.apache.org/jira/browse/SOLR-10883
>>
>> -Gus
>>
>> --
>> http://www.needhamsoftware.com (work)
>> http://www.the111shift.com (play)
>>
>

-- 
http://www.needhamsoftware.com (work)
http://www.the111shift.com (play)

Re: Simplifying source pattern checks

Posted by David Smiley <ds...@apache.org>.
Makes sense.  I see you haven't commented on the issue about this; I prefer
that tactic as it gets noticed by everyone "Watching" the original issue,
even if it's old.

~ David Smiley
Apache Lucene/Solr Search Developer
http://www.linkedin.com/in/davidwsmiley


On Sat, Feb 20, 2021 at 5:14 PM Gus Heck <gu...@gmail.com> wrote:

> I noticed today that SOLR-10883 added checks for patterns that didn't play
> nice with PDF generation. Now that we don't generate the PDF anymore
> perhaps we can do away with those checks? Anyone have thoughts to the
> contrary?
>
> https://issues.apache.org/jira/browse/SOLR-10883
>
> -Gus
>
> --
> http://www.needhamsoftware.com (work)
> http://www.the111shift.com (play)
>