You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Michał Letyński (JIRA)" <ji...@apache.org> on 2010/06/23 15:27:52 UTC
[jira] Created: (WICKET-2924) Duplicated method implementation
setDefaultFormProcessing for AbstarctSubmitLink and Button.
Duplicated method implementation setDefaultFormProcessing for AbstarctSubmitLink and Button.
--------------------------------------------------------------------------------------------
Key: WICKET-2924
URL: https://issues.apache.org/jira/browse/WICKET-2924
Project: Wicket
Issue Type: Improvement
Components: wicket
Reporter: Michał Letyński
Fix For: 1.4.10
My probllem here is that i have SubmitLinks and Buttons and i set setDefaultFormProcessing for certain conditions. I must first check whant instance is this, cast and set value. Its annoying.
Please move it to one class or provide an interface for this. JavaDoc for AbstractLink has this problem annotated already: "TODO: This is a copy & paste from Button"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-2924) Duplicated method implementation
setDefaultFormProcessing for AbstarctSubmitLink and Button.
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reassigned WICKET-2924:
---------------------------------------
Assignee: Martin Grigorov
> Duplicated method implementation setDefaultFormProcessing for AbstarctSubmitLink and Button.
> --------------------------------------------------------------------------------------------
>
> Key: WICKET-2924
> URL: https://issues.apache.org/jira/browse/WICKET-2924
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Reporter: Michał Letyński
> Assignee: Martin Grigorov
> Fix For: 1.5-M1
>
>
> My probllem here is that i have SubmitLinks and Buttons and i set setDefaultFormProcessing for certain conditions. I must first check whant instance is this, cast and set value. Its annoying.
> Please move it to one class or provide an interface for this. JavaDoc for AbstractLink has this problem annotated already: "TODO: This is a copy & paste from Button"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-2924) Duplicated method implementation
setDefaultFormProcessing for AbstarctSubmitLink and Button.
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-2924.
-------------------------------------
Fix Version/s: 1.5-M1
(was: 1.4.10)
Resolution: Fixed
The improvement is committed in trunk (1.5.x) with r979064. As Juergen said earlier it can be changed in 1.4.x
> Duplicated method implementation setDefaultFormProcessing for AbstarctSubmitLink and Button.
> --------------------------------------------------------------------------------------------
>
> Key: WICKET-2924
> URL: https://issues.apache.org/jira/browse/WICKET-2924
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Reporter: Michał Letyński
> Assignee: Martin Grigorov
> Fix For: 1.5-M1
>
>
> My probllem here is that i have SubmitLinks and Buttons and i set setDefaultFormProcessing for certain conditions. I must first check whant instance is this, cast and set value. Its annoying.
> Please move it to one class or provide an interface for this. JavaDoc for AbstractLink has this problem annotated already: "TODO: This is a copy & paste from Button"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (WICKET-2924) Duplicated method
implementation setDefaultFormProcessing for AbstarctSubmitLink and Button.
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892116#action_12892116 ]
Martin Grigorov edited comment on WICKET-2924 at 7/25/10 12:37 PM:
-------------------------------------------------------------------
The improvement is committed in trunk (1.5.x) with r979064. As Juergen said earlier it can't be changed in 1.4.x
was (Author: mgrigorov):
The improvement is committed in trunk (1.5.x) with r979064. As Juergen said earlier it can be changed in 1.4.x
> Duplicated method implementation setDefaultFormProcessing for AbstarctSubmitLink and Button.
> --------------------------------------------------------------------------------------------
>
> Key: WICKET-2924
> URL: https://issues.apache.org/jira/browse/WICKET-2924
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Reporter: Michał Letyński
> Assignee: Martin Grigorov
> Fix For: 1.5-M1
>
>
> My probllem here is that i have SubmitLinks and Buttons and i set setDefaultFormProcessing for certain conditions. I must first check whant instance is this, cast and set value. Its annoying.
> Please move it to one class or provide an interface for this. JavaDoc for AbstractLink has this problem annotated already: "TODO: This is a copy & paste from Button"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2924) Duplicated method implementation
setDefaultFormProcessing for AbstarctSubmitLink and Button.
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12892123#action_12892123 ]
Hudson commented on WICKET-2924:
--------------------------------
Integrated in Apache Wicket 1.5.x #171 (See [http://hudson.zones.apache.org/hudson/job/Apache%20Wicket%201.5.x/171/])
WICKET-2924 Duplicated method implementation setDefaultFormProcessing for AbstarctSubmitLink and Button.
Add setDefaultFormProcessing(boolean) to IFormSubmittingComponent
Fix javadocs
> Duplicated method implementation setDefaultFormProcessing for AbstarctSubmitLink and Button.
> --------------------------------------------------------------------------------------------
>
> Key: WICKET-2924
> URL: https://issues.apache.org/jira/browse/WICKET-2924
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Reporter: Michał Letyński
> Assignee: Martin Grigorov
> Fix For: 1.5-M1
>
>
> My probllem here is that i have SubmitLinks and Buttons and i set setDefaultFormProcessing for certain conditions. I must first check whant instance is this, cast and set value. Its annoying.
> Please move it to one class or provide an interface for this. JavaDoc for AbstractLink has this problem annotated already: "TODO: This is a copy & paste from Button"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-2924) Duplicated method implementation
setDefaultFormProcessing for AbstarctSubmitLink and Button.
Posted by "Juergen Donnerstag (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-2924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12887191#action_12887191 ]
Juergen Donnerstag commented on WICKET-2924:
--------------------------------------------
Since setDefaultFormProcessing() is defined in IFormSubmittingComponent, it probably makes sense to add
/**
* @param <T>
* @param defaultFormProcessing
* @return this
*/
<T extends Component> T setDefaultFormProcessing(boolean defaultFormProcessing);
to IFormSubmittingComponent as well. I've tested it locally and didn't require any other change. Obviously all Components implementing IFormSubmittingComponent are already implementing setDefaultFormProcessing(boolean).
Not sure we can make that change in 1.4 though, since existing user code implementing IFormSubmittingComponent might not work anymore without a change.
> Duplicated method implementation setDefaultFormProcessing for AbstarctSubmitLink and Button.
> --------------------------------------------------------------------------------------------
>
> Key: WICKET-2924
> URL: https://issues.apache.org/jira/browse/WICKET-2924
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Reporter: Michał Letyński
> Fix For: 1.4.10
>
>
> My probllem here is that i have SubmitLinks and Buttons and i set setDefaultFormProcessing for certain conditions. I must first check whant instance is this, cast and set value. Its annoying.
> Please move it to one class or provide an interface for this. JavaDoc for AbstractLink has this problem annotated already: "TODO: This is a copy & paste from Button"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.