You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2018/04/07 01:23:35 UTC

[kudu-CR] releasing: update gerrit update instructions

Hello Grant Henke,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/9950

to review the following change.


Change subject: releasing: update gerrit update instructions
......................................................................

releasing: update gerrit update instructions

The gerrit login instructions had some minor mistakes.

Change-Id: I2c249853bc22512f37c35ad9e3729bde09d33201
---
M RELEASING.adoc
1 file changed, 5 insertions(+), 6 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/9950/1
-- 
To view, visit http://gerrit.cloudera.org:8080/9950
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2c249853bc22512f37c35ad9e3729bde09d33201
Gerrit-Change-Number: 9950
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>

[kudu-CR] releasing: update gerrit update instructions

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9950 )

Change subject: releasing: update gerrit update instructions
......................................................................


Patch Set 1:

I think your account was set up more correctly than mine. Abandoning


-- 
To view, visit http://gerrit.cloudera.org:8080/9950
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c249853bc22512f37c35ad9e3729bde09d33201
Gerrit-Change-Number: 9950
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 10 Apr 2018 17:58:03 +0000
Gerrit-HasComments: No

[kudu-CR] releasing: update gerrit update instructions

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9950 )

Change subject: releasing: update gerrit update instructions
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9950/1/RELEASING.adoc
File RELEASING.adoc:

http://gerrit.cloudera.org:8080/#/c/9950/1/RELEASING.adoc@70
PS1, Line 70:   2. From behind the firewall, `ssh gerrit@gerrit.cloudera.org` to log in.
> Ha. Then your account was set up differently than mine (see step 1)
Interesting. I will get that fixed then.



-- 
To view, visit http://gerrit.cloudera.org:8080/9950
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c249853bc22512f37c35ad9e3729bde09d33201
Gerrit-Change-Number: 9950
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 10 Apr 2018 15:37:43 +0000
Gerrit-HasComments: Yes

[kudu-CR] releasing: update gerrit update instructions

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has abandoned this change. ( http://gerrit.cloudera.org:8080/9950 )

Change subject: releasing: update gerrit update instructions
......................................................................


Abandoned
-- 
To view, visit http://gerrit.cloudera.org:8080/9950
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I2c249853bc22512f37c35ad9e3729bde09d33201
Gerrit-Change-Number: 9950
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>

[kudu-CR] releasing: update gerrit update instructions

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9950 )

Change subject: releasing: update gerrit update instructions
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/9950
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c249853bc22512f37c35ad9e3729bde09d33201
Gerrit-Change-Number: 9950
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Tue, 10 Apr 2018 15:37:47 +0000
Gerrit-HasComments: No

[kudu-CR] releasing: update gerrit update instructions

Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change. ( http://gerrit.cloudera.org:8080/9950 )

Change subject: releasing: update gerrit update instructions
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9950/1/RELEASING.adoc
File RELEASING.adoc:

http://gerrit.cloudera.org:8080/#/c/9950/1/RELEASING.adoc@70
PS1, Line 70:   2. From behind the firewall, `ssh gerrit@gerrit.cloudera.org` to log in.
> I was not able to ssh to gerrit@ and instead needed shh as my user and sudo
Ha. Then your account was set up differently than mine (see step 1)



-- 
To view, visit http://gerrit.cloudera.org:8080/9950
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c249853bc22512f37c35ad9e3729bde09d33201
Gerrit-Change-Number: 9950
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Comment-Date: Mon, 09 Apr 2018 23:18:26 +0000
Gerrit-HasComments: Yes

[kudu-CR] releasing: update gerrit update instructions

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/9950 )

Change subject: releasing: update gerrit update instructions
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/9950/1/RELEASING.adoc
File RELEASING.adoc:

http://gerrit.cloudera.org:8080/#/c/9950/1/RELEASING.adoc@70
PS1, Line 70:   2. From behind the firewall, `ssh gerrit@gerrit.cloudera.org` to log in.
I was not able to ssh to gerrit@ and instead needed shh as my user and sudo to the gerrit user.



-- 
To view, visit http://gerrit.cloudera.org:8080/9950
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c249853bc22512f37c35ad9e3729bde09d33201
Gerrit-Change-Number: 9950
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Sat, 07 Apr 2018 22:24:01 +0000
Gerrit-HasComments: Yes

[kudu-CR] releasing: update gerrit update instructions

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.

Change subject: releasing: update gerrit update instructions
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/9950
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I2c249853bc22512f37c35ad9e3729bde09d33201
Gerrit-Change-Number: 9950
Gerrit-PatchSet: 1
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>